From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] net: annotate data-races around sk->sk_lingertime
Date: Fri, 18 Aug 2023 19:28:50 -0700 [thread overview]
Message-ID: <20230818192850.123e8331@kernel.org> (raw)
In-Reply-To: <20230818021132.2796092-1-edumazet@google.com>
On Fri, 18 Aug 2023 02:11:32 +0000 Eric Dumazet wrote:
> Remove preprocessor logic using BITS_PER_LONG, compilers
> are smart enough to figure this by themselves.
clang does complain that we're basically comparing an in to a MAX_LONG:
net/core/sock.c:1238:14: warning: result of comparison of constant 36893488147419103 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare]
if (t_sec >= MAX_SCHEDULE_TIMEOUT / HZ)
~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
Can we shut this up somehow? Or don't care?
next prev parent reply other threads:[~2023-08-19 2:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 2:11 [PATCH net-next] net: annotate data-races around sk->sk_lingertime Eric Dumazet
2023-08-18 6:40 ` Jason Xing
2023-08-19 2:28 ` Jakub Kicinski [this message]
2023-08-19 3:03 ` Eric Dumazet
2023-08-19 3:04 ` Jakub Kicinski
2023-08-19 4:02 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818192850.123e8331@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.