From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37EDEEE49A5 for ; Sat, 19 Aug 2023 11:53:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id DD154830E6; Sat, 19 Aug 2023 11:53:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org DD154830E6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1692445980; bh=5QtMmlj7xAu+lP1ewvGRw36a3YcrQ4MfB6HKC1tbC80=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=n/q56xhsUdE2ipJc5DUYtoT3C7dW+k96RSG20y2Eaa1K+vVQl0p30Xl7172Uregf7 LcE5t3uVRUcS25p7Yo3w8tNVFzgnhczv1vg5BbECK3ZNAJU1TJc5fSAOsceFD6aURZ hoGC3JMwtzovzn7AJtcCbRYNxWSAsJZpf+FLMNISIpMTCyEVnbiqXZ0K6eNoCoMm3k YwlvKfCLHZ41D2C6AsCGqNCJSf3tsQRW5UK5EC2amadCeA3ggXv4fBWxTWAJjWgwOH xQSIIMWqff8XI2IQoEj2ZBq6QNDCKULhfxnJ2D2hUqkWIzaC0o0CwD2cXp16I7ZxYP d0wqYX7SRVPsw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3FWidczp1FsM; Sat, 19 Aug 2023 11:53:00 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id C3BEF83A66; Sat, 19 Aug 2023 11:52:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C3BEF83A66 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id E6A641BF2BF for ; Sat, 19 Aug 2023 11:52:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C842660D67 for ; Sat, 19 Aug 2023 11:52:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org C842660D67 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IovHjDc5PMZj for ; Sat, 19 Aug 2023 11:52:55 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp3.osuosl.org (Postfix) with ESMTPS id CE1DD60C08 for ; Sat, 19 Aug 2023 11:52:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org CE1DD60C08 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0D1FE623A9; Sat, 19 Aug 2023 11:52:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E32BAC433C8; Sat, 19 Aug 2023 11:52:53 +0000 (UTC) Date: Sat, 19 Aug 2023 14:52:49 +0300 From: Leon Romanovsky To: Karol Kolacinski Message-ID: <20230819115249.GP22185@unreal> References: <20230817141746.18726-1-karol.kolacinski@intel.com> <20230817141746.18726-2-karol.kolacinski@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230817141746.18726-2-karol.kolacinski@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692445974; bh=p80tG6Msagq3qG3K3mTzridTHLNJ86Q45EqvFAMqETk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cjls2mjf/Zsmdq35f259rjkIdz4rLF5YbLThk3yRpsmYugPw8aiKe36V1BKuynfdI OzI4NHHhpQHsEinL6Jz4ZJl3Tt77YAOML/UResLEunzWNaXEwG1+gJi0wHV9lXTsQe 5ppUbtOIjjht92+Mtxdc/hA1hahqhPt9NNcvZnXSfdrkKT/+CJKt0v5RsLUuXljjlS zoy/qAX6Twl20meTg9KYuYVm1OgJffR+pvkvDDZGB+FwXiALVAhnySrN85FIdYvq0q PwGE0CF+jM1BoASa1YAE4nn4AVTsJklLcpzn6VHbNRzbWRrWU2Qrd9KyV+FvaV5TxR 0U4GsZWElnnow== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Cjls2mjf Subject: Re: [Intel-wired-lan] [PATCH v2 iwl-next 1/9] ice: use ice_pf_src_tmr_owned where available X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" T24gVGh1LCBBdWcgMTcsIDIwMjMgYXQgMDQ6MTc6MzhQTSArMDIwMCwgS2Fyb2wgS29sYWNpbnNr aSB3cm90ZToKPiBUaGUgaWNlX3BmX3NyY190bXJfb3duZWQoKSBtYWNybyBleGlzdHMgdG8gY2hl Y2sgdGhlIGZ1bmN0aW9uIGNhcGFiaWxpdHkKPiBiaXQgaW5kaWNhdGluZyBpZiB0aGUgY3VycmVu dCBmdW5jdGlvbiBvd25zIHRoZSBQVFAgaGFyZHdhcmUgY2xvY2suCgpUaGlzIGlzIGZpcnN0IHBh dGNoIGluIHRoZSBzZXJpZXMsIGJ1dCBJIGNhbid0IGZpbmQgbWVudGlvbmVkIG1hY3JvLgpNeSBu ZXQtbmV4dCBpcyBiYXNlZCBvbiA1YjBhMTQxNGUwYjAgKCJNZXJnZSBicmFuY2ggJ3NtYy1mZWF0 dXJlcyciKQrinpwgIGtlcm5lbCBnaXQ6KG5ldC1uZXh0KSBnaXQgZ3JlcCBpY2VfcGZfc3JjX3Rt cl9vd25lZApzaG93cyBub3RoaW5nLgoKT24gd2hpY2ggYnJhbmNoIGlzIGl0IGJhc2VkPwoKVGhh bmtzCgoKPiAKPiBUaGlzIGlzIHNsaWdodGx5IHNob3J0ZXIgdGhhbiB0aGUgbW9yZSB2ZXJib3Nl IGFjY2VzcyB2aWEKPiBody5mdW5jX2NhcHMudHNfZnVuY19pbmZvLnNyY190bXJfb3duZWQuIEJl IGNvbnNpc3RlbnQgYW5kIHVzZSB0aGlzCj4gd2hlcmUgcG9zc2libGUgcmF0aGVyIHRoYW4gb3Bl biBjb2RpbmcgaXRzIGVxdWl2YWxlbnQuCj4gCj4gU2lnbmVkLW9mZi1ieTogSmFjb2IgS2VsbGVy IDxqYWNvYi5lLmtlbGxlckBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogS2Fyb2wgS29sYWNp bnNraSA8a2Fyb2wua29sYWNpbnNraUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvbmV0L2V0 aGVybmV0L2ludGVsL2ljZS9pY2VfbWFpbi5jIHwgMiArLQo+ICBkcml2ZXJzL25ldC9ldGhlcm5l dC9pbnRlbC9pY2UvaWNlX3B0cC5jICB8IDIgKy0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L2V0 aGVybmV0L2ludGVsL2ljZS9pY2VfbWFpbi5jIGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvaW50ZWwv aWNlL2ljZV9tYWluLmMKPiBpbmRleCBhNmRkMzM2ZDI1MDAuLmI2ODU4ZjA0MTUyYyAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9pbnRlbC9pY2UvaWNlX21haW4uYwo+ICsrKyBi L2RyaXZlcnMvbmV0L2V0aGVybmV0L2ludGVsL2ljZS9pY2VfbWFpbi5jCj4gQEAgLTMxODUsNyAr MzE4NSw3IEBAIHN0YXRpYyBpcnFyZXR1cm5fdCBpY2VfbWlzY19pbnRyKGludCBfX2Fsd2F5c191 bnVzZWQgaXJxLCB2b2lkICpkYXRhKQo+ICAKPiAgCQllbmFfbWFzayAmPSB+UEZJTlRfT0lDUl9U U1lOX0VWTlRfTTsKPiAgCj4gLQkJaWYgKGh3LT5mdW5jX2NhcHMudHNfZnVuY19pbmZvLnNyY190 bXJfb3duZWQpIHsKPiArCQlpZiAoaWNlX3BmX3NyY190bXJfb3duZWQocGYpKSB7Cj4gIAkJCS8q IFNhdmUgRVZFTlRzIGZyb20gR0xUU1lOIHJlZ2lzdGVyICovCj4gIAkJCXBmLT5wdHAuZXh0X3Rz X2lycSB8PSBnbHRzeW5fc3RhdCAmCj4gIAkJCQkJICAgICAgKEdMVFNZTl9TVEFUX0VWRU5UMF9N IHwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvaW50ZWwvaWNlL2ljZV9wdHAu YyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L2ludGVsL2ljZS9pY2VfcHRwLmMKPiBpbmRleCA5N2I4 NTgxYWU5MzEuLjA2NjljYTkwNWM0NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL25ldC9ldGhlcm5l dC9pbnRlbC9pY2UvaWNlX3B0cC5jCj4gKysrIGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvaW50ZWwv aWNlL2ljZV9wdHAuYwo+IEBAIC0yNDQ3LDcgKzI0NDcsNyBAQCB2b2lkIGljZV9wdHBfcmVzZXQo c3RydWN0IGljZV9wZiAqcGYpCj4gIAlpZiAodGVzdF9iaXQoSUNFX1BGUl9SRVEsIHBmLT5zdGF0 ZSkpCj4gIAkJZ290byBwZnI7Cj4gIAo+IC0JaWYgKCFody0+ZnVuY19jYXBzLnRzX2Z1bmNfaW5m by5zcmNfdG1yX293bmVkKQo+ICsJaWYgKCFpY2VfcGZfc3JjX3Rtcl9vd25lZChwZikpCj4gIAkJ Z290byByZXNldF90czsKPiAgCj4gIAllcnIgPSBpY2VfcHRwX2luaXRfcGhjKGh3KTsKPiAtLSAK PiAyLjM5LjIKPiAKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtd2lyZWQtbGFuIG1haWxpbmcgbGlzdApJbnRlbC13aXJlZC1sYW5Ab3N1b3Ns Lm9yZwpodHRwczovL2xpc3RzLm9zdW9zbC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC13aXJl ZC1sYW4K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DDA9136B for ; Sat, 19 Aug 2023 11:52:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E32BAC433C8; Sat, 19 Aug 2023 11:52:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692445974; bh=p80tG6Msagq3qG3K3mTzridTHLNJ86Q45EqvFAMqETk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cjls2mjf/Zsmdq35f259rjkIdz4rLF5YbLThk3yRpsmYugPw8aiKe36V1BKuynfdI OzI4NHHhpQHsEinL6Jz4ZJl3Tt77YAOML/UResLEunzWNaXEwG1+gJi0wHV9lXTsQe 5ppUbtOIjjht92+Mtxdc/hA1hahqhPt9NNcvZnXSfdrkKT/+CJKt0v5RsLUuXljjlS zoy/qAX6Twl20meTg9KYuYVm1OgJffR+pvkvDDZGB+FwXiALVAhnySrN85FIdYvq0q PwGE0CF+jM1BoASa1YAE4nn4AVTsJklLcpzn6VHbNRzbWRrWU2Qrd9KyV+FvaV5TxR 0U4GsZWElnnow== Date: Sat, 19 Aug 2023 14:52:49 +0300 From: Leon Romanovsky To: Karol Kolacinski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, jesse.brandeburg@intel.com, Jacob Keller Subject: Re: [PATCH v2 iwl-next 1/9] ice: use ice_pf_src_tmr_owned where available Message-ID: <20230819115249.GP22185@unreal> References: <20230817141746.18726-1-karol.kolacinski@intel.com> <20230817141746.18726-2-karol.kolacinski@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230817141746.18726-2-karol.kolacinski@intel.com> On Thu, Aug 17, 2023 at 04:17:38PM +0200, Karol Kolacinski wrote: > The ice_pf_src_tmr_owned() macro exists to check the function capability > bit indicating if the current function owns the PTP hardware clock. This is first patch in the series, but I can't find mentioned macro. My net-next is based on 5b0a1414e0b0 ("Merge branch 'smc-features'") ➜ kernel git:(net-next) git grep ice_pf_src_tmr_owned shows nothing. On which branch is it based? Thanks > > This is slightly shorter than the more verbose access via > hw.func_caps.ts_func_info.src_tmr_owned. Be consistent and use this > where possible rather than open coding its equivalent. > > Signed-off-by: Jacob Keller > Signed-off-by: Karol Kolacinski > --- > drivers/net/ethernet/intel/ice/ice_main.c | 2 +- > drivers/net/ethernet/intel/ice/ice_ptp.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c > index a6dd336d2500..b6858f04152c 100644 > --- a/drivers/net/ethernet/intel/ice/ice_main.c > +++ b/drivers/net/ethernet/intel/ice/ice_main.c > @@ -3185,7 +3185,7 @@ static irqreturn_t ice_misc_intr(int __always_unused irq, void *data) > > ena_mask &= ~PFINT_OICR_TSYN_EVNT_M; > > - if (hw->func_caps.ts_func_info.src_tmr_owned) { > + if (ice_pf_src_tmr_owned(pf)) { > /* Save EVENTs from GLTSYN register */ > pf->ptp.ext_ts_irq |= gltsyn_stat & > (GLTSYN_STAT_EVENT0_M | > diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c b/drivers/net/ethernet/intel/ice/ice_ptp.c > index 97b8581ae931..0669ca905c46 100644 > --- a/drivers/net/ethernet/intel/ice/ice_ptp.c > +++ b/drivers/net/ethernet/intel/ice/ice_ptp.c > @@ -2447,7 +2447,7 @@ void ice_ptp_reset(struct ice_pf *pf) > if (test_bit(ICE_PFR_REQ, pf->state)) > goto pfr; > > - if (!hw->func_caps.ts_func_info.src_tmr_owned) > + if (!ice_pf_src_tmr_owned(pf)) > goto reset_ts; > > err = ice_ptp_init_phc(hw); > -- > 2.39.2 > >