From: Yury Norov <yury.norov@gmail.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Yury Norov <yury.norov@gmail.com>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ben Segall <bsegall@google.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Jakub Kicinski <kuba@kernel.org>,
Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>,
Steven Rostedt <rostedt@goodmis.org>,
Tariq Toukan <tariqt@nvidia.com>,
Valentin Schneider <vschneid@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
shiju.jose@huawei.com, jonathan.cameron@huawei.com,
prime.zeng@huawei.com, linuxarm@huawei.com,
yangyicong@hisilicon.com,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: [PATCH v2 2/6] sched/fair: fix opencoded numa_nearest_node()
Date: Sat, 19 Aug 2023 07:12:34 -0700 [thread overview]
Message-ID: <20230819141239.287290-3-yury.norov@gmail.com> (raw)
In-Reply-To: <20230819141239.287290-1-yury.norov@gmail.com>
task_numa_placement() searches for a nearest node to migrate by calling
for_each_node_state(). Now that we have numa_nearest_node(), switch to
using it.
Signed-off-by: Yury Norov <yury.norov@gmail.com>
---
kernel/sched/fair.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index b3e25be58e2b..e7b7cf87937b 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2645,19 +2645,7 @@ static void task_numa_placement(struct task_struct *p)
}
/* Cannot migrate task to CPU-less node */
- if (max_nid != NUMA_NO_NODE && !node_state(max_nid, N_CPU)) {
- int near_nid = max_nid;
- int distance, near_distance = INT_MAX;
-
- for_each_node_state(nid, N_CPU) {
- distance = node_distance(max_nid, nid);
- if (distance < near_distance) {
- near_nid = nid;
- near_distance = distance;
- }
- }
- max_nid = near_nid;
- }
+ max_nid = numa_nearest_node(max_nid, N_CPU);
if (ng) {
numa_group_count_active_nodes(ng);
--
2.39.2
next prev parent reply other threads:[~2023-08-19 14:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 14:12 [PATCH v2 0/6] sched fixes Yury Norov
2023-08-19 14:12 ` [PATCH v2 1/6] numa: generalize numa_map_to_online_node() Yury Norov
2023-09-15 12:03 ` [tip: sched/core] numa: Generalize numa_map_to_online_node() tip-bot2 for Yury Norov
2023-08-19 14:12 ` Yury Norov [this message]
2023-09-15 12:03 ` [tip: sched/core] sched/fair: Fix open-coded numa_nearest_node() tip-bot2 for Yury Norov
2023-08-19 14:12 ` [PATCH v2 3/6] sched: fix sched_numa_find_nth_cpu() in CPU-less case Yury Norov
2023-09-15 12:03 ` [tip: sched/core] sched/topology: Fix " tip-bot2 for Yury Norov
2023-08-19 14:12 ` [PATCH v2 4/6] sched: fix sched_numa_find_nth_cpu() in non-NUMA case Yury Norov
2023-09-15 12:03 ` [tip: sched/core] sched/topology: Fix " tip-bot2 for Yury Norov
2023-08-19 14:12 ` [PATCH v2 5/6] sched: handle NUMA_NO_NODE in sched_numa_find_nth_cpu() Yury Norov
2023-09-15 12:03 ` [tip: sched/core] sched/topology: Handle " tip-bot2 for Yury Norov
2023-08-19 14:12 ` [PATCH v2 6/6] sched: fix sched_numa_find_nth_cpu() comment Yury Norov
2023-09-15 12:03 ` [tip: sched/core] sched/topology: Fix " tip-bot2 for Yury Norov
2023-08-25 11:31 ` [PATCH v2 0/6] sched fixes Yury Norov
2023-09-13 0:01 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230819141239.287290-3-yury.norov@gmail.com \
--to=yury.norov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jacob.e.keller@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=juri.lelli@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linuxarm@huawei.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=prime.zeng@huawei.com \
--cc=rostedt@goodmis.org \
--cc=shiju.jose@huawei.com \
--cc=tariqt@nvidia.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.