From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADE93EE4993 for ; Sat, 19 Aug 2023 10:06:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6050E60BA4; Sat, 19 Aug 2023 10:06:18 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6050E60BA4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1692439578; bh=NnkRz6U8ztZr5ggYDGX9lRdXV0lU0TXyTQGE7+OnwhM=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Fu1ymZg+E2/S4awovONnOVEzDkvSsFr24ieGzhjN3GxL1rJkyenM0qXsfvvmdDfFy FqmCKxmY2skCAICb8vH2aim2LusdRHHgTD5spgsOKjki5UZN5nnk4Qto5+lhHMNz39 UNwrRx+PqVO2PMFsDm1aNFHYDVbX0iMAfqIbdXjtkd3fKlNcKHW33YeCHnkKdvHoSi jzMYKK+4vCJbYi8+7mPCni93xD177iURElBUlqnSghgxekiMSF3LUGqSmWKH8I1tno qu0dcS7wUHfS7l7bas2rDGxEVraZ2Fpn9PFN0o/1hFhj/YDvufHoyW81bhT/KwJXe+ 9i7lh5TmjuO6g== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TxH-60gRQnfH; Sat, 19 Aug 2023 10:06:17 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 4F0B460BB6; Sat, 19 Aug 2023 10:06:17 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4F0B460BB6 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 39CD91BF2CD for ; Sat, 19 Aug 2023 10:06:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 141D640616 for ; Sat, 19 Aug 2023 10:06:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 141D640616 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4c9Scew06cGi for ; Sat, 19 Aug 2023 10:06:14 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp2.osuosl.org (Postfix) with ESMTPS id 4D3BC4074E for ; Sat, 19 Aug 2023 10:06:14 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 4D3BC4074E Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0995161B16; Sat, 19 Aug 2023 10:06:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D862CC433C7; Sat, 19 Aug 2023 10:06:11 +0000 (UTC) Date: Sat, 19 Aug 2023 12:06:09 +0200 From: Greg KH To: Miguel Ojeda Message-ID: <2023081940-linguist-pantomime-ebc2@gregkh> References: <20230816140623.452869-2-przemyslaw.kitszel@intel.com> <202308170000.YqabIR9D-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1692439572; bh=eZmjagX06AR0K5BLwB36iJyx8ATCTPYSXUB2lSow2tU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oozmb8NYVD4jQQRjJEOWIn7yMeKn7xI4+shKJJU9Gu78uzOjqJtClLybhs3IasuDm kLGvPYP+JmwlimLUtAni2m+A88effmA5MAIQYpNrDt8CAbIbyxRY54bhm8rFp466jp R9Fdyhztw4Xcq2xFfybSOE2jDSM99pAh4OjDPwLk= X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=oozmb8NY Subject: Re: [Intel-wired-lan] [PATCH net-next v3 1/7] overflow: add DEFINE_FLEX() for on-stack allocs X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yujie Liu , rust-for-linux@vger.kernel.org, Przemek Kitszel , llvm@lists.linux.dev, Philip Li , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-hardening@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Kees Cook Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" T24gRnJpLCBBdWcgMTgsIDIwMjMgYXQgMDE6MTA6MDdQTSArMDIwMCwgTWlndWVsIE9qZWRhIHdy b3RlOgo+IE9uIEZyaSwgQXVnIDE4LCAyMDIzIGF0IDEyOjM44oCvUE0gUHJ6ZW1layBLaXRzemVs Cj4gPHByemVteXNsYXcua2l0c3plbEBpbnRlbC5jb20+IHdyb3RlOgo+ID4KPiA+IFJ1c3QgZm9s a3MsIGNvdWxkIHlvdSBwbGVhc2UgdGVsbCBtZSBpZiB0aGlzIGlzIHNvbWV0aGluZyBJIHNob3Vs ZCBmaXgsCj4gPiBvciBJIGp1c3QgdW5jb3ZlcmVkIHNvbWUgZXhpc3RpbmcgYnVnIGluICJ1bnN0 YWJsZSIgdGhpbmc/Cj4gPgo+ID4gUGVyaGFwcyBpdCBpcyB3b3J0aCB0byBtZW50aW9uLCBkaWZm IG9mIHYzIHZzIHYyIGlzOgo+ID4gbW92ZSBkdW1teSBpbXBsZW1lbnRhdGlvbiBvZiBfX2hhc19i dWlsdGluKCkgbWFjcm8gdG8gdGhlIHRvcCBvZgo+ID4gY29tcGlsZXJfdHlwZXMuaCwganVzdCBi ZWZvcmUgYCNpZm5kZWYgQVNTRU1CTFlgCj4gCj4gTm90aGluZyB5b3UgbmVlZCB0byB3b3JyeSBh Ym91dCwgaXQgaXMgYW4gaXNzdWUgd2l0aCBvbGQgYGJpbmRnZW5gIGFuZAo+IExMVk0gPj0gMTYs IGZpeGVkIGluIGNvbW1pdCAwOGFiNzg2NTU2ZmYgKCJydXN0OiBiaW5kZ2VuOiB1cGdyYWRlIHRv Cj4gMC42NS4xIikgd2hpY2ggaXMgaW4gYHJ1c3QtbmV4dGAgYXQgdGhlIG1vbWVudC4gU29ycnkg YWJvdXQgdGhhdCwgYW5kCj4gdGhhbmtzIGZvciBwaW5naW5nIHVzIQo+IAo+IExLUCAvIFl1amll IC8gUGhpbGlwOiBzaW5jZSB3ZSBnb3QgYSBmZXcgcmVwb3J0cyBvbiB0aGlzLCB3b3VsZCBpdCBi ZQo+IHBvc3NpYmxlIHRvIGF2b2lkIExMVk0gPj0gMTYgZm9yIFJ1c3QtZW5hYmxlZCBidWlsZHMg Zm9yIGFueSBicmFuY2gKPiB0aGF0IGRvZXMgbm90IGluY2x1ZGUgdGhlIG5ldyBgYmluZGdlbmAg b3IgYXQgbGVhc3QgMDhhYjc4NjU1NmZmPyBPciwKPiBpZiBHcmVnIGlzIE9LIHdpdGggdGhhdCwg SSBndWVzcyB3ZSBjb3VsZCBhbHNvIGJhY2twb3J0IHRoZSB1cGdyYWRlLAo+IGJ1dCBwZXJoYXBz IGl0IGlzIGEgYml0IHRvbyBtdWNoIGZvciBzdGFibGU/CgpDb21taXQgaXMgdGlueSBlbm91Z2gg Zm9yIHN0YWJsZSBiYWNrcG9ydHMgaWYgaXQgZml4ZXMgYSByZWFsIGlzc3VlIHRoYXQKZXZlcnlv bmUgbmVlZHMgdG8gYWRkcmVzcywgc28gSSBoYXZlIG5vIG9iamVjdGlvbiB0byB0YWtpbmcgaXQg Zm9yCnN0YWJsZSByZWxlYXNlcyBvbmNlIGl0IGhpdHMgTGludXMncyB0cmVlLgoKdGhhbmtzLAoK Z3JlZyBrLWgKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtd2lyZWQtbGFuIG1haWxpbmcgbGlzdApJbnRlbC13aXJlZC1sYW5Ab3N1b3NsLm9yZwpo dHRwczovL2xpc3RzLm9zdW9zbC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC13aXJlZC1sYW4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CC98EE49A5 for ; Sat, 19 Aug 2023 10:42:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231307AbjHSKmB (ORCPT ); Sat, 19 Aug 2023 06:42:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231315AbjHSKlo (ORCPT ); Sat, 19 Aug 2023 06:41:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6818C3B338 for ; Sat, 19 Aug 2023 03:06:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 06FE6602E5 for ; Sat, 19 Aug 2023 10:06:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D862CC433C7; Sat, 19 Aug 2023 10:06:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1692439572; bh=eZmjagX06AR0K5BLwB36iJyx8ATCTPYSXUB2lSow2tU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oozmb8NYVD4jQQRjJEOWIn7yMeKn7xI4+shKJJU9Gu78uzOjqJtClLybhs3IasuDm kLGvPYP+JmwlimLUtAni2m+A88effmA5MAIQYpNrDt8CAbIbyxRY54bhm8rFp466jp R9Fdyhztw4Xcq2xFfybSOE2jDSM99pAh4OjDPwLk= Date: Sat, 19 Aug 2023 12:06:09 +0200 From: Greg KH To: Miguel Ojeda Cc: Przemek Kitszel , kernel test robot , Yujie Liu , Philip Li , rust-for-linux@vger.kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Jacob Keller , intel-wired-lan@lists.osuosl.org, Alexander Lobakin , linux-hardening@vger.kernel.org, Kees Cook , netdev@vger.kernel.org Subject: Re: [PATCH net-next v3 1/7] overflow: add DEFINE_FLEX() for on-stack allocs Message-ID: <2023081940-linguist-pantomime-ebc2@gregkh> References: <20230816140623.452869-2-przemyslaw.kitszel@intel.com> <202308170000.YqabIR9D-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Fri, Aug 18, 2023 at 01:10:07PM +0200, Miguel Ojeda wrote: > On Fri, Aug 18, 2023 at 12:38 PM Przemek Kitszel > wrote: > > > > Rust folks, could you please tell me if this is something I should fix, > > or I just uncovered some existing bug in "unstable" thing? > > > > Perhaps it is worth to mention, diff of v3 vs v2 is: > > move dummy implementation of __has_builtin() macro to the top of > > compiler_types.h, just before `#ifndef ASSEMBLY` > > Nothing you need to worry about, it is an issue with old `bindgen` and > LLVM >= 16, fixed in commit 08ab786556ff ("rust: bindgen: upgrade to > 0.65.1") which is in `rust-next` at the moment. Sorry about that, and > thanks for pinging us! > > LKP / Yujie / Philip: since we got a few reports on this, would it be > possible to avoid LLVM >= 16 for Rust-enabled builds for any branch > that does not include the new `bindgen` or at least 08ab786556ff? Or, > if Greg is OK with that, I guess we could also backport the upgrade, > but perhaps it is a bit too much for stable? Commit is tiny enough for stable backports if it fixes a real issue that everyone needs to address, so I have no objection to taking it for stable releases once it hits Linus's tree. thanks, greg k-h