From: Leon Romanovsky <leon@kernel.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
saravanan.vajravel@broadcom.com,
OFED mailing list <linux-rdma@vger.kernel.org>,
Ehab Ababneh <ehab.ababneh@cornelisnetworks.com>,
Selvin Xavier <selvin.xavier@broadcom.com>
Subject: Re: isert patch leaving resources behind
Date: Sun, 20 Aug 2023 20:33:58 +0300 [thread overview]
Message-ID: <20230820173358.GF1562474@unreal> (raw)
In-Reply-To: <4a628865-d555-4b60-3fc7-4675bb40af62@grimberg.me>
On Sun, Aug 20, 2023 at 05:46:12PM +0300, Sagi Grimberg wrote:
>
> > > > Commit: 699826f4e30a ("IB/isert: Fix incorrect release of isert connection") is
> > > > causing problems on OPA when we try to unload the driver after doing iSCI
> > > > testing. Reverting this commit causes the problem to go away. Any ideas?
> > >
> > >
> > > Saravanan, can you please post kernel logs as you wrote "When a bunch of iSER target
> > > is cleared, this issue can lead to use-after-free memory issue as isert conn is twice
> > > released" in the reverted commit?
> >
> > So what is the resolution here?
>
> We need saravanan to address the reported resource leak upon
> DEVICE_REMOVAL. If this stalls, I suggest we revert the offending
> commit and add it again without any leaks on surprise hca removals.
Thanks, I'll keep an eye on it, if we don't get patch by EOW, I will revert it
next prev parent reply other threads:[~2023-08-20 17:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 14:44 isert patch leaving resources behind Dennis Dalessandro
2023-08-13 8:29 ` Leon Romanovsky
2023-08-20 9:46 ` Leon Romanovsky
2023-08-20 14:46 ` Sagi Grimberg
2023-08-20 17:33 ` Leon Romanovsky [this message]
2023-08-21 10:47 ` Saravanan Vajravel
2023-08-21 11:30 ` Dennis Dalessandro
2023-08-13 14:18 ` Sagi Grimberg
2023-08-14 11:20 ` Saravanan Vajravel
2023-08-14 12:36 ` Sagi Grimberg
2023-08-16 11:33 ` Saravanan Vajravel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230820173358.GF1562474@unreal \
--to=leon@kernel.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=ehab.ababneh@cornelisnetworks.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=saravanan.vajravel@broadcom.com \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.