Re: [Buildroot] [PATCH] package/elf2flt: Fix build by updating to v2023.04

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Jesse Taube <mr.bossman075@gmail.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
	Niklas Cassel <niklas.cassel@wdc.com>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	Giulio Benetti <giulio.benetti@micronovasrl.com>,
	Greg Ungerer <gerg@kernel.org>,
	buildroot@buildroot.org, Romain Naour <romain.naour@smile.fr>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH] package/elf2flt: Fix build by updating to v2023.04
Date: Sun, 20 Aug 2023 23:49:26 +0200	[thread overview]
Message-ID: <20230820234926.1dc52113@windsurf> (raw)
In-Reply-To: <20230819030849.3966233-1-Mr.Bossman075@gmail.com>

Hello Jesse,

On Fri, 18 Aug 2023 23:08:49 -0400
Jesse Taube <mr.bossman075@gmail.com> wrote:

> In elf2flt Greg Ungerer committed "elf2flt: remove use of BFD_VMA_FMT":
> 
> "In binutils-2.40 the BFD_VMA_FMT definition used for printf style
> formatting specifiers has been removed. For reference this was done in
> commit b82817674f46 ("Don't use BFD_VMA_FMT in binutils") in the
> binutils git development tree.
> 
> BFD_VMA_FMT is used in a number of places in the elf2flt code to output
> bfd offsets, values and the like. So it is broken when using the bfd
> code from binutils-2.40 and newer.
> 
> According to the binutils change PRIx64 (and friends) is used to replace
> it, with appropriate casts to keep it clean for 32 and 64 bit platforms.
> Change the elf2flt.c use of it in the same way to fix."
> 
> This patch updates elf2flt to version v2023.04, and rebases all the
> Buildroot patches.
> 
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>

Could you clarify which build failure this is fixing? The commit title
says "fix build" but you don't explain which build failure is being
fixed.

If it's the BFD_VMA_FMT issue, it has already been fixed by commit
https://gitlab.com/buildroot.org/buildroot/-/commit/d79f9c9f416ac5da90cd428916cff0b5288cb03a
in which we have backported the upstream commit you're referring to.

That being said, bumping the version of elf2flt is certainly a good
idea moving forward. However, we should be careful when doing this, as
updating elf2flt has several times in the past proven to come with a
number of regressions.

Romain: do you have some suggestions of defconfigs/configurations to
test/check after doing an elf2flt bump?

Also, Jesse: your bump is not only rebasing all Buildroot patches, some
are dropped. It would be good to mention which patches are dropped (and
what is the corresponding upstream commit), and which patches are
rebased.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot