From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CE92EE4993 for ; Mon, 21 Aug 2023 07:20:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id A64B140153; Mon, 21 Aug 2023 07:20:47 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A64B140153 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1692602447; bh=vvG1Db1WjgsMHgLqTI0wU3KdX0WOwpGChk4r2W68DSE=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=rDfsKqEL62LN5QQVaHXdxZZPn60z0LaNxI+W8HcCFKR4jWxX/RjticVKJCpEtCI+7 YaELF9M2tbFhk8QoFhUcYmMaECsEfLV13NYgt6yUCz/DGCN4big6Vr02/PSVN00zFm fgr6tbQdAB2doX5esmrAfuzglFFD/ndN8qrCqsAhFfOl1Tfx7VExS9+uMYCFYHsrR4 LowihxBn0n+pmoLQY17Ks6/v6b3mwd/GyKiywKva5waVBB7ylIjyqcgsCOXVodI9wR smXl+ZyxOh5YEvulc6pnaG/jwYttpG6eAJ3VIKcdnjouNR918ZMrhmmMXUXTEryx+U fwDHUA9Wait0A== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5F-0PNN2sLo9; Mon, 21 Aug 2023 07:20:46 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id A5E5D40286; Mon, 21 Aug 2023 07:20:46 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A5E5D40286 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 5B3E91BF304 for ; Mon, 21 Aug 2023 07:20:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 40D8E40153 for ; Mon, 21 Aug 2023 07:20:44 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 40D8E40153 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lgn5ddAQFYQL for ; Mon, 21 Aug 2023 07:20:43 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp2.osuosl.org (Postfix) with ESMTPS id 887B440286 for ; Mon, 21 Aug 2023 07:20:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 887B440286 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 50E2F62B95; Mon, 21 Aug 2023 07:20:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73666C433C7; Mon, 21 Aug 2023 07:20:40 +0000 (UTC) Date: Mon, 21 Aug 2023 09:20:37 +0200 From: Simon Horman To: Junfeng Guo Message-ID: <20230821072037.GB2711035@kernel.org> References: <20230605054641.2865142-1-junfeng.guo@intel.com> <20230821023833.2700902-1-junfeng.guo@intel.com> <20230821023833.2700902-2-junfeng.guo@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230821023833.2700902-2-junfeng.guo@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692602442; bh=Wf7zeV5h6wLdApJpJ4O+kQ4I3kLTkxtXiC7kTd1YWy0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JHG5Wf+shaXsMHdsBTdt0432RJht3Y+ElPvWoU3QyygNE89zgUuH99h9kVKmGNl+o wgNkkGMXHpreRf7NkDRNdeDOrTAmLkCWgHVfPFB9BEHOYVaO/PSHlGBrZJlMupA4GA ORovSKrcWchg7saW8UEGInTVWPl/dLesJdF7qiJBIM64zFlbIftnM4AtI+AHp2blLw HlslJTlxG5X/ZD1YqJE6uhJhRU8luLN4UqE4F5WAG0ie97BQxptKR83bM8B1UGq/uT ppzXn5GVPTAx3MuJ9K9ORhB5YS2ngwC/5IzqHb5SfPvlqbUorCWjZSbZ5ULy+cHu0I mv6rdGr+jCYog== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=JHG5Wf+s Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 01/15] ice: add parser create and destroy skeleton X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ivecera@redhat.com, netdev@vger.kernel.org, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, qi.z.zhang@intel.com, intel-wired-lan@lists.osuosl.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Aug 21, 2023 at 10:38:19AM +0800, Junfeng Guo wrote: > Add new parser module which can parse a packet in binary > and generate information like ptype, protocol/offset pairs > and flags which can be used to feed the FXP profile creation > directly. > > The patch added skeleton of the create and destroy APIs: > ice_parser_create > ice_parser_destroy > > Signed-off-by: Junfeng Guo Hi Junfeng Guo, some minor feedback from my side. > --- > drivers/net/ethernet/intel/ice/ice_common.h | 4 +++ > drivers/net/ethernet/intel/ice/ice_ddp.c | 10 +++--- > drivers/net/ethernet/intel/ice/ice_ddp.h | 13 ++++++++ > drivers/net/ethernet/intel/ice/ice_parser.c | 34 +++++++++++++++++++++ Perhaps I am missing something, but it seems that although ice_parser.c is added by this patch-set, it is not added to the build by this patch-set. This seems a little odd to me. > drivers/net/ethernet/intel/ice/ice_parser.h | 13 ++++++++ > 5 files changed, 69 insertions(+), 5 deletions(-) > create mode 100644 drivers/net/ethernet/intel/ice/ice_parser.c > create mode 100644 drivers/net/ethernet/intel/ice/ice_parser.h ... > diff --git a/drivers/net/ethernet/intel/ice/ice_parser.c b/drivers/net/ethernet/intel/ice/ice_parser.c > new file mode 100644 > index 000000000000..42602cac7e45 > --- /dev/null > +++ b/drivers/net/ethernet/intel/ice/ice_parser.c > @@ -0,0 +1,34 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* Copyright (C) 2023 Intel Corporation */ > + > +#include "ice_common.h" > + > +/** > + * ice_parser_create - create a parser instance > + * @hw: pointer to the hardware structure > + * @psr: output parameter for a new parser instance be created > + */ > +int ice_parser_create(struct ice_hw *hw, struct ice_parser **psr) > +{ > + struct ice_parser *p; > + > + p = devm_kzalloc(ice_hw_to_dev(hw), sizeof(struct ice_parser), > + GFP_KERNEL); > + if (!p) > + return -ENOMEM; > + > + p->hw = hw; > + p->rt.psr = p; It is, perhaps academic if this file isn't compiled, but the rt field of struct ice_parser doesn't exist at this point of the patch-set: it is added by the last patch of the patch-set. > + > + *psr = p; > + return 0; > +} > + > +/** > + * ice_parser_destroy - destroy a parser instance > + * @psr: pointer to a parser instance > + */ > +void ice_parser_destroy(struct ice_parser *psr) > +{ > + devm_kfree(ice_hw_to_dev(psr->hw), psr); > +} _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82E2F1848 for ; Mon, 21 Aug 2023 07:20:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73666C433C7; Mon, 21 Aug 2023 07:20:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692602442; bh=Wf7zeV5h6wLdApJpJ4O+kQ4I3kLTkxtXiC7kTd1YWy0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JHG5Wf+shaXsMHdsBTdt0432RJht3Y+ElPvWoU3QyygNE89zgUuH99h9kVKmGNl+o wgNkkGMXHpreRf7NkDRNdeDOrTAmLkCWgHVfPFB9BEHOYVaO/PSHlGBrZJlMupA4GA ORovSKrcWchg7saW8UEGInTVWPl/dLesJdF7qiJBIM64zFlbIftnM4AtI+AHp2blLw HlslJTlxG5X/ZD1YqJE6uhJhRU8luLN4UqE4F5WAG0ie97BQxptKR83bM8B1UGq/uT ppzXn5GVPTAx3MuJ9K9ORhB5YS2ngwC/5IzqHb5SfPvlqbUorCWjZSbZ5ULy+cHu0I mv6rdGr+jCYog== Date: Mon, 21 Aug 2023 09:20:37 +0200 From: Simon Horman To: Junfeng Guo Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, jesse.brandeburg@intel.com, qi.z.zhang@intel.com, ivecera@redhat.com, sridhar.samudrala@intel.com Subject: Re: [PATCH iwl-next v5 01/15] ice: add parser create and destroy skeleton Message-ID: <20230821072037.GB2711035@kernel.org> References: <20230605054641.2865142-1-junfeng.guo@intel.com> <20230821023833.2700902-1-junfeng.guo@intel.com> <20230821023833.2700902-2-junfeng.guo@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230821023833.2700902-2-junfeng.guo@intel.com> On Mon, Aug 21, 2023 at 10:38:19AM +0800, Junfeng Guo wrote: > Add new parser module which can parse a packet in binary > and generate information like ptype, protocol/offset pairs > and flags which can be used to feed the FXP profile creation > directly. > > The patch added skeleton of the create and destroy APIs: > ice_parser_create > ice_parser_destroy > > Signed-off-by: Junfeng Guo Hi Junfeng Guo, some minor feedback from my side. > --- > drivers/net/ethernet/intel/ice/ice_common.h | 4 +++ > drivers/net/ethernet/intel/ice/ice_ddp.c | 10 +++--- > drivers/net/ethernet/intel/ice/ice_ddp.h | 13 ++++++++ > drivers/net/ethernet/intel/ice/ice_parser.c | 34 +++++++++++++++++++++ Perhaps I am missing something, but it seems that although ice_parser.c is added by this patch-set, it is not added to the build by this patch-set. This seems a little odd to me. > drivers/net/ethernet/intel/ice/ice_parser.h | 13 ++++++++ > 5 files changed, 69 insertions(+), 5 deletions(-) > create mode 100644 drivers/net/ethernet/intel/ice/ice_parser.c > create mode 100644 drivers/net/ethernet/intel/ice/ice_parser.h ... > diff --git a/drivers/net/ethernet/intel/ice/ice_parser.c b/drivers/net/ethernet/intel/ice/ice_parser.c > new file mode 100644 > index 000000000000..42602cac7e45 > --- /dev/null > +++ b/drivers/net/ethernet/intel/ice/ice_parser.c > @@ -0,0 +1,34 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* Copyright (C) 2023 Intel Corporation */ > + > +#include "ice_common.h" > + > +/** > + * ice_parser_create - create a parser instance > + * @hw: pointer to the hardware structure > + * @psr: output parameter for a new parser instance be created > + */ > +int ice_parser_create(struct ice_hw *hw, struct ice_parser **psr) > +{ > + struct ice_parser *p; > + > + p = devm_kzalloc(ice_hw_to_dev(hw), sizeof(struct ice_parser), > + GFP_KERNEL); > + if (!p) > + return -ENOMEM; > + > + p->hw = hw; > + p->rt.psr = p; It is, perhaps academic if this file isn't compiled, but the rt field of struct ice_parser doesn't exist at this point of the patch-set: it is added by the last patch of the patch-set. > + > + *psr = p; > + return 0; > +} > + > +/** > + * ice_parser_destroy - destroy a parser instance > + * @psr: pointer to a parser instance > + */ > +void ice_parser_destroy(struct ice_parser *psr) > +{ > + devm_kfree(ice_hw_to_dev(psr->hw), psr); > +}