From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C3D3EE49AA for ; Mon, 21 Aug 2023 16:46:01 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 44BCB83A; Mon, 21 Aug 2023 18:45:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 44BCB83A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1692636359; bh=LlrlqT5YFbaVq7QjCCWPiC/vKgnJUso9K3vZdLYpSrQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=uzIHtvmhAQs4NTveuC/gZmANPuZdNgEiIhlq9Gi/AKP3hKA3SmfTF6e6k0jTkc1+8 QYVEUvhqvToYP0Ng3Ia4aLBsSwUJjh1BjmcgxW97lD5fWvt5XhPOSsmSVxNG8UVRJm kAko6IJ6a1A5mLgxTAF13u9GNRNFt9gJLxJrppgE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id E31D1F80272; Mon, 21 Aug 2023 18:44:38 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 70915F80199; Mon, 21 Aug 2023 18:44:38 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C33D4F80199; Mon, 21 Aug 2023 18:44:33 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 90DCBF800BF for ; Mon, 21 Aug 2023 18:44:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 90DCBF800BF Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ybRr39jV Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF79963EDE; Mon, 21 Aug 2023 16:44:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FF49C433C7; Mon, 21 Aug 2023 16:44:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1692636263; bh=LlrlqT5YFbaVq7QjCCWPiC/vKgnJUso9K3vZdLYpSrQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ybRr39jV8vAJlQlMVP1ogmL+zehfOZcFpu9ASwI247gPAz+lGOtvrJ9yiJ2HT6GB8 vnplHA6UHU27663KPl6RS44kGk70wTAlT2TLFpm0FUZNYjHSy+UAhLbbnWnu8z3HpK +w2ltuxxj06WyHzx6mxPz7jZHBYkK03FbidtcRIQ= Date: Mon, 21 Aug 2023 18:44:20 +0200 From: Greg KH To: Jaroslav Kysela Cc: ALSA development , stable@vger.kernel.org, Ranjani Sridharan , Pierre-Louis Bossart , Rander Wang , =?iso-8859-1?Q?P=E9ter?= Ujfalusi , Guennadi Liakhovetski , Bard Liao , Mark Brown Subject: Re: [PATCH] [6.4.y] ASoC: SOF: intel: hda: Clean up link DMA for IPC3 during stop Message-ID: <2023082110-stumble-founding-148d@gregkh> References: <20230821122209.20139-1-perex@perex.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230821122209.20139-1-perex@perex.cz> Message-ID-Hash: 33KCNN6CZC7HECXPPSH3IH6DLNDFN54E X-Message-ID-Hash: 33KCNN6CZC7HECXPPSH3IH6DLNDFN54E X-MailFrom: gregkh@linuxfoundation.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Aug 21, 2023 at 02:22:09PM +0200, Jaroslav Kysela wrote: > From: Ranjani Sridharan > > commit 90219f1bd273055f1dc1d7bdc0965755b992c045 upstream. > > With IPC3, we reset hw_params during the stop trigger, so we should also > clean up the link DMA during the stop trigger. > > Cc: # 6.4.x > Fixes: 1bf83fa6654c ("ASoC: SOF: Intel: hda-dai: Do not perform DMA cleanup during stop") > Closes: https://github.com/thesofproject/linux/issues/4455 > Closes: https://github.com/thesofproject/linux/issues/4482 > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217673 > Signed-off-by: Ranjani Sridharan > Reviewed-by: Pierre-Louis Bossart > Reviewed-by: Rander Wang > Reviewed-by: Péter Ujfalusi > Reviewed-by: Guennadi Liakhovetski > Reviewed-by: Bard Liao > Signed-off-by: Peter Ujfalusi > Link: https://lore.kernel.org/r/20230808110627.32375-1-peter.ujfalusi@linux.intel.com > Signed-off-by: Mark Brown > > Note that many recent Intel based laptops are affected. > > Added missing code for 6.4 kernels to keep the fix simple not depending > on the other changes. This commit is present in 6.5 tree already. > > Signed-off-by: Jaroslav Kysela Now queued up, thanks. greg k-h