From: Lee Jones <lee@kernel.org>
To: Ruan Jinjie <ruanjinjie@huawei.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH -next] mfd: mxs-lradc: Use the devm_clk_get_enabled() helper function
Date: Mon, 21 Aug 2023 12:20:17 +0100 [thread overview]
Message-ID: <20230821112017.GF1380343@google.com> (raw)
In-Reply-To: <20230818093309.1053544-1-ruanjinjie@huawei.com>
On Fri, 18 Aug 2023, Ruan Jinjie wrote:
> With devm_clk_get_enabled() the call to clk_disable_unprepare() can be
> dropped from the error path and the remove callback.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
> drivers/mfd/mxs-lradc.c | 35 ++++++++---------------------------
> 1 file changed, 8 insertions(+), 27 deletions(-)
Doesn't apply. Please rebase and resubmit.
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-08-21 11:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 9:33 [PATCH -next] mfd: mxs-lradc: Use the devm_clk_get_enabled() helper function Ruan Jinjie
2023-08-21 11:20 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230821112017.GF1380343@google.com \
--to=lee@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=ruanjinjie@huawei.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.