From: Jakub Kicinski <kuba@kernel.org>
To: "Nelson, Shannon" <shannon.nelson@amd.com>
Cc: Yue Haibing <yuehaibing@huawei.com>,
brett.creeley@amd.com, drivers@pensando.io, davem@davemloft.net,
pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ionic: Remove unused declarations
Date: Mon, 21 Aug 2023 13:05:12 -0700 [thread overview]
Message-ID: <20230821130512.27d0265e@kernel.org> (raw)
In-Reply-To: <b113a610-15b0-460a-a439-3e8461ae3f60@amd.com>
On Mon, 21 Aug 2023 12:42:52 -0700 Nelson, Shannon wrote:
> > Nope, it's harmless, no Fixes needed.
> > Fixes is for backporting, why would we backport this.
>
> Okay.
>
> Unfortunately I experimented with sending the "changes requested"
> message to the pw bot just before receiving your note...
As luck would have it - seems like something in the copious Outlook
headers confuses python's email library:
$ wget https://lore.kernel.org/all/69e9c563-2f07-4e9e-b43a-145839fe2afd@amd.com/raw
$ python
>>> import email
>>> from email.policy import default
>>> with open('raw', 'rb') as fp:
... raw = fp.read()
... msg = email.message_from_bytes(raw, policy=default)
...
>>> msg.get_body(preferencelist=('plain',)).as_string().split('\n')[-1]
''
>>> msg.get_body(preferencelist=('plain',)).as_string().split('\n')[0]
'Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net'
It thinks the headers are the body, so we missed the pw-bot command.
next prev parent reply other threads:[~2023-08-21 20:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 13:47 [PATCH net-next] ionic: Remove unused declarations Yue Haibing
2023-08-21 15:08 ` Brett Creeley
2023-08-21 17:26 ` Nelson, Shannon
2023-08-21 19:39 ` Jakub Kicinski
2023-08-21 19:42 ` Nelson, Shannon
2023-08-21 20:05 ` Jakub Kicinski [this message]
2023-08-21 20:14 ` Nelson, Shannon
2023-08-21 19:40 ` Nelson, Shannon
2023-08-22 18:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230821130512.27d0265e@kernel.org \
--to=kuba@kernel.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.