+ mm-fix-get_mctgt_type-kernel-doc-fix.patch added to mm-unstable branch

+ mm-fix-get_mctgt_type-kernel-doc-fix.patch added to mm-unstable branch

[Andrew Morton]

The patch titled
     Subject: mm-fix-get_mctgt_type-kernel-doc-fix
has been added to the -mm mm-unstable branch.  Its filename is
     mm-fix-get_mctgt_type-kernel-doc-fix.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-fix-get_mctgt_type-kernel-doc-fix.patch

This patch will later appear in the mm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: mm-fix-get_mctgt_type-kernel-doc-fix
Date: Mon Aug 21 11:53:43 AM PDT 2023

changes suggested by Randy

Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Mike Rapoport (IBM) <rppt@kernel.org>
Cc: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/memcontrol.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/mm/memcontrol.c~mm-fix-get_mctgt_type-kernel-doc-fix
+++ a/mm/memcontrol.c
@@ -5855,9 +5855,9 @@ out:
  * * MC_TARGET_NONE - If the pte is not a target for move charge.
  * * MC_TARGET_PAGE - If the page corresponding to this pte is a target for
  *   move charge. If @target is not NULL, the page is stored in target->page
- *   with extra refcnt got (Callers should handle it).
+ *   with extra refcnt taken (Callers should handle it).
  * * MC_TARGET_SWAP - If the swap entry corresponding to this pte is a
- *   target for charge migration. if @target is not NULL, the entry is stored
+ *   target for charge migration.  If @target is not NULL, the entry is stored
  *   in target->ent.
  * * MC_TARGET_DEVICE - Like MC_TARGET_PAGE but page is device memory and
  *   thus not on the lru.  For now such page is charged like a regular page
_

Patches currently in -mm which might be from akpm@linux-foundation.org are

mm-shmem-fix-race-in-shmem_undo_range-w-thp-fix.patch
mm-remove-redundant-k-macro-definition-fix.patch
mm-always-lock-new-vma-before-inserting-into-vma-tree-fix.patch
mm-fix-get_mctgt_type-kernel-doc-fix.patch

Re: + mm-fix-get_mctgt_type-kernel-doc-fix.patch added to mm-unstable branch

[Matthew Wilcox]

On Mon, Aug 21, 2023 at 11:54:53AM -0700, Andrew Morton wrote:
> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: mm-fix-get_mctgt_type-kernel-doc-fix
> Date: Mon Aug 21 11:53:43 AM PDT 2023
> 
> changes suggested by Randy

Randy and I had a further discussion offline, and I added this change
too:

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 26ba9d1a66d1..b29b850cf399 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -5855,10 +5855,10 @@ static int mem_cgroup_move_account(struct page *page,
  * * MC_TARGET_NONE - If the pte is not a target for move charge.
  * * MC_TARGET_PAGE - If the page corresponding to this pte is a target for
  *   move charge. If @target is not NULL, the page is stored in target->page
- *   with extra refcnt taken (Callers should handle it).
+ *   with extra refcnt taken (Caller should release it).
  * * MC_TARGET_SWAP - If the swap entry corresponding to this pte is a
- *   target for charge migration.  If @target is not NULL, the entry is stored
- *   in target->ent.
+ *   target for charge migration.  If @target is not NULL, the entry is
+ *   stored in target->ent.
  * * MC_TARGET_DEVICE - Like MC_TARGET_PAGE but page is device memory and
  *   thus not on the lru.  For now such page is charged like a regular page
  *   would be as it is just special memory taking the place of a regular page.