From: Simon Horman <horms@kernel.org>
To: Zhengchao Shao <shaozhengchao@huawei.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, steffen.klassert@secunet.com,
herbert@gondor.apana.org.au, dsahern@kernel.org,
eyal.birger@gmail.com, paulmck@kernel.org,
joel@joelfernandes.org, tglx@linutronix.de, mbizon@freebox.fr,
jmaxwell37@gmail.com, weiyongjun1@huawei.com,
yuehaibing@huawei.com
Subject: Re: [PATCH net-next] net: remove unnecessary input parameter 'how' in ifdown function
Date: Tue, 22 Aug 2023 09:18:39 +0200 [thread overview]
Message-ID: <20230822071839.GL2711035@kernel.org> (raw)
In-Reply-To: <20230821084104.3812233-1-shaozhengchao@huawei.com>
On Mon, Aug 21, 2023 at 04:41:04PM +0800, Zhengchao Shao wrote:
> When the ifdown function in the dst_ops structure is referenced, the input
> parameter 'how' is always true. In the current implementation of the
> ifdown interface, ip6_dst_ifdown does not use the input parameter 'how',
> xfrm6_dst_ifdown and xfrm4_dst_ifdown functions use the input parameter
> 'unregister'. But false judgment on 'unregister' in xfrm6_dst_ifdown and
> xfrm4_dst_ifdown is false, so remove the input parameter 'how' in ifdown
> function.
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-08-22 7:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 8:41 [PATCH net-next] net: remove unnecessary input parameter 'how' in ifdown function Zhengchao Shao
2023-08-22 7:18 ` Simon Horman [this message]
2023-08-22 13:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822071839.GL2711035@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eyal.birger@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jmaxwell37@gmail.com \
--cc=joel@joelfernandes.org \
--cc=kuba@kernel.org \
--cc=mbizon@freebox.fr \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulmck@kernel.org \
--cc=shaozhengchao@huawei.com \
--cc=steffen.klassert@secunet.com \
--cc=tglx@linutronix.de \
--cc=weiyongjun1@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.