From: Simon Horman <horms@kernel.org>
To: Ido Schimmel <idosch@nvidia.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com, dsahern@kernel.org,
mlxsw@nvidia.com
Subject: Re: [PATCH net-next] vrf: Remove unnecessary RCU-bh critical section
Date: Tue, 22 Aug 2023 09:32:01 +0200 [thread overview]
Message-ID: <20230822073201.GO2711035@kernel.org> (raw)
In-Reply-To: <20230821142339.1889961-1-idosch@nvidia.com>
On Mon, Aug 21, 2023 at 05:23:39PM +0300, Ido Schimmel wrote:
> dev_queue_xmit_nit() already uses rcu_read_lock() / rcu_read_unlock()
> and nothing suggests that softIRQs should be disabled around it.
> Therefore, remove the rcu_read_lock_bh() / rcu_read_unlock_bh()
> surrounding it.
>
> Tested using [1] with lockdep enabled.
>
> [1]
> #!/bin/bash
>
> ip link add name vrf1 up type vrf table 100
> ip link add name veth0 type veth peer name veth1
> ip link set dev veth1 master vrf1
> ip link set dev veth0 up
> ip link set dev veth1 up
> ip address add 192.0.2.1/24 dev veth0
> ip address add 192.0.2.2/24 dev veth1
> ip rule add pref 32765 table local
> ip rule del pref 0
> tcpdump -i vrf1 -c 20 -w /dev/null &
> sleep 10
> ping -i 0.1 -c 10 -q 192.0.2.2
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-08-22 7:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 14:23 [PATCH net-next] vrf: Remove unnecessary RCU-bh critical section Ido Schimmel
2023-08-22 7:32 ` Simon Horman [this message]
2023-08-22 15:29 ` David Ahern
2023-08-22 18:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822073201.GO2711035@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.