From: Jakub Kicinski <kuba@kernel.org>
To: Justin Lai <justinlai0215@realtek.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<jiri@resnulli.us>, <andrew@lunn.ch>
Subject: Re: [PATCH net-next v6 1/2] net/ethernet/realtek: Add Realtek automotive PCIe driver code
Date: Tue, 22 Aug 2023 10:37:50 -0700 [thread overview]
Message-ID: <20230822103750.6dbb6fc2@kernel.org> (raw)
In-Reply-To: <20230822031805.4752-2-justinlai0215@realtek.com>
On Tue, 22 Aug 2023 11:18:04 +0800 Justin Lai wrote:
> drivers/net/ethernet/realtek/rtase/rtase.h | 372 +++
> .../net/ethernet/realtek/rtase/rtase_main.c | 2432 +++++++++++++++++
> 5 files changed, 2832 insertions(+)
Please split this into multiple patches, I already asked you to do so.
Individual ethtool ops and vlan support should be separate patches,
perhaps you can separate other features out, too.
next prev parent reply other threads:[~2023-08-22 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 3:18 [PATCH net-next v6 0/2] Add Realtek automotive PCIe driver Justin Lai
2023-08-22 3:18 ` [PATCH net-next v6 1/2] net/ethernet/realtek: Add Realtek automotive PCIe driver code Justin Lai
2023-08-22 17:37 ` Jakub Kicinski [this message]
2023-08-23 14:20 ` Justin Lai
2023-08-22 17:51 ` Andrew Lunn
2023-08-23 14:25 ` Justin Lai
2023-08-22 17:59 ` Andrew Lunn
2023-08-23 14:28 ` Justin Lai
2023-08-22 3:18 ` [PATCH net-next v6 2/2] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822103750.6dbb6fc2@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=justinlai0215@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.