From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28FD3EE4993 for ; Tue, 22 Aug 2023 16:07:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id C06EF4014D; Tue, 22 Aug 2023 16:07:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org C06EF4014D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1692720420; bh=rWwjlhmNTqVmiFc1dOsTA7/j02d6nxs6AJz2yvQMAdc=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=AaPJ2NG9ltiammAfm9YA0qBfAY9UjnffOR5acJyLw3qURlADgW43Y1geUAB6bc/55 vCjT5K8bpjBoSFSKHKRXaIHoykajgwhBvT4PEs0AzRYE3ADh40Zfu5z8F3y541diRu byB4lUP49FHFihBn33MxwrhygrD6YQxTNzj+UguCnGmqWDP8JmhZiWmt5Nz/VaQ1lG Rjo3e5LC/25Bw9MJr3Z+RjJf9Sp6PQNV5P9Ck5+GIp8iBtUg8LQM3HddBOaMETsK1G 7VDK/xFVxFLWufkbh3e8nzAjeENLAFJlEZY9Md0U/67x0chbByxJZV2zQdUS/hcmbf OR3eAu+hnFrnQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I4TEwtRwEPE5; Tue, 22 Aug 2023 16:07:00 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id B36C440272; Tue, 22 Aug 2023 16:06:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org B36C440272 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id A9C8A1BF39D for ; Tue, 22 Aug 2023 16:06:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 8A9A4408BD for ; Tue, 22 Aug 2023 16:06:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8A9A4408BD X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7aB8MeLJFiDo for ; Tue, 22 Aug 2023 16:06:57 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id 4210A408AA for ; Tue, 22 Aug 2023 16:06:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4210A408AA Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 796AB624D6; Tue, 22 Aug 2023 16:06:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6261FC433C8; Tue, 22 Aug 2023 16:06:55 +0000 (UTC) Date: Tue, 22 Aug 2023 19:06:51 +0300 From: Leon Romanovsky To: Przemek Kitszel , anthony.l.nguyen@intel.com, Jakub Kicinski , "David S. Miller" Message-ID: <20230822160651.GN6029@unreal> References: <20230817141746.18726-1-karol.kolacinski@intel.com> <20230817141746.18726-2-karol.kolacinski@intel.com> <20230819115249.GP22185@unreal> <20230822070211.GH2711035@kernel.org> <20230822141348.GH6029@unreal> <20230822154810.GM6029@unreal> <8a0e05ed-ae10-ba2f-5859-003cd02fba9c@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8a0e05ed-ae10-ba2f-5859-003cd02fba9c@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692720415; bh=1V7w5fj4v1tLII5zZTBA1w3oKQjMiTF1veCGb3+VCYo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hb9YUpXluU/qkdIVPn5jGONVx8yj//QL2hQAmzhL/mrITbjMYzNGxpMfnPNJT0cx2 CGGf8gpIM+m/XMN5QRgwTvQ+cBl5sx9lT19gBg0HDh2AhoVx8IwXGT3oHrCAzfmMba 3aEG1rDsvICZlWzzM7qhTdCh1ZC4Do0NFjSlOTfN8EgawbHqBP7Fxh6qi2RODTDHTe afhS/CQNyTmtStFor5ABkoW2aED9KRNHUCeqk88n/wgaNesHNN1JWTv0iQSKUyJzLU vzRN3Cu9T55sz6Cv5vwnTJUvFqs8yF+2fKwE84mBrkGQUyzTe4pkLx2m8j7KXQjND5 BCPGhuw1K1hnA== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Hb9YUpXl Subject: Re: [Intel-wired-lan] [PATCH v2 iwl-next 1/9] ice: use ice_pf_src_tmr_owned where available X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, jesse.brandeburg@intel.com, Karol Kolacinski , intel-wired-lan@lists.osuosl.org, Simon Horman , Jiri Pirko , anthony.l.nguyen@intel.com, Saeed Mahameed Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" T24gVHVlLCBBdWcgMjIsIDIwMjMgYXQgMDU6NTY6MjVQTSArMDIwMCwgUHJ6ZW1layBLaXRzemVs IHdyb3RlOgo+IE9uIDgvMjIvMjMgMTc6NDgsIExlb24gUm9tYW5vdnNreSB3cm90ZToKPiA+IE9u IFR1ZSwgQXVnIDIyLCAyMDIzIGF0IDA0OjQ0OjI5UE0gKzAyMDAsIFByemVtZWsgS2l0c3plbCB3 cm90ZToKPiA+ID4gT24gOC8yMi8yMyAxNjoxMywgTGVvbiBSb21hbm92c2t5IHdyb3RlOgo+ID4g PiA+IE9uIFR1ZSwgQXVnIDIyLCAyMDIzIGF0IDA5OjAyOjExQU0gKzAyMDAsIFNpbW9uIEhvcm1h biB3cm90ZToKPiA+ID4gPiA+IE9uIFNhdCwgQXVnIDE5LCAyMDIzIGF0IDAyOjUyOjQ5UE0gKzAz MDAsIExlb24gUm9tYW5vdnNreSB3cm90ZToKPiA+ID4gPiA+ID4gT24gVGh1LCBBdWcgMTcsIDIw MjMgYXQgMDQ6MTc6MzhQTSArMDIwMCwgS2Fyb2wgS29sYWNpbnNraSB3cm90ZToKPiA+ID4gPiA+ ID4gPiBUaGUgaWNlX3BmX3NyY190bXJfb3duZWQoKSBtYWNybyBleGlzdHMgdG8gY2hlY2sgdGhl IGZ1bmN0aW9uIGNhcGFiaWxpdHkKPiA+ID4gPiA+ID4gPiBiaXQgaW5kaWNhdGluZyBpZiB0aGUg Y3VycmVudCBmdW5jdGlvbiBvd25zIHRoZSBQVFAgaGFyZHdhcmUgY2xvY2suCj4gPiA+ID4gPiA+ IAo+ID4gPiA+ID4gPiBUaGlzIGlzIGZpcnN0IHBhdGNoIGluIHRoZSBzZXJpZXMsIGJ1dCBJIGNh bid0IGZpbmQgbWVudGlvbmVkIG1hY3JvLgo+ID4gPiA+ID4gPiBNeSBuZXQtbmV4dCBpcyBiYXNl ZCBvbiA1YjBhMTQxNGUwYjAgKCJNZXJnZSBicmFuY2ggJ3NtYy1mZWF0dXJlcyciKQo+ID4gPiA+ ID4gPiDinpwgIGtlcm5lbCBnaXQ6KG5ldC1uZXh0KSBnaXQgZ3JlcCBpY2VfcGZfc3JjX3Rtcl9v d25lZAo+ID4gPiA+ID4gPiBzaG93cyBub3RoaW5nLgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4g T24gd2hpY2ggYnJhbmNoIGlzIGl0IGJhc2VkPwo+ID4gPiA+ID4gCj4gPiA+ID4gPiBIaSBMZW9u LAo+ID4gPiA+ID4gCj4gPiA+ID4gPiBNeSBhc3N1bXB0aW9uIGlzIHRoYXQgaXQgaXMgYmFzZWQg b24gdGhlIGRldi1xdWV1ZSBicmFuY2ggb2YKPiA+ID4gPiA+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5v cmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RuZ3V5L25leHQtcXVldWUuZ2l0Cj4gPiA+ID4g Cj4gPiA+ID4gU28gc2hvdWxkIG5ldGRldiByZWFkZXJzIHJldmlldyBpdCBvciB3YWl0IHRpbGwg SW50ZWwgZm9sa3MgcGVyZm9ybQo+ID4gPiA+IGZpcnN0IHBhc3Mgb24gaXQ/Cj4gPiA+IAo+ID4g PiBNb3N0IG9mIHRoZSB0aW1lIEludGVsIGZvbGtzIHdvdWxkIGJlIGZpcnN0IHRvIHJldmlldywg aWYgb25seSBiZWNhdXNlIG9mCj4gPiA+IG91ciBwcmUtSVdMIHByb2Nlc3NlcyBvciBwdXJlIGZh bWlsaWFyaXR5L2ludGVyZXN0IGluIGdpdmVuIHBpZWNlLgo+ID4gPiAKPiA+ID4gRm9yIHRoaXMg cGFydGljdWxhciBzZXJpZXMsIGl0IGlzIGFib3V0IHJpZ2h0ICJjb2Rld2lzZSIgc2luY2UgdjEs IHNvIHlvdQo+ID4gPiBhcmUgd2VsY29tZSBmb3IgYW4gaW5zaWdodGZ1bCBsb29rIGF0IHYzCj4g PiA+IChJIGRpZG4ndCBwcm92aWRlZCBteSBSQnMgc28gZmFyIGJlY2F1c2Ugb2YgIm1ldGFkYXRh IiBpc3N1ZXMgOiksCj4gPiA+IHdpbGwgdGFrZSBhIGZyZXNoIGxvb2ssIGJ1dCB5b3UgZG9uJ3Qg bmVlZCB0byB3YWl0KS4KPiA+ID4gCj4gPiA+IAo+ID4gPiBHZW5lcmFsIGlkZWEgZm9yIENDJ2lu ZyBuZXRkZXYgZm9yIElXTC10YXJnZXRlZCBwYXRjaGVzIGlzIHRvIGhhdmUgb3Blbgo+ID4gPiBk ZXZlbG9tcGVudCBwcm9jZXNzLgo+ID4gPiBRdWFsaXR5IHNob3VsZCBiZSBhbHJlYWR5IGFzIGZv ciBuZXRkZXYgcG9zdGluZy4KPiA+ID4gT3VyIFZBTCBwaWNrcyB1cCBwYXRjaGVzIGZvciB0ZXN0 aW5nIGZyb20gaGVyZSB3aGVuIFRvbnkgbWFya3MgdGhlbSBzby4KPiA+ID4gCj4gPiA+IFRoYXQn cyB3aGF0IEkgY291bGQgc2F5IGZvciByZXZpZXcgcHJvY2Vzcy4KPiA+ID4gCj4gPiA+ICJNYWlu dGFpbmVycyBzdHVmZiIsIEkgKmd1ZXNzKiwgaXM6Cj4gPiA+IGFmdGVyIHJldmlldyZ0ZXN0IFRv bnkgUmVxdWVzdHMgbmV0ZGV2IE1haW50YWluZXJzIHRvIFB1bGwKPiA+ID4gKGFuZCB0aHJvdHRs ZXMgb3V0Z29pbmcgc3R1ZmYgYnkgZG9pbmcgc28gdG8gcGFjZSBhZ3JlZWQgdXBvbikuCj4gPiA+ IEF0IHRoYXQgc3RhZ2UgaXMgYSBsYXN0IG1vbWVudCBmb3IgKGxhdGU/KSByZXZpZXcsIHdlbGNv bWVkIGFzIGFsd2F5cy4KPiA+IAo+ID4gSXQgbWVhbnMgdGhhdCB3ZSAobmV0ZGV2QC4uLiApIHdp bGwgc2VlICJzYW1lIiBwYXRjaGVzIHR3aWNlLCBhbSBJIHJpZ2h0Pwo+IAo+IFRoYXQncyB0cnVl LgoKQ2FuIEkgc3VnZ2VzdCBjaGFuZ2UgaW4gdGhlIHByb2Nlc3M/CjEuIFBlcmZvcm0gdmFsaWRh dGlvbiBiZWZvcmUgcG9zdGluZwoyLiBJbnRlbCB3aWxsIHBvc3QgdGhlaXIgcGF0Y2hlcyB0byB0 aGUgbmV0ZGV2QCBNTC4KMy4gVG9ueSB3aWxsIGNvbGxlY3QgcmV2aWV3ZWQgcGF0Y2hlcyBmcm9t IG5ldGRldkAKNC4gVG9ueSB3aWxsIHNlbmQgY2xlYW4gUFJzICh3aXRob3V0IHBhdGNoZXMpIGZy b20gdGltZSB0byB0aW1lIHRvCm5ldGRldiBtYWludGFpbmVycyBmb3IgYWNjZXB0YW5jZS4KCkl0 IHdpbGwgYWxsb3cgdG8gYWxsIG9mIHVzIChJbnRlbCwgTnZpZGlhIGUudC5jKSB0byBoYXZlIHNh bWUgc3VibWlzc2lvbgpmbG93IHdpdGhvdXQgc2FjcmlmaWNpbmcgb3BlbiBuZXRkZXZAIHJldmll dyB3aGljaCB3aWxsIGJlIGRvbmUgb25seSBvbmNlLgoKSmFrdWIvRGF2ZSwgaXMgaXQgcG9zc2li bGU/CgpUaGFua3MKCj4gCj4gPiAKPiA+IFRoYW5rcwo+ID4gCj4gPiA+IAo+ID4gPiAKPiA+ID4g Cj4gPiA+ID4gCj4gPiA+ID4gVGhhbmtzCj4gPiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4gPiBJbnRlbC13aXJlZC1sYW4gbWFpbGluZyBs aXN0Cj4gPiA+ID4gSW50ZWwtd2lyZWQtbGFuQG9zdW9zbC5vcmcKPiA+ID4gPiBodHRwczovL2xp c3RzLm9zdW9zbC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC13aXJlZC1sYW4KPiA+ID4gCj4g PiA+IAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC13aXJlZC1sYW4gbWFpbGluZyBsaXN0CkludGVsLXdpcmVkLWxhbkBvc3Vvc2wub3JnCmh0 dHBzOi8vbGlzdHMub3N1b3NsLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLXdpcmVkLWxhbgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72DD51CA1F for ; Tue, 22 Aug 2023 16:06:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6261FC433C8; Tue, 22 Aug 2023 16:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692720415; bh=1V7w5fj4v1tLII5zZTBA1w3oKQjMiTF1veCGb3+VCYo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hb9YUpXluU/qkdIVPn5jGONVx8yj//QL2hQAmzhL/mrITbjMYzNGxpMfnPNJT0cx2 CGGf8gpIM+m/XMN5QRgwTvQ+cBl5sx9lT19gBg0HDh2AhoVx8IwXGT3oHrCAzfmMba 3aEG1rDsvICZlWzzM7qhTdCh1ZC4Do0NFjSlOTfN8EgawbHqBP7Fxh6qi2RODTDHTe afhS/CQNyTmtStFor5ABkoW2aED9KRNHUCeqk88n/wgaNesHNN1JWTv0iQSKUyJzLU vzRN3Cu9T55sz6Cv5vwnTJUvFqs8yF+2fKwE84mBrkGQUyzTe4pkLx2m8j7KXQjND5 BCPGhuw1K1hnA== Date: Tue, 22 Aug 2023 19:06:51 +0300 From: Leon Romanovsky To: Przemek Kitszel , anthony.l.nguyen@intel.com, Jakub Kicinski , "David S. Miller" Cc: Simon Horman , netdev@vger.kernel.org, jesse.brandeburg@intel.com, Karol Kolacinski , anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org, Saeed Mahameed , Jiri Pirko Subject: Re: [Intel-wired-lan] [PATCH v2 iwl-next 1/9] ice: use ice_pf_src_tmr_owned where available Message-ID: <20230822160651.GN6029@unreal> References: <20230817141746.18726-1-karol.kolacinski@intel.com> <20230817141746.18726-2-karol.kolacinski@intel.com> <20230819115249.GP22185@unreal> <20230822070211.GH2711035@kernel.org> <20230822141348.GH6029@unreal> <20230822154810.GM6029@unreal> <8a0e05ed-ae10-ba2f-5859-003cd02fba9c@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8a0e05ed-ae10-ba2f-5859-003cd02fba9c@intel.com> On Tue, Aug 22, 2023 at 05:56:25PM +0200, Przemek Kitszel wrote: > On 8/22/23 17:48, Leon Romanovsky wrote: > > On Tue, Aug 22, 2023 at 04:44:29PM +0200, Przemek Kitszel wrote: > > > On 8/22/23 16:13, Leon Romanovsky wrote: > > > > On Tue, Aug 22, 2023 at 09:02:11AM +0200, Simon Horman wrote: > > > > > On Sat, Aug 19, 2023 at 02:52:49PM +0300, Leon Romanovsky wrote: > > > > > > On Thu, Aug 17, 2023 at 04:17:38PM +0200, Karol Kolacinski wrote: > > > > > > > The ice_pf_src_tmr_owned() macro exists to check the function capability > > > > > > > bit indicating if the current function owns the PTP hardware clock. > > > > > > > > > > > > This is first patch in the series, but I can't find mentioned macro. > > > > > > My net-next is based on 5b0a1414e0b0 ("Merge branch 'smc-features'") > > > > > > ➜ kernel git:(net-next) git grep ice_pf_src_tmr_owned > > > > > > shows nothing. > > > > > > > > > > > > On which branch is it based? > > > > > > > > > > Hi Leon, > > > > > > > > > > My assumption is that it is based on the dev-queue branch of > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git > > > > > > > > So should netdev readers review it or wait till Intel folks perform > > > > first pass on it? > > > > > > Most of the time Intel folks would be first to review, if only because of > > > our pre-IWL processes or pure familiarity/interest in given piece. > > > > > > For this particular series, it is about right "codewise" since v1, so you > > > are welcome for an insightful look at v3 > > > (I didn't provided my RBs so far because of "metadata" issues :), > > > will take a fresh look, but you don't need to wait). > > > > > > > > > General idea for CC'ing netdev for IWL-targeted patches is to have open > > > develompent process. > > > Quality should be already as for netdev posting. > > > Our VAL picks up patches for testing from here when Tony marks them so. > > > > > > That's what I could say for review process. > > > > > > "Maintainers stuff", I *guess*, is: > > > after review&test Tony Requests netdev Maintainers to Pull > > > (and throttles outgoing stuff by doing so to pace agreed upon). > > > At that stage is a last moment for (late?) review, welcomed as always. > > > > It means that we (netdev@... ) will see "same" patches twice, am I right? > > That's true. Can I suggest change in the process? 1. Perform validation before posting 2. Intel will post their patches to the netdev@ ML. 3. Tony will collect reviewed patches from netdev@ 4. Tony will send clean PRs (without patches) from time to time to netdev maintainers for acceptance. It will allow to all of us (Intel, Nvidia e.t.c) to have same submission flow without sacrificing open netdev@ review which will be done only once. Jakub/Dave, is it possible? Thanks > > > > > Thanks > > > > > > > > > > > > > > > > > > > Thanks > > > > _______________________________________________ > > > > Intel-wired-lan mailing list > > > > Intel-wired-lan@osuosl.org > > > > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan > > > > > > >