From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E556EEE4993 for ; Tue, 22 Aug 2023 15:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=24r+hIhkMcVn073R4biu/6AObZE7zQHqNEpw3egMh0A=; b=d+Pyd/FWK5a8F3 vRqm2nTBe0Hdu9DnK1xDkPUGZ8wfZr0VyNPFUwppv+Sry5UPCwWmsuIylc6S1U4RHuFzJcWOlOqlO 9Rk75q2VgONHwCNRqzkHmTiCuv9l/PX9NJMCcNuQikzvWdtI8AG4ceYohDiGWr/9TPer7rPBi/zqw nsz8TCjfRfrtsOlfxUSNKniMWZAe/nmo9sxLifHx9l5GpVtbQIsQ8CUN4284VoiVLTSxGbJwZf/mm r0Jl4snJ4IxNQEuPjlMtloYK1bH5dXQadClcEOm4/W+qfx24up3Vygxbjsb14kwGmnRsK1dJJB2C0 tI1P3wWEq783JngDqH9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qYTjX-00GQ1Q-1C; Tue, 22 Aug 2023 15:55:55 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qYTjW-00GQ17-2B; Tue, 22 Aug 2023 15:55:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=S2nWE3aQXFlKdqzDmsVrOKSeJqyIatEgKjU2+rJLr14=; b=h3LZMwRi//eYTY51C/zEUbk/KO Dho7q3CkJYHxVIdRK7/rrnp2+YNqLZsktupbQMebaIvDmYa2YpqGHA+7yqU06Kk5vULxXH6q5Yu7c TShQ8Zjh3ocqJrA+BI2sDEi0aCjfHO5B09W19cbvlWyOfjnwbBfXDn3fcId9awHN6fr2zKv0iRjTN E+mdjMh1TTg7K1Qe9lTSxVSkwrpC/pq/aA8jTZtrU1bpNAI/guBoyXTppDH//j0Fa7aGkIaJGb+I4 yVR8i++m+9VzLZYOu0ehN0C7gdOllVaqbLI3wHpp0GLVWL09SwiXkydAgQW5n1LXP7EOnzd2lOfbT PyTaKutA==; Received: from frasgout.his.huawei.com ([185.176.79.56]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qYTjR-002rSb-0Q; Tue, 22 Aug 2023 15:55:53 +0000 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RVYnd4n4Yz6D8d1; Tue, 22 Aug 2023 23:54:45 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 22 Aug 2023 16:55:25 +0100 Date: Tue, 22 Aug 2023 16:55:24 +0100 From: Jonathan Cameron To: Li Zetao CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH -next 02/25] spi: armada-3700: Use helper function devm_clk_get_prepared() Message-ID: <20230822165524.000062a8@Huawei.com> In-Reply-To: <20230822131237.1022815-3-lizetao1@huawei.com> References: <20230822131237.1022815-1-lizetao1@huawei.com> <20230822131237.1022815-3-lizetao1@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230822_165549_254497_F2D4CCAF X-CRM114-Status: UNSURE ( 6.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org > @@ -909,10 +901,6 @@ static int a3700_spi_probe(struct platform_device *pdev) > > static void a3700_spi_remove(struct platform_device *pdev) > { > - struct spi_controller *host = platform_get_drvdata(pdev); > - struct a3700_spi *spi = spi_controller_get_devdata(host); > - > - clk_unprepare(spi->clk); Hi. No point in keeping an empty remove function. Drop the whole thing now there is nothing to do. Jonathan > } > > static struct platform_driver a3700_spi_driver = { _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Date: Tue, 22 Aug 2023 16:55:24 +0100 Subject: [PATCH -next 02/25] spi: armada-3700: Use helper function devm_clk_get_prepared() In-Reply-To: <20230822131237.1022815-3-lizetao1@huawei.com> References: <20230822131237.1022815-1-lizetao1@huawei.com> <20230822131237.1022815-3-lizetao1@huawei.com> Message-ID: <20230822165524.000062a8@Huawei.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > @@ -909,10 +901,6 @@ static int a3700_spi_probe(struct platform_device *pdev) > > static void a3700_spi_remove(struct platform_device *pdev) > { > - struct spi_controller *host = platform_get_drvdata(pdev); > - struct a3700_spi *spi = spi_controller_get_devdata(host); > - > - clk_unprepare(spi->clk); Hi. No point in keeping an empty remove function. Drop the whole thing now there is nothing to do. Jonathan > } > > static struct platform_driver a3700_spi_driver = { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63211EE49AC for ; Tue, 22 Aug 2023 15:56:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S2nWE3aQXFlKdqzDmsVrOKSeJqyIatEgKjU2+rJLr14=; b=ZF6s2U50M7+qRJeYhH62RZdg7o ozR2qdyYiaagqPE5DtJU3CFSaeeLEJ6M2pUxFH8V0KBNlXgiLCY69xLeYp2bJCCR+oBM1OKeJF1Tt gXnMCTD9l128eqPyV8n1RLzW3hvQLhspZ97CAGU+IjTrI97no1VzLdPuk9otN4M9cgIcD8tDrSUXj yYipiLy60uIGimbX0Q7cAVWPTgnVyVn2ID8nyub+MCY3EafKy6xpBpRxoJaAnwKsyI9d+9VpeVRZ+ yCBsiK+U7tlMcWv4D9nbDlvtnH3V+rDl0tvuSVZqnOOSBKNTfqyinNBw3XkKRDweMcH5ruAyZevOl 8dVuNbgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qYTjZ-00GQ2n-0t; Tue, 22 Aug 2023 15:55:57 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qYTjW-00GQ17-2B; Tue, 22 Aug 2023 15:55:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=S2nWE3aQXFlKdqzDmsVrOKSeJqyIatEgKjU2+rJLr14=; b=h3LZMwRi//eYTY51C/zEUbk/KO Dho7q3CkJYHxVIdRK7/rrnp2+YNqLZsktupbQMebaIvDmYa2YpqGHA+7yqU06Kk5vULxXH6q5Yu7c TShQ8Zjh3ocqJrA+BI2sDEi0aCjfHO5B09W19cbvlWyOfjnwbBfXDn3fcId9awHN6fr2zKv0iRjTN E+mdjMh1TTg7K1Qe9lTSxVSkwrpC/pq/aA8jTZtrU1bpNAI/guBoyXTppDH//j0Fa7aGkIaJGb+I4 yVR8i++m+9VzLZYOu0ehN0C7gdOllVaqbLI3wHpp0GLVWL09SwiXkydAgQW5n1LXP7EOnzd2lOfbT PyTaKutA==; Received: from frasgout.his.huawei.com ([185.176.79.56]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qYTjR-002rSb-0Q; Tue, 22 Aug 2023 15:55:53 +0000 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RVYnd4n4Yz6D8d1; Tue, 22 Aug 2023 23:54:45 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 22 Aug 2023 16:55:25 +0100 Date: Tue, 22 Aug 2023 16:55:24 +0100 From: Jonathan Cameron To: Li Zetao CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH -next 02/25] spi: armada-3700: Use helper function devm_clk_get_prepared() Message-ID: <20230822165524.000062a8@Huawei.com> In-Reply-To: <20230822131237.1022815-3-lizetao1@huawei.com> References: <20230822131237.1022815-1-lizetao1@huawei.com> <20230822131237.1022815-3-lizetao1@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230822_165549_254497_F2D4CCAF X-CRM114-Status: UNSURE ( 6.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org > @@ -909,10 +901,6 @@ static int a3700_spi_probe(struct platform_device *pdev) > > static void a3700_spi_remove(struct platform_device *pdev) > { > - struct spi_controller *host = platform_get_drvdata(pdev); > - struct a3700_spi *spi = spi_controller_get_devdata(host); > - > - clk_unprepare(spi->clk); Hi. No point in keeping an empty remove function. Drop the whole thing now there is nothing to do. Jonathan > } > > static struct platform_driver a3700_spi_driver = { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A34DEE4993 for ; Tue, 22 Aug 2023 15:56:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tTbNy7hBztGXEuyTuOJn1QSRBSGbaLuNiC0EM6HcwlM=; b=wXeSp8ENWKEtzO P39YqnhWuaXhT5OFcIkAaBES6wlY6glTABC3ZADaAc3uKh5IP7TUmdDPD45Y4Rrid6xDBYl7EiCXR 05I4GwaM9bNQCngMJ0PgiCa0eJS4l+3dvQbFBOfhQnrU1X5oN3NczRk5fVNN7Jk+x/cO7T5YU+WUu xtcwBecqAivox1L6BdPRHUqpjj5ftlnRkSK2qLQblpTS9oFS55+hZC5j6xCm7vr3blTG81KTg0vIh MrqWzbyK03tYc4/Yo3dwpU3R0fCD67Q5+0jMyuz78yStPzoHZVVb9ihbtc+vWf8B0olTmysAlo6kH qK4Py3kR5F/nWox2gs1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qYTja-00GQ36-0b; Tue, 22 Aug 2023 15:55:58 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qYTjW-00GQ17-2B; Tue, 22 Aug 2023 15:55:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=S2nWE3aQXFlKdqzDmsVrOKSeJqyIatEgKjU2+rJLr14=; b=h3LZMwRi//eYTY51C/zEUbk/KO Dho7q3CkJYHxVIdRK7/rrnp2+YNqLZsktupbQMebaIvDmYa2YpqGHA+7yqU06Kk5vULxXH6q5Yu7c TShQ8Zjh3ocqJrA+BI2sDEi0aCjfHO5B09W19cbvlWyOfjnwbBfXDn3fcId9awHN6fr2zKv0iRjTN E+mdjMh1TTg7K1Qe9lTSxVSkwrpC/pq/aA8jTZtrU1bpNAI/guBoyXTppDH//j0Fa7aGkIaJGb+I4 yVR8i++m+9VzLZYOu0ehN0C7gdOllVaqbLI3wHpp0GLVWL09SwiXkydAgQW5n1LXP7EOnzd2lOfbT PyTaKutA==; Received: from frasgout.his.huawei.com ([185.176.79.56]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qYTjR-002rSb-0Q; Tue, 22 Aug 2023 15:55:53 +0000 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RVYnd4n4Yz6D8d1; Tue, 22 Aug 2023 23:54:45 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 22 Aug 2023 16:55:25 +0100 Date: Tue, 22 Aug 2023 16:55:24 +0100 From: Jonathan Cameron To: Li Zetao CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH -next 02/25] spi: armada-3700: Use helper function devm_clk_get_prepared() Message-ID: <20230822165524.000062a8@Huawei.com> In-Reply-To: <20230822131237.1022815-3-lizetao1@huawei.com> References: <20230822131237.1022815-1-lizetao1@huawei.com> <20230822131237.1022815-3-lizetao1@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230822_165549_254497_F2D4CCAF X-CRM114-Status: UNSURE ( 6.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org > @@ -909,10 +901,6 @@ static int a3700_spi_probe(struct platform_device *pdev) > > static void a3700_spi_remove(struct platform_device *pdev) > { > - struct spi_controller *host = platform_get_drvdata(pdev); > - struct a3700_spi *spi = spi_controller_get_devdata(host); > - > - clk_unprepare(spi->clk); Hi. No point in keeping an empty remove function. Drop the whole thing now there is nothing to do. Jonathan > } > > static struct platform_driver a3700_spi_driver = { _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1860DEE49A3 for ; Tue, 22 Aug 2023 15:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=11YFW6qR5tnbTPI2xKZyjvJL08wPKAq8O0eq6UEIbpI=; b=NKARfsE4glRAHH XUD569pKx0Dt7YwagoOpMbSH03lOiSDK6kaNGArzih3n4GG8AXedf0LcCDYU7MxCiymLRdImKM9YJ hSerbnlGBIKYA+geTY4AscOLV12nupJGW7etDU98uqJtcjouodGNJndKQlssOAL1BO1g2kqtUNMep rP0cDdhcBYs+aDiU7htCJ5mw3oA837wfCbS65Xb6dZwzHS5lbEuAfCbHNMW47FRu8ELGPOQfCOT7S LKuP5HzN+mT1VlLf8V8oeQE/c4y7nWyfbc8z69VcYgy058Ty6ys5JbNDM0GEA40OPioNocDLqDdMi Cd+Km3NEoCVjuXZAV5UA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qYTjZ-00GQ2t-21; Tue, 22 Aug 2023 15:55:57 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qYTjW-00GQ17-2B; Tue, 22 Aug 2023 15:55:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=S2nWE3aQXFlKdqzDmsVrOKSeJqyIatEgKjU2+rJLr14=; b=h3LZMwRi//eYTY51C/zEUbk/KO Dho7q3CkJYHxVIdRK7/rrnp2+YNqLZsktupbQMebaIvDmYa2YpqGHA+7yqU06Kk5vULxXH6q5Yu7c TShQ8Zjh3ocqJrA+BI2sDEi0aCjfHO5B09W19cbvlWyOfjnwbBfXDn3fcId9awHN6fr2zKv0iRjTN E+mdjMh1TTg7K1Qe9lTSxVSkwrpC/pq/aA8jTZtrU1bpNAI/guBoyXTppDH//j0Fa7aGkIaJGb+I4 yVR8i++m+9VzLZYOu0ehN0C7gdOllVaqbLI3wHpp0GLVWL09SwiXkydAgQW5n1LXP7EOnzd2lOfbT PyTaKutA==; Received: from frasgout.his.huawei.com ([185.176.79.56]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qYTjR-002rSb-0Q; Tue, 22 Aug 2023 15:55:53 +0000 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RVYnd4n4Yz6D8d1; Tue, 22 Aug 2023 23:54:45 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 22 Aug 2023 16:55:25 +0100 Date: Tue, 22 Aug 2023 16:55:24 +0100 From: Jonathan Cameron To: Li Zetao CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH -next 02/25] spi: armada-3700: Use helper function devm_clk_get_prepared() Message-ID: <20230822165524.000062a8@Huawei.com> In-Reply-To: <20230822131237.1022815-3-lizetao1@huawei.com> References: <20230822131237.1022815-1-lizetao1@huawei.com> <20230822131237.1022815-3-lizetao1@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230822_165549_254497_F2D4CCAF X-CRM114-Status: UNSURE ( 6.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org > @@ -909,10 +901,6 @@ static int a3700_spi_probe(struct platform_device *pdev) > > static void a3700_spi_remove(struct platform_device *pdev) > { > - struct spi_controller *host = platform_get_drvdata(pdev); > - struct a3700_spi *spi = spi_controller_get_devdata(host); > - > - clk_unprepare(spi->clk); Hi. No point in keeping an empty remove function. Drop the whole thing now there is nothing to do. Jonathan > } > > static struct platform_driver a3700_spi_driver = { _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2B15EE4993 for ; Tue, 22 Aug 2023 15:56:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+BBQ3cLmk3AypK03qhQvINPuKXieDWV86hChT+z6V9I=; b=rYOFuoautgN+lg N0xMygkLeSNdqrMFk3ACfN+l+bhg2vFbNLog61evr54q6aJmLyQ4EBBkna7sORb2EpyhGRqQ2opzX wpMsveQv9uP8iUOzayWmowKADECbgOox25l71S3/Q0vjc2GcrbyYDnMvqCeLlqXpJsFp9192BOjk1 sAm63ubjglU8WMRfnxpwFKRbu2wCF3vKkw+nJ4nEj+gFoBIslBRJGhvQzeWHAidwOcZkXMsDp92tC PcPRoCkOEztU0C2jJLyxYi/194Qh8zjWUhXPPlSNB4P2rM9b+s1VQYU4j72fLBgHUjgVeO0jFQPOu eXLWl9NeGLe3Kq6G+6gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qYTjY-00GQ2T-2Y; Tue, 22 Aug 2023 15:55:56 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qYTjW-00GQ17-2B; Tue, 22 Aug 2023 15:55:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=S2nWE3aQXFlKdqzDmsVrOKSeJqyIatEgKjU2+rJLr14=; b=h3LZMwRi//eYTY51C/zEUbk/KO Dho7q3CkJYHxVIdRK7/rrnp2+YNqLZsktupbQMebaIvDmYa2YpqGHA+7yqU06Kk5vULxXH6q5Yu7c TShQ8Zjh3ocqJrA+BI2sDEi0aCjfHO5B09W19cbvlWyOfjnwbBfXDn3fcId9awHN6fr2zKv0iRjTN E+mdjMh1TTg7K1Qe9lTSxVSkwrpC/pq/aA8jTZtrU1bpNAI/guBoyXTppDH//j0Fa7aGkIaJGb+I4 yVR8i++m+9VzLZYOu0ehN0C7gdOllVaqbLI3wHpp0GLVWL09SwiXkydAgQW5n1LXP7EOnzd2lOfbT PyTaKutA==; Received: from frasgout.his.huawei.com ([185.176.79.56]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qYTjR-002rSb-0Q; Tue, 22 Aug 2023 15:55:53 +0000 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RVYnd4n4Yz6D8d1; Tue, 22 Aug 2023 23:54:45 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 22 Aug 2023 16:55:25 +0100 Date: Tue, 22 Aug 2023 16:55:24 +0100 From: Jonathan Cameron To: Li Zetao CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH -next 02/25] spi: armada-3700: Use helper function devm_clk_get_prepared() Message-ID: <20230822165524.000062a8@Huawei.com> In-Reply-To: <20230822131237.1022815-3-lizetao1@huawei.com> References: <20230822131237.1022815-1-lizetao1@huawei.com> <20230822131237.1022815-3-lizetao1@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230822_165549_254497_F2D4CCAF X-CRM114-Status: UNSURE ( 6.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > @@ -909,10 +901,6 @@ static int a3700_spi_probe(struct platform_device *pdev) > > static void a3700_spi_remove(struct platform_device *pdev) > { > - struct spi_controller *host = platform_get_drvdata(pdev); > - struct a3700_spi *spi = spi_controller_get_devdata(host); > - > - clk_unprepare(spi->clk); Hi. No point in keeping an empty remove function. Drop the whole thing now there is nothing to do. Jonathan > } > > static struct platform_driver a3700_spi_driver = { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel