From: Tom Rini <trini@konsulko.com>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: u-boot@lists.denx.de,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>,
Bin Meng <bmeng.cn@gmail.com>,
Heinrich Schuchardt <xypron.glplk@gmx.de>,
Joshua Watt <jpewhacker@gmail.com>,
Michal Suchanek <msuchanek@suse.de>,
Simon Glass <sjg@chromium.org>,
Tobias Waldekranz <tobias@waldekranz.com>
Subject: Re: [PATCH 3/8] disk: Simplify disk_blk_{write, erase}() using blk_{write, erase}()
Date: Wed, 23 Aug 2023 10:42:10 -0400 [thread overview]
Message-ID: <20230823144210.GU3953269@bill-the-cat> (raw)
In-Reply-To: <20230813234648.591083-3-marek.vasut+renesas@mailbox.org>
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
On Mon, Aug 14, 2023 at 01:46:43AM +0200, Marek Vasut wrote:
> These two functions are basically identical, just call the blk_*()
> functions from disk_blk_*() functions. The only difference is that
> the disk_blk_*() functions have to use parent block device as the
> udevice implementing block device operations.
>
> Add documentation on what those functions really do. The documentation
> is not wrong even though it likely does look that way. The write/erase
> functions really do not take into account the partition offset. This
> will be fixed in the next patch.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-08-23 14:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 23:46 [PATCH 1/8] disk: Drop always true conditional check Marek Vasut
2023-08-13 23:46 ` [PATCH 2/8] disk: Simplify disk_blk_read() using blk_read() Marek Vasut
2023-08-23 14:42 ` Tom Rini
2023-08-13 23:46 ` [PATCH 3/8] disk: Simplify disk_blk_{write, erase}() using blk_{write, erase}() Marek Vasut
2023-08-23 14:42 ` Tom Rini [this message]
2023-08-13 23:46 ` [PATCH 4/8] disk: Handle partition to block device offset conversion Marek Vasut
2023-08-23 14:42 ` Tom Rini
2023-08-13 23:46 ` [PATCH 5/8] disk: Extend disk_blk_part_validate() with range checking Marek Vasut
2023-08-23 14:42 ` Tom Rini
2023-08-13 23:46 ` [PATCH 6/8] disk: Switch part_blk_*() functions to disk_blk_*() Marek Vasut
2023-08-23 14:42 ` Tom Rini
2023-08-13 23:46 ` [PATCH 7/8] disk: Move part_create_block_devices() to blk uclass Marek Vasut
2023-08-23 14:42 ` Tom Rini
2023-08-13 23:46 ` [PATCH 8/8] disk: Make blk_get_ops() internal " Marek Vasut
2023-08-14 22:42 ` Simon Glass
2023-08-15 0:31 ` AKASHI Takahiro
2023-08-15 8:24 ` Marek Vasut
2023-08-23 14:42 ` Tom Rini
2023-08-23 14:42 ` [PATCH 1/8] disk: Drop always true conditional check Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230823144210.GU3953269@bill-the-cat \
--to=trini@konsulko.com \
--cc=abdellatif.elkhlifi@arm.com \
--cc=bmeng.cn@gmail.com \
--cc=jpewhacker@gmail.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=msuchanek@suse.de \
--cc=sjg@chromium.org \
--cc=takahiro.akashi@linaro.org \
--cc=tobias@waldekranz.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glplk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.