From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Xiao Ni <xni@redhat.com>, linux-raid@vger.kernel.org
Cc: jes@trained-monkey.org
Subject: Re: [PATCH 1/1] Stop mdcheck_continue timer when mdcheck_start service can finish check
Date: Wed, 23 Aug 2023 16:09:05 +0200 [thread overview]
Message-ID: <20230823160905.00004d3c@linux.intel.com> (raw)
In-Reply-To: <20230508133010.42313-1-xni@redhat.com>
Hi Xiao,
some nits:
On Mon, 8 May 2023 21:30:10 +0800
Xiao Ni <xni@redhat.com> wrote:
> mdcheck_continue is triggered by mdcheck_start timer. It's used to
> continue check action if the raid is too big and mdcheck_start
> service can't finish check action. If mdcheck start can finish check
> action, it doesn't need to mdcheck continue service anymore. So stop
> it when mdcheck start service can finish check action.
>
> Signed-off-by: Xiao Ni <xni@redhat.com>
> ---
> misc/mdcheck | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/misc/mdcheck b/misc/mdcheck
> index 700c3e252e72..f56972c8ed10 100644
> --- a/misc/mdcheck
> +++ b/misc/mdcheck
> @@ -140,7 +140,13 @@ do
> echo $a > $fl
> any=yes
> done
> - if [ -z "$any" ]; then exit 0; fi
> + if [ -z "$any" ]; then
> + #mdcheck_continue.timer is started by mdcheck_start.timer.
> + #When he check action can be finished in
's/he/the/g'
I think that there should be space after '#' but it is preferred to use /* */
Could you please send v2?
Thanks,
Mariusz
next prev parent reply other threads:[~2023-08-23 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 13:30 [PATCH 1/1] Stop mdcheck_continue timer when mdcheck_start service can finish check Xiao Ni
2023-08-23 14:09 ` Mariusz Tkaczyk [this message]
2023-08-25 9:00 ` Xiao Ni
2023-08-25 9:57 ` Mariusz Tkaczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230823160905.00004d3c@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=jes@trained-monkey.org \
--cc=linux-raid@vger.kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.