Re: [PATCH 3/3] hugetlb: Convert remove_pool_huge_page() to return a folio

[Mike Kravetz <mike.kravetz@oracle.com>]

On 08/22/23 17:28, Matthew Wilcox (Oracle) wrote:
> Convert the callers to expect a folio and remove the unnecesary conversion
> back to a struct page.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Cc: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
>  mm/hugetlb.c | 25 +++++++++++++------------
>  1 file changed, 13 insertions(+), 12 deletions(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index d6309edb59e5..283cd5290515 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -2221,9 +2221,8 @@ static int alloc_pool_huge_page(struct hstate *h, nodemask_t *nodes_allowed,
>   * an additional call to free the page to low level allocators.
>   * Called with hugetlb_lock locked.
>   */
> -static struct page *remove_pool_huge_page(struct hstate *h,
> -						nodemask_t *nodes_allowed,
> -						 bool acct_surplus)
> +static struct folio *remove_pool_huge_page(struct hstate *h,
> +		nodemask_t *nodes_allowed, bool acct_surplus)

might have been good to make a simple name change to remove_pool_huge_folio,
but not insisting.

Code looks fine,                                                                
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz