From: kernel test robot <lkp@intel.com>
To: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
Vlastimil Babka <vbabka@suse.cz>, Mel Gorman <mgorman@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] mm: page_alloc: consolidate free page accounting
Date: Thu, 24 Aug 2023 06:40:58 +0800 [thread overview]
Message-ID: <202308240628.YoW5rQTu-lkp@intel.com> (raw)
In-Reply-To: <20230821183733.106619-9-hannes@cmpxchg.org>
Hi Johannes,
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on v6.5-rc7]
[cannot apply to akpm-mm/mm-everything next-20230823]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Johannes-Weiner/mm-page_alloc-use-get_pfnblock_migratetype-where-pfn-available/20230822-024104
base: linus/master
patch link: https://lore.kernel.org/r/20230821183733.106619-9-hannes%40cmpxchg.org
patch subject: [PATCH 8/8] mm: page_alloc: consolidate free page accounting
config: x86_64-randconfig-075-20230823 (https://download.01.org/0day-ci/archive/20230824/202308240628.YoW5rQTu-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20230824/202308240628.YoW5rQTu-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308240628.YoW5rQTu-lkp@intel.com/
All errors (new ones prefixed by >>):
>> mm/page_alloc.c:6702:2: error: call to undeclared function '__mod_zone_freepage_state'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
__mod_zone_freepage_state(zone, -MAX_ORDER_NR_PAGES, MIGRATE_MOVABLE);
^
mm/page_alloc.c:6702:2: note: did you mean '__mod_zone_page_state'?
include/linux/vmstat.h:319:20: note: '__mod_zone_page_state' declared here
static inline void __mod_zone_page_state(struct zone *zone,
^
mm/page_alloc.c:6754:2: error: call to undeclared function '__mod_zone_freepage_state'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
__mod_zone_freepage_state(zone, MAX_ORDER_NR_PAGES, MIGRATE_MOVABLE);
^
2 errors generated.
vim +/__mod_zone_freepage_state +6702 mm/page_alloc.c
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6681
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6682 static bool try_to_accept_memory_one(struct zone *zone)
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6683 {
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6684 unsigned long flags;
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6685 struct page *page;
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6686 bool last;
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6687
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6688 if (list_empty(&zone->unaccepted_pages))
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6689 return false;
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6690
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6691 spin_lock_irqsave(&zone->lock, flags);
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6692 page = list_first_entry_or_null(&zone->unaccepted_pages,
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6693 struct page, lru);
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6694 if (!page) {
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6695 spin_unlock_irqrestore(&zone->lock, flags);
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6696 return false;
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6697 }
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6698
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6699 list_del(&page->lru);
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6700 last = list_empty(&zone->unaccepted_pages);
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6701
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 @6702 __mod_zone_freepage_state(zone, -MAX_ORDER_NR_PAGES, MIGRATE_MOVABLE);
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6703 __mod_zone_page_state(zone, NR_UNACCEPTED, -MAX_ORDER_NR_PAGES);
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6704 spin_unlock_irqrestore(&zone->lock, flags);
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6705
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6706 accept_page(page, MAX_ORDER);
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6707
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6708 __free_pages_ok(page, MAX_ORDER, FPI_TO_TAIL);
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6709
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6710 if (last)
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6711 static_branch_dec(&zones_with_unaccepted_pages);
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6712
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6713 return true;
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6714 }
dcdfdd40fa82b6 Kirill A. Shutemov 2023-06-06 6715
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-08-23 22:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 18:33 [PATCH 0/8] mm: page_alloc: freelist migratetype hygiene Johannes Weiner
2023-08-21 18:33 ` [PATCH 1/8] mm: page_alloc: use get_pfnblock_migratetype where pfn available Johannes Weiner
2023-08-21 20:14 ` Zi Yan
2023-08-21 20:29 ` Zi Yan
2023-08-21 21:22 ` Johannes Weiner
2023-08-21 18:33 ` [PATCH 2/8] mm: page_alloc: remove pcppage migratetype caching Johannes Weiner
2023-08-21 18:33 ` [PATCH 3/8] mm: page_alloc: fix highatomic landing on the wrong buddy list Johannes Weiner
2023-08-21 18:33 ` [PATCH 4/8] mm: page_alloc: fix up block types when merging compatible blocks Johannes Weiner
2023-08-21 20:41 ` Zi Yan
2023-08-21 21:20 ` Johannes Weiner
2023-08-21 18:33 ` [PATCH 5/8] mm: page_alloc: move free pages when converting block during isolation Johannes Weiner
2023-08-21 18:33 ` [PATCH 6/8] mm: page_alloc: fix move_freepages_block() range error Johannes Weiner
2023-08-21 18:33 ` [PATCH 7/8] mm: page_alloc: fix freelist movement during block conversion Johannes Weiner
2023-08-21 18:33 ` [PATCH 8/8] mm: page_alloc: consolidate free page accounting Johannes Weiner
2023-08-23 22:40 ` kernel test robot [this message]
2023-08-24 1:34 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308240628.YoW5rQTu-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=mgorman@suse.de \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.