From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F2E7C3DA6F for ; Thu, 24 Aug 2023 15:20:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240232AbjHXPTp (ORCPT ); Thu, 24 Aug 2023 11:19:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240809AbjHXPTi (ORCPT ); Thu, 24 Aug 2023 11:19:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2643E19B0 for ; Thu, 24 Aug 2023 08:19:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B06ED63215 for ; Thu, 24 Aug 2023 15:19:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAF29C433C8; Thu, 24 Aug 2023 15:19:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692890376; bh=dL3ZaFMplj04rQ1P0eBC8h0GfaGizXbacoBeHW6QBtg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KTBHpHJcJh7WMe+3/yaSQLKzhKc02PMLBrtWxvSsLPHSUKNZfZmk3PkydjI/6XIVQ zmzK5QVRkY5PWnPNqyLvRnyhcifSIGexJXLRTLoXDw4elfYQLYeclgQhqhYsK/tCRE z3VXVwUJuRyNFpIxBS47THayTjvqgXXJrZU4qKFpxalm51nCpF6ms48M5hRJ1fq80J OHXbkkDZrHidHpDkTf1b0ZqH46D0POSDP1wbqtDnD4adFeY21X2mUFD0g1ExZqhWGQ v57YFjsz87x2PB1987p75GfBUkNHpuOdYCQFfg4fIIIhYA2pWheygSpLHqV8lqiilp aS7I5hDEsccXA== Date: Thu, 24 Aug 2023 08:19:34 -0700 From: Jakub Kicinski To: Hariprasad Kelam Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "davem@davemloft.net" , Sunil Kovvuri Goutham , Geethasowjanya Akula , Jerin Jacob Kollanukkaran , Linu Cherian , Subbaraya Sundeep Bhatta , Naveen Mamindlapalli , "edumazet@google.com" , "pabeni@redhat.com" Subject: Re: [net-next Patch 4/5] octeontx2-af: replace generic error codes Message-ID: <20230824081934.39523fab@kernel.org> In-Reply-To: References: <20230817112357.25874-1-hkelam@marvell.com> <20230817112357.25874-5-hkelam@marvell.com> <20230818195041.1fd54fb3@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Aug 2023 05:41:01 +0000 Hariprasad Kelam wrote: > > > The custom error codes are not liked upstream, they make much harder > > > for people who don't work on the driver to refactor it. > > > > > > If you want debugging isn't it better to add a tracepoint to the checks? > > > > Hari>> These error codes are added in AF mailbox handlers, user space tools > > like ethool ,tc won't see these since these are between pf netdev and AF. > > During netdev driver probe/open calls, it requests AF driver to configure > > different hardware blocks MAC/network etc. If there is any error instead of > > getting EPERM, we will get block specific error codes like > > LMAC_AF_ERR_INVALID_PARAM, NIX_AF_ERR_PARAM etc. > > Jakub, > Any comments here? Please learn how to use email correctly. Hari>> Makes the entire line rendered as a quote in many email clients, because the gt than sign is a quote marker. You should also wrap your lines. If you want to return the block which failed to the caller you can do that, but not instead of the error code.