From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4F15C3DA6F for ; Thu, 24 Aug 2023 12:07:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 347F010E51C; Thu, 24 Aug 2023 12:07:49 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8DE1B10E520; Thu, 24 Aug 2023 12:07:47 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D1EE8622C0; Thu, 24 Aug 2023 12:07:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 493D8C433C8; Thu, 24 Aug 2023 12:07:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692878866; bh=XGcUYxKeus/elTOoo1TjZur2p/AUG6A2tJIcsd6tkeY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rsSVe7TgROYG1eWOt5xc+RTZFGzWVP57WTUrt7RVc1v7xwhiWcgSchrbaVPEI+2tI n1Rh4UbOh+Ln4e6fL5ZMoOetp8KgWCwOiMLCOs+IylzDhL8RApvllbJXgiZ3GdpL8U i1Z2IbTVQmipwBnz/wmvTxRx68NKj7igKU3SNfFwkoxeaMxIB+khZboENPg/rHmz9K GBDYsOifsqOPM6DfahgDS1+TmELqmdew1kTvyVkejTiq4r9p540lLTO3unNGYRWzdT clXGNzTBHyFZYghbE3br+BXurpvs1+DgMi3cDunaFl0t2ZI2Kh5D2hn+HiySfUC00i pLn15gYif2/8g== Date: Thu, 24 Aug 2023 13:07:35 +0100 From: Lee Jones To: Jani Nikula Subject: Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU Message-ID: <20230824120735.GS1380343@google.com> References: <20230824073710.2677348-1-lee@kernel.org> <87wmxk4xt3.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87wmxk4xt3.fsf@intel.com> X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karol Herbst , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Mikko Perttunen , =?iso-8859-1?Q?Ma=EDra?= Canal , Thierry Reding , Laurent Pinchart , Sumit Semwal , Shashank Sharma , Michal Simek , amd-gfx@lists.freedesktop.org, Jonathan Hunter , Luben Tuikov , Danilo Krummrich , Ben Skeggs , Stanley Yang , linux-media@vger.kernel.org, Thomas Zimmermann , Sascha Hauer , Maxime Ripard , linaro-mm-sig@lists.linaro.org, linux-tegra@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, Hyun Kwon , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Hawking Zhang , Jerome Glisse , Pengutronix Kernel Team , Alex Deucher , Gourav Samaiya , Shawn Guo , Christian =?iso-8859-1?Q?K=F6nig?= , Mario Limonciello Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Thu, 24 Aug 2023, Jani Nikula wrote: > On Thu, 24 Aug 2023, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > The next question is, how do we keep it W=1 clean going forward? My plan was to fix them all, then move each warning to W=0. Arnd recently submitted a set doing just that for a bunch of them. https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/ I like to think a bunch of this is built on top of my previous efforts. GPU is a particularly tricky though - the warnings seem to come in faster than I can squash them. Maybe the maintainers can find a way to test new patches on merge? > Most people don't use W=1 because it's too noisy, so it's a bit of a > catch-22. > > In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our > Makefile. For CI/developer use we also enable kernel-doc warnings by > default. > > Should we start enabling some of those warning flags in drm/Makefile to > to keep the entire subsystem warning free? That would we awesome! We'd just need buy-in. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 694D7C7113B for ; Thu, 24 Aug 2023 12:08:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232918AbjHXMIT (ORCPT ); Thu, 24 Aug 2023 08:08:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232697AbjHXMHt (ORCPT ); Thu, 24 Aug 2023 08:07:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41F1CE7D; Thu, 24 Aug 2023 05:07:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D206A64348; Thu, 24 Aug 2023 12:07:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 493D8C433C8; Thu, 24 Aug 2023 12:07:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692878866; bh=XGcUYxKeus/elTOoo1TjZur2p/AUG6A2tJIcsd6tkeY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rsSVe7TgROYG1eWOt5xc+RTZFGzWVP57WTUrt7RVc1v7xwhiWcgSchrbaVPEI+2tI n1Rh4UbOh+Ln4e6fL5ZMoOetp8KgWCwOiMLCOs+IylzDhL8RApvllbJXgiZ3GdpL8U i1Z2IbTVQmipwBnz/wmvTxRx68NKj7igKU3SNfFwkoxeaMxIB+khZboENPg/rHmz9K GBDYsOifsqOPM6DfahgDS1+TmELqmdew1kTvyVkejTiq4r9p540lLTO3unNGYRWzdT clXGNzTBHyFZYghbE3br+BXurpvs1+DgMi3cDunaFl0t2ZI2Kh5D2hn+HiySfUC00i pLn15gYif2/8g== Date: Thu, 24 Aug 2023 13:07:35 +0100 From: Lee Jones To: Jani Nikula Cc: Karol Herbst , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Mikko Perttunen , =?iso-8859-1?Q?Ma=EDra?= Canal , Thierry Reding , Laurent Pinchart , Sumit Semwal , Mario Limonciello , Shashank Sharma , Michal Simek , amd-gfx@lists.freedesktop.org, Jonathan Hunter , Luben Tuikov , Danilo Krummrich , Ben Skeggs , linux-media@vger.kernel.org, Stanley Yang , Pengutronix Kernel Team , Sascha Hauer , Maxime Ripard , linaro-mm-sig@lists.linaro.org, linux-tegra@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, Hyun Kwon , Thomas Zimmermann , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Jerome Glisse , Alex Deucher , Gourav Samaiya , Shawn Guo , Christian =?iso-8859-1?Q?K=F6nig?= , Hawking Zhang Subject: Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU Message-ID: <20230824120735.GS1380343@google.com> References: <20230824073710.2677348-1-lee@kernel.org> <87wmxk4xt3.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87wmxk4xt3.fsf@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Thu, 24 Aug 2023, Jani Nikula wrote: > On Thu, 24 Aug 2023, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > The next question is, how do we keep it W=1 clean going forward? My plan was to fix them all, then move each warning to W=0. Arnd recently submitted a set doing just that for a bunch of them. https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/ I like to think a bunch of this is built on top of my previous efforts. GPU is a particularly tricky though - the warnings seem to come in faster than I can squash them. Maybe the maintainers can find a way to test new patches on merge? > Most people don't use W=1 because it's too noisy, so it's a bit of a > catch-22. > > In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our > Makefile. For CI/developer use we also enable kernel-doc warnings by > default. > > Should we start enabling some of those warning flags in drm/Makefile to > to keep the entire subsystem warning free? That would we awesome! We'd just need buy-in. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F34BCC3DA6F for ; Thu, 24 Aug 2023 12:07:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7145310E523; Thu, 24 Aug 2023 12:07:49 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8DE1B10E520; Thu, 24 Aug 2023 12:07:47 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D1EE8622C0; Thu, 24 Aug 2023 12:07:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 493D8C433C8; Thu, 24 Aug 2023 12:07:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692878866; bh=XGcUYxKeus/elTOoo1TjZur2p/AUG6A2tJIcsd6tkeY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rsSVe7TgROYG1eWOt5xc+RTZFGzWVP57WTUrt7RVc1v7xwhiWcgSchrbaVPEI+2tI n1Rh4UbOh+Ln4e6fL5ZMoOetp8KgWCwOiMLCOs+IylzDhL8RApvllbJXgiZ3GdpL8U i1Z2IbTVQmipwBnz/wmvTxRx68NKj7igKU3SNfFwkoxeaMxIB+khZboENPg/rHmz9K GBDYsOifsqOPM6DfahgDS1+TmELqmdew1kTvyVkejTiq4r9p540lLTO3unNGYRWzdT clXGNzTBHyFZYghbE3br+BXurpvs1+DgMi3cDunaFl0t2ZI2Kh5D2hn+HiySfUC00i pLn15gYif2/8g== Date: Thu, 24 Aug 2023 13:07:35 +0100 From: Lee Jones To: Jani Nikula Message-ID: <20230824120735.GS1380343@google.com> References: <20230824073710.2677348-1-lee@kernel.org> <87wmxk4xt3.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87wmxk4xt3.fsf@intel.com> Subject: Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Mikko Perttunen , =?iso-8859-1?Q?Ma=EDra?= Canal , Thierry Reding , Laurent Pinchart , Sumit Semwal , Shashank Sharma , Michal Simek , amd-gfx@lists.freedesktop.org, Luben Tuikov , Ben Skeggs , Stanley Yang , linux-media@vger.kernel.org, Sascha Hauer , Maxime Ripard , linaro-mm-sig@lists.linaro.org, linux-tegra@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, Hyun Kwon , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Hawking Zhang , Jerome Glisse , Pengutronix Kernel Team , Alex Deucher , Gourav Samaiya , Shawn Guo , Christian =?iso-8859-1?Q?K=F6nig?= , Mario Limonciello Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Thu, 24 Aug 2023, Jani Nikula wrote: > On Thu, 24 Aug 2023, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > The next question is, how do we keep it W=1 clean going forward? My plan was to fix them all, then move each warning to W=0. Arnd recently submitted a set doing just that for a bunch of them. https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/ I like to think a bunch of this is built on top of my previous efforts. GPU is a particularly tricky though - the warnings seem to come in faster than I can squash them. Maybe the maintainers can find a way to test new patches on merge? > Most people don't use W=1 because it's too noisy, so it's a bit of a > catch-22. > > In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our > Makefile. For CI/developer use we also enable kernel-doc warnings by > default. > > Should we start enabling some of those warning flags in drm/Makefile to > to keep the entire subsystem warning free? That would we awesome! We'd just need buy-in. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2DC5C6FA8F for ; Thu, 24 Aug 2023 12:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LvE8Jb5Z7fVQ+5a+L2qAh6xCntYc5uXl6OBaM8fChgM=; b=d2KzGaIsZc69Ej GQnogUOmQC4uWAtk1V8+5/NrAciyEi2BeayETnGVqfoFwrCQUIHVd6RVvxwx1I1Dv0gCvR+4VJKDt UjPksQY9rYYAwIQ48KWXsopty2z1eZ2WMoZet0xfIulJpDY6kUGrx7EkJmx/MIKciyHr2Bl28lKPT r8m08B8nwx+NTq52z1Dcmz0j9DpVRLFnqdYskApDXRbUjodGkheCoy7hzHwUh6NLgrEixQtKAtbxU EkddZPsefZEced1Nlyoe20IOxJdJ7OpdPSJqP2ms8lVOpowebD1WcepT9ohfvB+dOSdvUni+iRznq pEOYziStnGZBnK7j9oJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qZ97u-00325B-1y; Thu, 24 Aug 2023 12:07:50 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qZ97r-00324o-1k for linux-arm-kernel@lists.infradead.org; Thu, 24 Aug 2023 12:07:48 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D1EE8622C0; Thu, 24 Aug 2023 12:07:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 493D8C433C8; Thu, 24 Aug 2023 12:07:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692878866; bh=XGcUYxKeus/elTOoo1TjZur2p/AUG6A2tJIcsd6tkeY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rsSVe7TgROYG1eWOt5xc+RTZFGzWVP57WTUrt7RVc1v7xwhiWcgSchrbaVPEI+2tI n1Rh4UbOh+Ln4e6fL5ZMoOetp8KgWCwOiMLCOs+IylzDhL8RApvllbJXgiZ3GdpL8U i1Z2IbTVQmipwBnz/wmvTxRx68NKj7igKU3SNfFwkoxeaMxIB+khZboENPg/rHmz9K GBDYsOifsqOPM6DfahgDS1+TmELqmdew1kTvyVkejTiq4r9p540lLTO3unNGYRWzdT clXGNzTBHyFZYghbE3br+BXurpvs1+DgMi3cDunaFl0t2ZI2Kh5D2hn+HiySfUC00i pLn15gYif2/8g== Date: Thu, 24 Aug 2023 13:07:35 +0100 From: Lee Jones To: Jani Nikula Cc: Karol Herbst , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Mikko Perttunen , =?iso-8859-1?Q?Ma=EDra?= Canal , Thierry Reding , Laurent Pinchart , Sumit Semwal , Mario Limonciello , Shashank Sharma , Michal Simek , amd-gfx@lists.freedesktop.org, Jonathan Hunter , Luben Tuikov , Danilo Krummrich , Ben Skeggs , linux-media@vger.kernel.org, Stanley Yang , Pengutronix Kernel Team , Sascha Hauer , Maxime Ripard , linaro-mm-sig@lists.linaro.org, linux-tegra@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, Hyun Kwon , Thomas Zimmermann , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Jerome Glisse , Alex Deucher , Gourav Samaiya , Shawn Guo , Christian =?iso-8859-1?Q?K=F6nig?= , Hawking Zhang Subject: Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU Message-ID: <20230824120735.GS1380343@google.com> References: <20230824073710.2677348-1-lee@kernel.org> <87wmxk4xt3.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87wmxk4xt3.fsf@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230824_050747_669250_EECC1C98 X-CRM114-Status: GOOD ( 19.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyNCBBdWcgMjAyMywgSmFuaSBOaWt1bGEgd3JvdGU6Cgo+IE9uIFRodSwgMjQgQXVn IDIwMjMsIExlZSBKb25lcyA8bGVlQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gVGhpcyBzZXQgaXMg cGFydCBvZiBhIGxhcmdlciBlZmZvcnQgYXR0ZW1wdGluZyB0byBjbGVhbi11cCBXPTEKPiA+IGtl cm5lbCBidWlsZHMsIHdoaWNoIGFyZSBjdXJyZW50bHkgb3ZlcndoZWxtaW5nbHkgcmlkZGxlZCB3 aXRoCj4gPiBuaWdnbHkgbGl0dGxlIHdhcm5pbmdzLgo+IAo+IFRoZSBuZXh0IHF1ZXN0aW9uIGlz LCBob3cgZG8gd2Uga2VlcCBpdCBXPTEgY2xlYW4gZ29pbmcgZm9yd2FyZD8KCk15IHBsYW4gd2Fz IHRvIGZpeCB0aGVtIGFsbCwgdGhlbiBtb3ZlIGVhY2ggd2FybmluZyB0byBXPTAuCgpBcm5kIHJl Y2VudGx5IHN1Ym1pdHRlZCBhIHNldCBkb2luZyBqdXN0IHRoYXQgZm9yIGEgYnVuY2ggb2YgdGhl bS4KCmh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC8yMDIzMDgxMTE0MDMyNy4zNzU0NTk3LTEt YXJuZEBrZXJuZWwub3JnLwoKSSBsaWtlIHRvIHRoaW5rIGEgYnVuY2ggb2YgdGhpcyBpcyBidWls dCBvbiB0b3Agb2YgbXkgcHJldmlvdXMgZWZmb3J0cy4KCkdQVSBpcyBhIHBhcnRpY3VsYXJseSB0 cmlja3kgdGhvdWdoIC0gdGhlIHdhcm5pbmdzIHNlZW0gdG8gY29tZSBpbiBmYXN0ZXIKdGhhbiBJ IGNhbiBzcXVhc2ggdGhlbS4gIE1heWJlIHRoZSBtYWludGFpbmVycyBjYW4gZmluZCBhIHdheSB0 byB0ZXN0Cm5ldyBwYXRjaGVzIG9uIG1lcmdlPwoKPiBNb3N0IHBlb3BsZSBkb24ndCB1c2UgVz0x IGJlY2F1c2UgaXQncyB0b28gbm9pc3ksIHNvIGl0J3MgYSBiaXQgb2YgYQo+IGNhdGNoLTIyLgo+ IAo+IEluIGk5MTUsIHdlIGVuYWJsZSBhIGxvdCBvZiBXPTEgd2FybmluZ3MgdXNpbmcgc3ViZGly LWNjZmxhZ3MteSBpbiBvdXIKPiBNYWtlZmlsZS4gRm9yIENJL2RldmVsb3BlciB1c2Ugd2UgYWxz byBlbmFibGUga2VybmVsLWRvYyB3YXJuaW5ncyBieQo+IGRlZmF1bHQuCj4gCj4gU2hvdWxkIHdl IHN0YXJ0IGVuYWJsaW5nIHNvbWUgb2YgdGhvc2Ugd2FybmluZyBmbGFncyBpbiBkcm0vTWFrZWZp bGUgdG8KPiB0byBrZWVwIHRoZSBlbnRpcmUgc3Vic3lzdGVtIHdhcm5pbmcgZnJlZT8KClRoYXQg d291bGQgd2UgYXdlc29tZSEgIFdlJ2QganVzdCBuZWVkIGJ1eS1pbi4KCi0tIApMZWUgSm9uZXMg W+adjueQvOaWr10KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK