From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AABFC3DA6F for ; Thu, 24 Aug 2023 12:24:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0401610E544; Thu, 24 Aug 2023 12:24:16 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 06B7410E541; Thu, 24 Aug 2023 12:24:13 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5DFEA60C4F; Thu, 24 Aug 2023 12:24:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC2CBC433C7; Thu, 24 Aug 2023 12:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692879851; bh=rXHeHAFXjN/zA3rYC/1HhA1l11PWkd2Qvj22VCRsCGs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CqOlaS/QfUs5XXJTiSG68eVAETcwld0Oyyw2XmGw3vbPcDbOEpspeApsyEBSY0lzY BJl4NEsEvECi0Fn66tjoluhCVVSbj/3Fe3eaBPUimBzycU6Ew02hPKbed/8je8CkRf 1+WsWnIyZzbwSlIn/6j5RP45+CkV50Bn18C+mlY07Wd9kkPeHC9Xv+VQYWAGMT8iqG LXQzMPYXHDBPiYetArnubErS0XhVoCULd5vNPc0T7OZ+5eZRVXxQpCJkyh5R3oVYEa qX2bk7/9/M9K5EutOOlmwBQ30zkp0qc/t1PRSgiuL+KJDx47ih8QPQIzlYGQ4Wflwi HyIl1AsJiWaIg== Date: Thu, 24 Aug 2023 13:24:01 +0100 From: Lee Jones To: Hamza Mahfooz Subject: Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU Message-ID: <20230824122401.GY1380343@google.com> References: <20230824073710.2677348-1-lee@kernel.org> <87wmxk4xt3.fsf@intel.com> <20230824120735.GS1380343@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karol Herbst , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Mikko Perttunen , =?iso-8859-1?Q?Ma=EDra?= Canal , Thierry Reding , Laurent Pinchart , Sumit Semwal , Mario Limonciello , Shashank Sharma , Michal Simek , amd-gfx@lists.freedesktop.org, Jonathan Hunter , Luben Tuikov , Danilo Krummrich , Ben Skeggs , Stanley Yang , linux-media@vger.kernel.org, Pengutronix Kernel Team , Sascha Hauer , Maxime Ripard , linaro-mm-sig@lists.linaro.org, Jani Nikula , linux-tegra@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, Hyun Kwon , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Jerome Glisse , Thomas Zimmermann , Alex Deucher , Gourav Samaiya , Shawn Guo , Christian =?iso-8859-1?Q?K=F6nig?= , Hawking Zhang Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Thu, 24 Aug 2023, Hamza Mahfooz wrote: > > On 8/24/23 08:07, Lee Jones wrote: > > On Thu, 24 Aug 2023, Jani Nikula wrote: > > > > > On Thu, 24 Aug 2023, Lee Jones wrote: > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhelmingly riddled with > > > > niggly little warnings. > > > > > > The next question is, how do we keep it W=1 clean going forward? > > > > My plan was to fix them all, then move each warning to W=0. > > > > Arnd recently submitted a set doing just that for a bunch of them. > > > > https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/ > > > > I like to think a bunch of this is built on top of my previous efforts. > > > > GPU is a particularly tricky though - the warnings seem to come in faster > > than I can squash them. Maybe the maintainers can find a way to test > > new patches on merge? > > I guess on that note, do you know if there is a way to run > `scripts/kernel-doc` on patches instead of whole files? That would make > much easier to block new kernel-doc issues from appearing. Not off hand. When I run builds on patches I author, I run them twice concurrently. Once on the commit I'm basing on and once on the HEAD of my patchset. I then diff the two. So as long as the number of errors and warnings stay the same or reduce, we're golden. Perhaps the same method could be used with `kernel-doc`? -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A96C7113B for ; Thu, 24 Aug 2023 12:25:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230384AbjHXMYe (ORCPT ); Thu, 24 Aug 2023 08:24:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233306AbjHXMYO (ORCPT ); Thu, 24 Aug 2023 08:24:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C886E10EF; Thu, 24 Aug 2023 05:24:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6654063388; Thu, 24 Aug 2023 12:24:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC2CBC433C7; Thu, 24 Aug 2023 12:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692879851; bh=rXHeHAFXjN/zA3rYC/1HhA1l11PWkd2Qvj22VCRsCGs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CqOlaS/QfUs5XXJTiSG68eVAETcwld0Oyyw2XmGw3vbPcDbOEpspeApsyEBSY0lzY BJl4NEsEvECi0Fn66tjoluhCVVSbj/3Fe3eaBPUimBzycU6Ew02hPKbed/8je8CkRf 1+WsWnIyZzbwSlIn/6j5RP45+CkV50Bn18C+mlY07Wd9kkPeHC9Xv+VQYWAGMT8iqG LXQzMPYXHDBPiYetArnubErS0XhVoCULd5vNPc0T7OZ+5eZRVXxQpCJkyh5R3oVYEa qX2bk7/9/M9K5EutOOlmwBQ30zkp0qc/t1PRSgiuL+KJDx47ih8QPQIzlYGQ4Wflwi HyIl1AsJiWaIg== Date: Thu, 24 Aug 2023 13:24:01 +0100 From: Lee Jones To: Hamza Mahfooz Cc: Jani Nikula , Karol Herbst , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Mikko Perttunen , =?iso-8859-1?Q?Ma=EDra?= Canal , Thierry Reding , Laurent Pinchart , Sumit Semwal , Shashank Sharma , Michal Simek , amd-gfx@lists.freedesktop.org, Jonathan Hunter , Luben Tuikov , Danilo Krummrich , Ben Skeggs , Stanley Yang , linux-media@vger.kernel.org, Thomas Zimmermann , Sascha Hauer , Maxime Ripard , linaro-mm-sig@lists.linaro.org, linux-tegra@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, Hyun Kwon , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Hawking Zhang , Jerome Glisse , Pengutronix Kernel Team , Alex Deucher , Gourav Samaiya , Shawn Guo , Christian =?iso-8859-1?Q?K=F6nig?= , Mario Limonciello Subject: Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU Message-ID: <20230824122401.GY1380343@google.com> References: <20230824073710.2677348-1-lee@kernel.org> <87wmxk4xt3.fsf@intel.com> <20230824120735.GS1380343@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Thu, 24 Aug 2023, Hamza Mahfooz wrote: > > On 8/24/23 08:07, Lee Jones wrote: > > On Thu, 24 Aug 2023, Jani Nikula wrote: > > > > > On Thu, 24 Aug 2023, Lee Jones wrote: > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhelmingly riddled with > > > > niggly little warnings. > > > > > > The next question is, how do we keep it W=1 clean going forward? > > > > My plan was to fix them all, then move each warning to W=0. > > > > Arnd recently submitted a set doing just that for a bunch of them. > > > > https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/ > > > > I like to think a bunch of this is built on top of my previous efforts. > > > > GPU is a particularly tricky though - the warnings seem to come in faster > > than I can squash them. Maybe the maintainers can find a way to test > > new patches on merge? > > I guess on that note, do you know if there is a way to run > `scripts/kernel-doc` on patches instead of whole files? That would make > much easier to block new kernel-doc issues from appearing. Not off hand. When I run builds on patches I author, I run them twice concurrently. Once on the commit I'm basing on and once on the HEAD of my patchset. I then diff the two. So as long as the number of errors and warnings stay the same or reduce, we're golden. Perhaps the same method could be used with `kernel-doc`? -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 503C3C6FA8F for ; Thu, 24 Aug 2023 12:24:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 946D810E543; Thu, 24 Aug 2023 12:24:15 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 06B7410E541; Thu, 24 Aug 2023 12:24:13 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5DFEA60C4F; Thu, 24 Aug 2023 12:24:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC2CBC433C7; Thu, 24 Aug 2023 12:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692879851; bh=rXHeHAFXjN/zA3rYC/1HhA1l11PWkd2Qvj22VCRsCGs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CqOlaS/QfUs5XXJTiSG68eVAETcwld0Oyyw2XmGw3vbPcDbOEpspeApsyEBSY0lzY BJl4NEsEvECi0Fn66tjoluhCVVSbj/3Fe3eaBPUimBzycU6Ew02hPKbed/8je8CkRf 1+WsWnIyZzbwSlIn/6j5RP45+CkV50Bn18C+mlY07Wd9kkPeHC9Xv+VQYWAGMT8iqG LXQzMPYXHDBPiYetArnubErS0XhVoCULd5vNPc0T7OZ+5eZRVXxQpCJkyh5R3oVYEa qX2bk7/9/M9K5EutOOlmwBQ30zkp0qc/t1PRSgiuL+KJDx47ih8QPQIzlYGQ4Wflwi HyIl1AsJiWaIg== Date: Thu, 24 Aug 2023 13:24:01 +0100 From: Lee Jones To: Hamza Mahfooz Message-ID: <20230824122401.GY1380343@google.com> References: <20230824073710.2677348-1-lee@kernel.org> <87wmxk4xt3.fsf@intel.com> <20230824120735.GS1380343@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Mikko Perttunen , =?iso-8859-1?Q?Ma=EDra?= Canal , Thierry Reding , Laurent Pinchart , Sumit Semwal , Mario Limonciello , Shashank Sharma , Michal Simek , amd-gfx@lists.freedesktop.org, Luben Tuikov , Ben Skeggs , Stanley Yang , linux-media@vger.kernel.org, Pengutronix Kernel Team , Sascha Hauer , Maxime Ripard , linaro-mm-sig@lists.linaro.org, Jani Nikula , linux-tegra@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, Hyun Kwon , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Jerome Glisse , Alex Deucher , Gourav Samaiya , Shawn Guo , Christian =?iso-8859-1?Q?K=F6nig?= , Hawking Zhang Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Thu, 24 Aug 2023, Hamza Mahfooz wrote: > > On 8/24/23 08:07, Lee Jones wrote: > > On Thu, 24 Aug 2023, Jani Nikula wrote: > > > > > On Thu, 24 Aug 2023, Lee Jones wrote: > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhelmingly riddled with > > > > niggly little warnings. > > > > > > The next question is, how do we keep it W=1 clean going forward? > > > > My plan was to fix them all, then move each warning to W=0. > > > > Arnd recently submitted a set doing just that for a bunch of them. > > > > https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/ > > > > I like to think a bunch of this is built on top of my previous efforts. > > > > GPU is a particularly tricky though - the warnings seem to come in faster > > than I can squash them. Maybe the maintainers can find a way to test > > new patches on merge? > > I guess on that note, do you know if there is a way to run > `scripts/kernel-doc` on patches instead of whole files? That would make > much easier to block new kernel-doc issues from appearing. Not off hand. When I run builds on patches I author, I run them twice concurrently. Once on the commit I'm basing on and once on the HEAD of my patchset. I then diff the two. So as long as the number of errors and warnings stay the same or reduce, we're golden. Perhaps the same method could be used with `kernel-doc`? -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D17DC6FA8F for ; Thu, 24 Aug 2023 12:24:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VQWzAtH3jw+fkTBjx1QPO7CxWmToH8cTNzlBIQsXuAQ=; b=RxeumV8Ro8C34K SAGUeX/oGVIOEAd+fnqOmFd/Vw/bQHuqK+s3YXuhItnaDCixVV/nj83QSqYa2ind/MHzIYj4k0eoE GZ5/e7a5TqHyv1NyloQuW9+qu4j8zCgTpxeBinxLXVC1Il8wXJ8N9sKJGSgEnRSY9LniVh+HNzLud /M8Y7qUMxq03gmrMhNIPQYdHoa6Nyr00z+s/dt5PAImJ948Jf2smbfuDwNqH9+1OzCc9MxpxC/ts3 AX2IFBEyEbFLghyESrRnwhp4cB4GzOeM+OnENUdU+h6hGq+ns1n2GLMHr6p2b6gSkUBNXB4zu6Ztb MPe415Tl/DKxZZc5S2xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qZ9Nn-0033Ep-33; Thu, 24 Aug 2023 12:24:15 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qZ9Nk-0033ER-2s for linux-arm-kernel@lists.infradead.org; Thu, 24 Aug 2023 12:24:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5DFEA60C4F; Thu, 24 Aug 2023 12:24:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC2CBC433C7; Thu, 24 Aug 2023 12:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692879851; bh=rXHeHAFXjN/zA3rYC/1HhA1l11PWkd2Qvj22VCRsCGs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CqOlaS/QfUs5XXJTiSG68eVAETcwld0Oyyw2XmGw3vbPcDbOEpspeApsyEBSY0lzY BJl4NEsEvECi0Fn66tjoluhCVVSbj/3Fe3eaBPUimBzycU6Ew02hPKbed/8je8CkRf 1+WsWnIyZzbwSlIn/6j5RP45+CkV50Bn18C+mlY07Wd9kkPeHC9Xv+VQYWAGMT8iqG LXQzMPYXHDBPiYetArnubErS0XhVoCULd5vNPc0T7OZ+5eZRVXxQpCJkyh5R3oVYEa qX2bk7/9/M9K5EutOOlmwBQ30zkp0qc/t1PRSgiuL+KJDx47ih8QPQIzlYGQ4Wflwi HyIl1AsJiWaIg== Date: Thu, 24 Aug 2023 13:24:01 +0100 From: Lee Jones To: Hamza Mahfooz Cc: Jani Nikula , Karol Herbst , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Mikko Perttunen , =?iso-8859-1?Q?Ma=EDra?= Canal , Thierry Reding , Laurent Pinchart , Sumit Semwal , Shashank Sharma , Michal Simek , amd-gfx@lists.freedesktop.org, Jonathan Hunter , Luben Tuikov , Danilo Krummrich , Ben Skeggs , Stanley Yang , linux-media@vger.kernel.org, Thomas Zimmermann , Sascha Hauer , Maxime Ripard , linaro-mm-sig@lists.linaro.org, linux-tegra@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, Hyun Kwon , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Hawking Zhang , Jerome Glisse , Pengutronix Kernel Team , Alex Deucher , Gourav Samaiya , Shawn Guo , Christian =?iso-8859-1?Q?K=F6nig?= , Mario Limonciello Subject: Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU Message-ID: <20230824122401.GY1380343@google.com> References: <20230824073710.2677348-1-lee@kernel.org> <87wmxk4xt3.fsf@intel.com> <20230824120735.GS1380343@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230824_052413_038442_6A2081AC X-CRM114-Status: GOOD ( 24.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyNCBBdWcgMjAyMywgSGFtemEgTWFoZm9veiB3cm90ZToKCj4gCj4gT24gOC8yNC8y MyAwODowNywgTGVlIEpvbmVzIHdyb3RlOgo+ID4gT24gVGh1LCAyNCBBdWcgMjAyMywgSmFuaSBO aWt1bGEgd3JvdGU6Cj4gPiAKPiA+ID4gT24gVGh1LCAyNCBBdWcgMjAyMywgTGVlIEpvbmVzIDxs ZWVAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPiA+ID4gVGhpcyBzZXQgaXMgcGFydCBvZiBhIGxhcmdl ciBlZmZvcnQgYXR0ZW1wdGluZyB0byBjbGVhbi11cCBXPTEKPiA+ID4gPiBrZXJuZWwgYnVpbGRz LCB3aGljaCBhcmUgY3VycmVudGx5IG92ZXJ3aGVsbWluZ2x5IHJpZGRsZWQgd2l0aAo+ID4gPiA+ IG5pZ2dseSBsaXR0bGUgd2FybmluZ3MuCj4gPiA+IAo+ID4gPiBUaGUgbmV4dCBxdWVzdGlvbiBp cywgaG93IGRvIHdlIGtlZXAgaXQgVz0xIGNsZWFuIGdvaW5nIGZvcndhcmQ/Cj4gPiAKPiA+IE15 IHBsYW4gd2FzIHRvIGZpeCB0aGVtIGFsbCwgdGhlbiBtb3ZlIGVhY2ggd2FybmluZyB0byBXPTAu Cj4gPiAKPiA+IEFybmQgcmVjZW50bHkgc3VibWl0dGVkIGEgc2V0IGRvaW5nIGp1c3QgdGhhdCBm b3IgYSBidW5jaCBvZiB0aGVtLgo+ID4gCj4gPiBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwv MjAyMzA4MTExNDAzMjcuMzc1NDU5Ny0xLWFybmRAa2VybmVsLm9yZy8KPiA+IAo+ID4gSSBsaWtl IHRvIHRoaW5rIGEgYnVuY2ggb2YgdGhpcyBpcyBidWlsdCBvbiB0b3Agb2YgbXkgcHJldmlvdXMg ZWZmb3J0cy4KPiA+IAo+ID4gR1BVIGlzIGEgcGFydGljdWxhcmx5IHRyaWNreSB0aG91Z2ggLSB0 aGUgd2FybmluZ3Mgc2VlbSB0byBjb21lIGluIGZhc3Rlcgo+ID4gdGhhbiBJIGNhbiBzcXVhc2gg dGhlbS4gIE1heWJlIHRoZSBtYWludGFpbmVycyBjYW4gZmluZCBhIHdheSB0byB0ZXN0Cj4gPiBu ZXcgcGF0Y2hlcyBvbiBtZXJnZT8KPiAKPiBJIGd1ZXNzIG9uIHRoYXQgbm90ZSwgZG8geW91IGtu b3cgaWYgdGhlcmUgaXMgYSB3YXkgdG8gcnVuCj4gYHNjcmlwdHMva2VybmVsLWRvY2Agb24gcGF0 Y2hlcyBpbnN0ZWFkIG9mIHdob2xlIGZpbGVzPyBUaGF0IHdvdWxkIG1ha2UKPiBtdWNoIGVhc2ll ciB0byBibG9jayBuZXcga2VybmVsLWRvYyBpc3N1ZXMgZnJvbSBhcHBlYXJpbmcuCgpOb3Qgb2Zm IGhhbmQuCgpXaGVuIEkgcnVuIGJ1aWxkcyBvbiBwYXRjaGVzIEkgYXV0aG9yLCBJIHJ1biB0aGVt IHR3aWNlIGNvbmN1cnJlbnRseS4KT25jZSBvbiB0aGUgY29tbWl0IEknbSBiYXNpbmcgb24gYW5k IG9uY2Ugb24gdGhlIEhFQUQgb2YgbXkgcGF0Y2hzZXQuICBJCnRoZW4gZGlmZiB0aGUgdHdvLiAg U28gYXMgbG9uZyBhcyB0aGUgbnVtYmVyIG9mIGVycm9ycyBhbmQgd2FybmluZ3Mgc3RheQp0aGUg c2FtZSBvciByZWR1Y2UsIHdlJ3JlIGdvbGRlbi4KClBlcmhhcHMgdGhlIHNhbWUgbWV0aG9kIGNv dWxkIGJlIHVzZWQgd2l0aCBga2VybmVsLWRvY2A/CgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9d CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06314C6FA8F for ; Thu, 24 Aug 2023 12:24:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5953810E542; Thu, 24 Aug 2023 12:24:15 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 06B7410E541; Thu, 24 Aug 2023 12:24:13 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5DFEA60C4F; Thu, 24 Aug 2023 12:24:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC2CBC433C7; Thu, 24 Aug 2023 12:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692879851; bh=rXHeHAFXjN/zA3rYC/1HhA1l11PWkd2Qvj22VCRsCGs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CqOlaS/QfUs5XXJTiSG68eVAETcwld0Oyyw2XmGw3vbPcDbOEpspeApsyEBSY0lzY BJl4NEsEvECi0Fn66tjoluhCVVSbj/3Fe3eaBPUimBzycU6Ew02hPKbed/8je8CkRf 1+WsWnIyZzbwSlIn/6j5RP45+CkV50Bn18C+mlY07Wd9kkPeHC9Xv+VQYWAGMT8iqG LXQzMPYXHDBPiYetArnubErS0XhVoCULd5vNPc0T7OZ+5eZRVXxQpCJkyh5R3oVYEa qX2bk7/9/M9K5EutOOlmwBQ30zkp0qc/t1PRSgiuL+KJDx47ih8QPQIzlYGQ4Wflwi HyIl1AsJiWaIg== Date: Thu, 24 Aug 2023 13:24:01 +0100 From: Lee Jones To: Hamza Mahfooz Subject: Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU Message-ID: <20230824122401.GY1380343@google.com> References: <20230824073710.2677348-1-lee@kernel.org> <87wmxk4xt3.fsf@intel.com> <20230824120735.GS1380343@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karol Herbst , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Mikko Perttunen , =?iso-8859-1?Q?Ma=EDra?= Canal , Thierry Reding , Laurent Pinchart , Sumit Semwal , Mario Limonciello , Shashank Sharma , Michal Simek , amd-gfx@lists.freedesktop.org, Jonathan Hunter , Luben Tuikov , Danilo Krummrich , Ben Skeggs , Stanley Yang , linux-media@vger.kernel.org, Pengutronix Kernel Team , Sascha Hauer , Maxime Ripard , linaro-mm-sig@lists.linaro.org, linux-tegra@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, Hyun Kwon , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Jerome Glisse , Thomas Zimmermann , Alex Deucher , Gourav Samaiya , Shawn Guo , Christian =?iso-8859-1?Q?K=F6nig?= , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 24 Aug 2023, Hamza Mahfooz wrote: > > On 8/24/23 08:07, Lee Jones wrote: > > On Thu, 24 Aug 2023, Jani Nikula wrote: > > > > > On Thu, 24 Aug 2023, Lee Jones wrote: > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhelmingly riddled with > > > > niggly little warnings. > > > > > > The next question is, how do we keep it W=1 clean going forward? > > > > My plan was to fix them all, then move each warning to W=0. > > > > Arnd recently submitted a set doing just that for a bunch of them. > > > > https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/ > > > > I like to think a bunch of this is built on top of my previous efforts. > > > > GPU is a particularly tricky though - the warnings seem to come in faster > > than I can squash them. Maybe the maintainers can find a way to test > > new patches on merge? > > I guess on that note, do you know if there is a way to run > `scripts/kernel-doc` on patches instead of whole files? That would make > much easier to block new kernel-doc issues from appearing. Not off hand. When I run builds on patches I author, I run them twice concurrently. Once on the commit I'm basing on and once on the HEAD of my patchset. I then diff the two. So as long as the number of errors and warnings stay the same or reduce, we're golden. Perhaps the same method could be used with `kernel-doc`? -- Lee Jones [李琼斯]