All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Jason Wang <jasowang@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
	qemu-ppc@nongnu.org
Subject: [PATCH 0/4] net: avoid variable length arrays
Date: Thu, 24 Aug 2023 16:32:20 +0100	[thread overview]
Message-ID: <20230824153224.2517486-1-peter.maydell@linaro.org> (raw)

This patchset removes the use of variable length arrays in a couple
of network devices and the net/ core code.  In one case we can switch
to a fixed-sized array on the stack; in the other three we have to
use a heap allocation.

The codebase has very few VLAs, and if we can get rid of them all we
can make the compiler error on new additions.  This is a defensive
measure against security bugs where an on-stack dynamic allocation
isn't correctly size-checked (e.g.  CVE-2021-3527).

Philippe had a go at these in  a patch in 2021:
https://patchew.org/QEMU/20210505211047.1496765-1-philmd@redhat.com/20210505211047.1496765-16-philmd@redhat.com/
but these are re-implementations, mostly.

Usual disclaimer: I have tested these patches only with
"make check" and "make check-avocado".

thanks
-- PMM

Peter Maydell (4):
  hw/net/fsl_etsec/rings.c: Avoid variable length array
  hw/net/rocker: Avoid variable length array
  net/dump: Avoid variable length array
  net/tap: Avoid variable-length array

 hw/net/fsl_etsec/rings.c      | 12 ++++++++++--
 hw/net/rocker/rocker_of_dpa.c |  2 +-
 net/dump.c                    |  2 +-
 net/tap.c                     |  3 ++-
 4 files changed, 14 insertions(+), 5 deletions(-)

-- 
2.34.1



             reply	other threads:[~2023-08-24 15:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24 15:32 Peter Maydell [this message]
2023-08-24 15:32 ` [PATCH 1/4] hw/net/fsl_etsec/rings.c: Avoid variable length array Peter Maydell
2023-08-24 15:47   ` Philippe Mathieu-Daudé
2023-08-24 16:01     ` Peter Maydell
2023-08-24 16:07       ` Philippe Mathieu-Daudé
2023-08-24 15:32 ` [PATCH 2/4] hw/net/rocker: " Peter Maydell
2023-08-25  7:55   ` Francisco Iglesias
2023-08-24 15:32 ` [PATCH 3/4] net/dump: " Peter Maydell
2023-08-25  7:57   ` Francisco Iglesias
2023-08-24 15:32 ` [PATCH 4/4] net/tap: Avoid variable-length array Peter Maydell
2023-08-25  7:57   ` Francisco Iglesias
2023-09-12 14:20 ` [PATCH 0/4] net: avoid variable length arrays Peter Maydell
2023-09-13  3:26   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230824153224.2517486-1-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=jasowang@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.