From: Jakub Kicinski <kuba@kernel.org>
To: "Nambiar, Amritha" <amritha.nambiar@intel.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<sridhar.samudrala@intel.com>
Subject: Re: [net-next PATCH v2 3/9] netdev-genl: spec: Extend netdev netlink spec in YAML for NAPI
Date: Thu, 24 Aug 2023 16:55:18 -0700 [thread overview]
Message-ID: <20230824165518.3002655f@kernel.org> (raw)
In-Reply-To: <bb43b222-eddb-47ea-a36e-84415227439e@intel.com>
On Thu, 24 Aug 2023 15:26:37 -0700 Nambiar, Amritha wrote:
> --do queue-get --json='{"q_index": 0, "q_type": RX}'
> {'q_index': 0, 'q_type': RX, 'ifindex': 12, 'napi-id': 385}
>
> As for queue-get, should we have a single queue object with a 'type'
> attribute for RX, TX, XDP etc. or should each of these queue types have
> their own distinct queue objects as they could have different attributes
> within.
Separate objects, I think.
The "key" for queues is a tuple of <type, id>.
e.g.
<Rx, 0>
<Tx, 0>
<XDP_Tx, 0>
are 3 different objects (feel free to start with just rx and tx,
we can add support for xdp queues later as needed).
next prev parent reply other threads:[~2023-08-24 23:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 23:25 [net-next PATCH v2 0/9] Introduce NAPI queues support Amritha Nambiar
2023-08-21 23:25 ` [net-next PATCH v2 1/9] net: Introduce new fields for napi and queue associations Amritha Nambiar
2023-08-21 23:25 ` [net-next PATCH v2 2/9] ice: Add support in the driver for associating napi with queue[s] Amritha Nambiar
2023-08-21 23:25 ` [net-next PATCH v2 3/9] netdev-genl: spec: Extend netdev netlink spec in YAML for NAPI Amritha Nambiar
2023-08-23 0:39 ` Jakub Kicinski
2023-08-24 0:46 ` Nambiar, Amritha
2023-08-24 1:34 ` Jakub Kicinski
2023-08-24 22:26 ` Nambiar, Amritha
2023-08-24 23:55 ` Jakub Kicinski [this message]
2023-08-21 23:25 ` [net-next PATCH v2 4/9] net: Move kernel helpers for queue index outside sysfs Amritha Nambiar
2023-08-23 0:40 ` Jakub Kicinski
2023-08-23 23:57 ` Nambiar, Amritha
2023-08-21 23:25 ` [net-next PATCH v2 5/9] netdev-genl: Add netlink framework functions for napi Amritha Nambiar
2023-08-23 0:51 ` Jakub Kicinski
2023-08-23 23:53 ` Nambiar, Amritha
2023-08-21 23:25 ` [net-next PATCH v2 6/9] netdev-genl: spec: Add irq in netdev netlink YAML spec Amritha Nambiar
2023-08-21 23:25 ` [net-next PATCH v2 7/9] net: Add NAPI IRQ support Amritha Nambiar
2023-08-23 0:52 ` Jakub Kicinski
2023-08-23 23:49 ` Nambiar, Amritha
2023-08-21 23:25 ` [net-next PATCH v2 8/9] netdev-genl: spec: Add PID in netdev netlink YAML spec Amritha Nambiar
2023-08-21 23:25 ` [net-next PATCH v2 9/9] netdev-genl: Add PID for the NAPI thread Amritha Nambiar
2023-08-23 10:24 ` [net-next PATCH v2 0/9] Introduce NAPI queues support David Laight
2023-08-23 23:49 ` Nambiar, Amritha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824165518.3002655f@kernel.org \
--to=kuba@kernel.org \
--cc=amritha.nambiar@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.