From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDE56C27C40 for ; Thu, 24 Aug 2023 17:19:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZDzL-0005xN-Hu; Thu, 24 Aug 2023 13:19:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZDzJ-0005vY-MC for qemu-devel@nongnu.org; Thu, 24 Aug 2023 13:19:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZDzH-0007ce-96 for qemu-devel@nongnu.org; Thu, 24 Aug 2023 13:19:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692897554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qgEvGtAA0m1hbND3GWZNz5pfP31ltW2sX87UftpWcYU=; b=XTy4gf0l5RWyDFsaHOhyBG42lvB7x48PGvdi3d4IUWhB50RzD5+pDE2Fj3gKI83RvI9q/n 054VZrXppljqeLGCBkMl4NRlX4BIN8r6ADjU+bPO7VJa+MAje5pV5FGsNkRn1EPup7kzxY aHDgy+q4UMab6IaWkAJ88wACSKKQrEA= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-59-SQ3WuoX4MYavAgrLxRZq_w-1; Thu, 24 Aug 2023 13:19:11 -0400 X-MC-Unique: SQ3WuoX4MYavAgrLxRZq_w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F3E5C1C068FD; Thu, 24 Aug 2023 17:19:10 +0000 (UTC) Received: from localhost (unknown [10.39.194.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6800E6B2B6; Thu, 24 Aug 2023 17:19:10 +0000 (UTC) Date: Thu, 24 Aug 2023 13:19:09 -0400 From: Stefan Hajnoczi To: Andrey Drobyshev Cc: John Snow , qemu-block@nongnu.org, qemu-stable@nongnu.org, qemu-devel@nongnu.org, kwolf@redhat.com, hreitz@redhat.com, vsementsov@yandex-team.ru, eblake@redhat.com, den@openvz.org, fam@euphon.net Subject: Re: [PATCH v2 0/3] block: align CoR requests to subclusters Message-ID: <20230824171909.GB1690425@fedora> References: <20230711172553.234055-1-andrey.drobyshev@virtuozzo.com> <85e0a9bb-8e8f-e414-70ad-528e45a803e4@virtuozzo.com> <60354ae2-d394-49b8-8289-787b4e02e2a6@virtuozzo.com> <577e81f0-1479-41b2-9e97-ad6678cf7216@virtuozzo.com> <3ea51ea2-0138-4a0e-92f0-175d8ad7540e@virtuozzo.com> <20230824143247.GB1412804@fedora> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JkGLBb7LeEj9GvQm" Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --JkGLBb7LeEj9GvQm Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 24, 2023 at 06:47:20PM +0300, Andrey Drobyshev wrote: > On 8/24/23 17:32, Stefan Hajnoczi wrote: > > On Wed, Aug 23, 2023 at 03:50:55PM +0300, Andrey Drobyshev wrote: > >> On 8/22/23 22:58, John Snow wrote: > >>> On Tue, Aug 22, 2023 at 1:33=E2=80=AFPM Andrey Drobyshev > >>> wrote: > >>>> > >>>> On 8/16/23 12:22, Andrey Drobyshev wrote: > >>>>> On 7/31/23 17:51, Andrey Drobyshev wrote: > >>>>>> On 7/24/23 16:11, Andrey Drobyshev wrote: > >>>>>>> On 7/11/23 20:25, Andrey Drobyshev wrote: > >>>>>>>> v1 --> v2: > >>>>>>>> * Fixed line indentation; > >>>>>>>> * Fixed wording in a comment; > >>>>>>>> * Added R-b. > >>>>>>>> > >>>>>>>> v1: https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg= 00606.html > >>>>>>>> > >>>>>>>> Andrey Drobyshev (3): > >>>>>>>> block: add subcluster_size field to BlockDriverInfo > >>>>>>>> block/io: align requests to subcluster_size > >>>>>>>> tests/qemu-iotests/197: add testcase for CoR with subclusters > >>>>>>>> > >>>>>>>> block.c | 7 +++++ > >>>>>>>> block/io.c | 50 ++++++++++++++++++-----------= ------- > >>>>>>>> block/mirror.c | 8 +++--- > >>>>>>>> block/qcow2.c | 1 + > >>>>>>>> include/block/block-common.h | 5 ++++ > >>>>>>>> include/block/block-io.h | 8 +++--- > >>>>>>>> tests/qemu-iotests/197 | 29 +++++++++++++++++++++ > >>>>>>>> tests/qemu-iotests/197.out | 24 +++++++++++++++++ > >>>>>>>> 8 files changed, 99 insertions(+), 33 deletions(-) > >>>>>>>> > >>>>>>> > >>>>>>> Ping > >>>>>> > >>>>>> Another ping > >>>>> > >>>>> Yet another friendly ping > >>>> > >>>> One more friendly ping > >>> > >>> Looks like Stefan gave you an R-B for the series; do we just need an > >>> ACK by the block maintainers at this point or is there someone > >>> specific you're hoping will review this? > >>> > >>> --js > >>> > >> > >> Hi John, > >> > >> I figure a maintainer's R-b doesn't imply the patches being merged into > >> the tree. Hence I'm waiting for the notice that they actually are mer= ged. > >> > >> Please let me know if the process should be different. > >=20 > > Hi Andrey, > > Kevin is away right now but seemed happy enough when I mentioned this > > series to him, so I have merged this into my own tree: > >=20 > > https://gitlab.com/stefanha/qemu block > >=20 > > Sorry that your patch series have not been merged in a timely manner. > >=20 > > Stefan >=20 > Hi Stefan, > Good news! Thank you for the notice. >=20 > When you have some time would you mind taking a look at these series as > well: >=20 > https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00068.html > https://lists.nongnu.org/archive/html/qemu-block/2023-07/msg00106.html >=20 > They've been hanging in the list for weeks (probably even longer than > this one) with little to no feedback. Would be nice to know if people > find those changes useful at all. Kevin will be back on Tuesday and Hanna Czenczek said she may have time to look before then. Hopefully they will get taken care of soon. Thanks, Stefan --JkGLBb7LeEj9GvQm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmTnkQ0ACgkQnKSrs4Gr c8giWwf+NUaHgzVKWcpJXbsFhz/KRfImVtC7hEmX1n8O18weOfUHvR/n6cN7t9D7 PT4L3rrP1tSphiKk3zg9YtY/LO9ZQSFwecG23JsWBpvw2Pim9jKUAbHq6qB7KDhe Ywd+ZuAF+vqxBq+1UdZQTpaO0dP8eBM6pmP96+jEU88qZVugxtL/467bBzBIutU5 38UtNKmoRjaAHkhzTJpljR4cHBXl+0/BzoYnMHbutNkpBOK4j5NbEH0zp/iYaeSZ QEUWbfUKfbUnkl8jjLoZ5+yYqDpoOweHp4gxpPQPfPHnQrAKs6RKxX82aKw5a2ks nsyWIuBKA14l8c059ktkgiTFCIHJPg== =25pk -----END PGP SIGNATURE----- --JkGLBb7LeEj9GvQm--