From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60673C27C40 for ; Thu, 24 Aug 2023 16:14:28 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 88CAA7F1; Thu, 24 Aug 2023 18:13:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 88CAA7F1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1692893665; bh=4IzO2IQFKoiIkFIADwfHUMd7CSSgkvbcSTAY/7+GE64=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ImWd1fvI4GkwJITii68I8G7hnsZlzF2/5tnMPgg/AfFiV2fZnPJDeZ/ih8RC5eSdq nIUImqWlCjmaXHE8TWPzqncRTnUHP2LopO8s9Wxoz+SThdqosJQw1jaAFMut8QFESm oNWDL/yYc2st/29d4WxqYmC+4p91aOxfzsOlF3FE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5E937F800BF; Thu, 24 Aug 2023 18:13:07 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 03867F80158; Thu, 24 Aug 2023 18:13:07 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DFEE1F80158; Thu, 24 Aug 2023 18:13:01 +0200 (CEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 832B0F80074 for ; Thu, 24 Aug 2023 18:12:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 832B0F80074 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=o3QwsmK2 Received: by mail.gandi.net (Postfix) with ESMTPSA id F04C5E0005; Thu, 24 Aug 2023 16:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1692893566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FWHYcTT1R00OlgvYpsdbga3jUacdQWbdaLMRIeCkuOk=; b=o3QwsmK2FkbSQQGVgH0r4CH2l+KHT1naLRa+8O4jnppkxUjmSV9BBELqg+inpHy5Cet2rp qBDmniV7E0RwlKex4e4GRe5r+saUTse2nqNsGVNNzmqV+TeTp5wwbwsF6Kp9pftidD/etL tOVcLgqL0xCEf//PmXkfER5jBDomV3tlg352m8cwcpRieChJYez7b4IaKHFwFmTrPgHWzw hw3uA6S865nzlYdgJ+PrHS4sb6Ybrs7aFOmsdGwyTMlPts0FYdj5CV5fOjnoWasNCGK0y6 mRZuRCE3D9IJ4+PvTk1tiWYomxkq7J/NS8xSq18siGc9VMHe5mGR4m5TP8YzIg== Date: Thu, 24 Aug 2023 18:12:40 +0200 From: Herve Codina To: Rob Herring Cc: Christophe Leroy , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v4 06/28] dt-bindings: net: Add support for QMC HDLC Message-ID: <20230824181240.13d14f69@bootlin.com> In-Reply-To: <20230821204258.GA2253571-robh@kernel.org> References: <817d1418fa1e9e689375177bee4bdc68ceeab7be.1692376361.git.christophe.leroy@csgroup.eu> <20230821204258.GA2253571-robh@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Message-ID-Hash: 2JZNKSFQLNVJ3BKKZSVYGXBQ7GY22BLH X-Message-ID-Hash: 2JZNKSFQLNVJ3BKKZSVYGXBQ7GY22BLH X-MailFrom: herve.codina@bootlin.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 21 Aug 2023 15:42:58 -0500 Rob Herring wrote: > On Fri, Aug 18, 2023 at 06:39:00PM +0200, Christophe Leroy wrote: > > From: Herve Codina > > > > The QMC (QUICC mutichannel controller) is a controller present in some > > PowerQUICC SoC such as MPC885. > > The QMC HDLC uses the QMC controller to transfer HDLC data. > > > > Additionally, a framer can be connected to the QMC HDLC. > > If present, this framer is the interface between the TDM bus used by the > > QMC HDLC and the E1/T1 line. > > The QMC HDLC can use this framer to get information about the E1/T1 line > > and configure the E1/T1 line. > > > > Signed-off-by: Herve Codina > > Signed-off-by: Christophe Leroy > > --- > > .../devicetree/bindings/net/fsl,qmc-hdlc.yaml | 46 +++++++++++++++++++ > > 1 file changed, 46 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > > new file mode 100644 > > index 000000000000..13f3572f0feb > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > > @@ -0,0 +1,46 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/fsl,qmc-hdlc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Freescale/NXP QUICC Multichannel Controller (QMC) HDLC > > + > > +maintainers: > > + - Herve Codina > > + > > +description: | > > Don't need '|' Will be fixed in the next iteration. > > > + The QMC HDLC uses a QMC (QUICC Multichannel Controller) channel to transfer > > + HDLC data. > > + > > +properties: > > + compatible: > > + const: fsl,qmc-hdlc > > + > > + fsl,qmc-chan: > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > + items: > > + - items: > > + - description: phandle to QMC node > > + - description: Channel number > > + description: > > + Should be a phandle/number pair. The phandle to QMC node and the QMC > > + channel to use. > > + > > + framer: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + phandle to the framer node > > What's the framer? A framer is a component in charge of an E1/T1 line interface. Is is connected to the TDM bus and it converts TDM frames to/from E1/T1 frames. The HDLC data are sent/received to/from the TDM bus and the framer is used to get information about the E1/T1 line such as link up/down. I can update the description to: --- 8< --- phandle to the framer node. The framer is in charge of an E1/T1 line interface connected to the TDM bus. It can be used to get the E1/T1 line status such as link up/down. --- 8< --- Is that better ? > > > + > > +required: > > + - compatible > > + - fsl,qmc-chan > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + hdlc { > > + compatible = "fsl,qmc-hdlc"; > > + fsl,qmc-chan = <&qmc 16>; > > Where does this node live? > > QMC is this[1]? Why don't you just add the compatible to channel@10 in > the QMC node? Indeed, I will move the properties (compatible and framer phandle) to the QMC channel node. > > Rob > > [1] Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml Best regards, Hervé -- Hervé Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E382C7EE2C for ; Thu, 24 Aug 2023 16:13:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236882AbjHXQMx (ORCPT ); Thu, 24 Aug 2023 12:12:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242440AbjHXQMv (ORCPT ); Thu, 24 Aug 2023 12:12:51 -0400 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0B0619A1; Thu, 24 Aug 2023 09:12:47 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id F04C5E0005; Thu, 24 Aug 2023 16:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1692893566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FWHYcTT1R00OlgvYpsdbga3jUacdQWbdaLMRIeCkuOk=; b=o3QwsmK2FkbSQQGVgH0r4CH2l+KHT1naLRa+8O4jnppkxUjmSV9BBELqg+inpHy5Cet2rp qBDmniV7E0RwlKex4e4GRe5r+saUTse2nqNsGVNNzmqV+TeTp5wwbwsF6Kp9pftidD/etL tOVcLgqL0xCEf//PmXkfER5jBDomV3tlg352m8cwcpRieChJYez7b4IaKHFwFmTrPgHWzw hw3uA6S865nzlYdgJ+PrHS4sb6Ybrs7aFOmsdGwyTMlPts0FYdj5CV5fOjnoWasNCGK0y6 mRZuRCE3D9IJ4+PvTk1tiWYomxkq7J/NS8xSq18siGc9VMHe5mGR4m5TP8YzIg== Date: Thu, 24 Aug 2023 18:12:40 +0200 From: Herve Codina To: Rob Herring Cc: Christophe Leroy , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v4 06/28] dt-bindings: net: Add support for QMC HDLC Message-ID: <20230824181240.13d14f69@bootlin.com> In-Reply-To: <20230821204258.GA2253571-robh@kernel.org> References: <817d1418fa1e9e689375177bee4bdc68ceeab7be.1692376361.git.christophe.leroy@csgroup.eu> <20230821204258.GA2253571-robh@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, 21 Aug 2023 15:42:58 -0500 Rob Herring wrote: > On Fri, Aug 18, 2023 at 06:39:00PM +0200, Christophe Leroy wrote: > > From: Herve Codina > > > > The QMC (QUICC mutichannel controller) is a controller present in some > > PowerQUICC SoC such as MPC885. > > The QMC HDLC uses the QMC controller to transfer HDLC data. > > > > Additionally, a framer can be connected to the QMC HDLC. > > If present, this framer is the interface between the TDM bus used by the > > QMC HDLC and the E1/T1 line. > > The QMC HDLC can use this framer to get information about the E1/T1 line > > and configure the E1/T1 line. > > > > Signed-off-by: Herve Codina > > Signed-off-by: Christophe Leroy > > --- > > .../devicetree/bindings/net/fsl,qmc-hdlc.yaml | 46 +++++++++++++++++++ > > 1 file changed, 46 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > > new file mode 100644 > > index 000000000000..13f3572f0feb > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > > @@ -0,0 +1,46 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/fsl,qmc-hdlc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Freescale/NXP QUICC Multichannel Controller (QMC) HDLC > > + > > +maintainers: > > + - Herve Codina > > + > > +description: | > > Don't need '|' Will be fixed in the next iteration. > > > + The QMC HDLC uses a QMC (QUICC Multichannel Controller) channel to transfer > > + HDLC data. > > + > > +properties: > > + compatible: > > + const: fsl,qmc-hdlc > > + > > + fsl,qmc-chan: > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > + items: > > + - items: > > + - description: phandle to QMC node > > + - description: Channel number > > + description: > > + Should be a phandle/number pair. The phandle to QMC node and the QMC > > + channel to use. > > + > > + framer: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + phandle to the framer node > > What's the framer? A framer is a component in charge of an E1/T1 line interface. Is is connected to the TDM bus and it converts TDM frames to/from E1/T1 frames. The HDLC data are sent/received to/from the TDM bus and the framer is used to get information about the E1/T1 line such as link up/down. I can update the description to: --- 8< --- phandle to the framer node. The framer is in charge of an E1/T1 line interface connected to the TDM bus. It can be used to get the E1/T1 line status such as link up/down. --- 8< --- Is that better ? > > > + > > +required: > > + - compatible > > + - fsl,qmc-chan > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + hdlc { > > + compatible = "fsl,qmc-hdlc"; > > + fsl,qmc-chan = <&qmc 16>; > > Where does this node live? > > QMC is this[1]? Why don't you just add the compatible to channel@10 in > the QMC node? Indeed, I will move the properties (compatible and framer phandle) to the QMC channel node. > > Rob > > [1] Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml Best regards, Hervé -- Hervé Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32BFFC27C40 for ; Thu, 24 Aug 2023 16:13:52 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=o3QwsmK2; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RWp6k390Wz3cJ0 for ; Fri, 25 Aug 2023 02:13:50 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=o3QwsmK2; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::224; helo=relay4-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=lists.ozlabs.org) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RWp5m4D8cz3c3k for ; Fri, 25 Aug 2023 02:12:56 +1000 (AEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id F04C5E0005; Thu, 24 Aug 2023 16:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1692893566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FWHYcTT1R00OlgvYpsdbga3jUacdQWbdaLMRIeCkuOk=; b=o3QwsmK2FkbSQQGVgH0r4CH2l+KHT1naLRa+8O4jnppkxUjmSV9BBELqg+inpHy5Cet2rp qBDmniV7E0RwlKex4e4GRe5r+saUTse2nqNsGVNNzmqV+TeTp5wwbwsF6Kp9pftidD/etL tOVcLgqL0xCEf//PmXkfER5jBDomV3tlg352m8cwcpRieChJYez7b4IaKHFwFmTrPgHWzw hw3uA6S865nzlYdgJ+PrHS4sb6Ybrs7aFOmsdGwyTMlPts0FYdj5CV5fOjnoWasNCGK0y6 mRZuRCE3D9IJ4+PvTk1tiWYomxkq7J/NS8xSq18siGc9VMHe5mGR4m5TP8YzIg== Date: Thu, 24 Aug 2023 18:12:40 +0200 From: Herve Codina To: Rob Herring Subject: Re: [PATCH v4 06/28] dt-bindings: net: Add support for QMC HDLC Message-ID: <20230824181240.13d14f69@bootlin.com> In-Reply-To: <20230821204258.GA2253571-robh@kernel.org> References: <817d1418fa1e9e689375177bee4bdc68ceeab7be.1692376361.git.christophe.leroy@csgroup.eu> <20230821204258.GA2253571-robh@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , alsa-devel@alsa-project.org, Thomas Petazzoni , Xiubo Li , Linus Walleij , Jaroslav Kysela , Eric Dumazet , Krzysztof Kozlowski , Fabio Estevam , Qiang Zhao , Shengjiu Wang , Lee Jones , Jakub Kicinski , Paolo Abeni , devicetree@vger.kernel.org, Conor Dooley , linux-kernel@vger.kernel.org, Nicolin Chen , linux-gpio@vger.kernel.org, Mark Brown , Takashi Iwai , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Randy Dunlap , Liam Girdwood , Li Yang , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, 21 Aug 2023 15:42:58 -0500 Rob Herring wrote: > On Fri, Aug 18, 2023 at 06:39:00PM +0200, Christophe Leroy wrote: > > From: Herve Codina > > > > The QMC (QUICC mutichannel controller) is a controller present in some > > PowerQUICC SoC such as MPC885. > > The QMC HDLC uses the QMC controller to transfer HDLC data. > > > > Additionally, a framer can be connected to the QMC HDLC. > > If present, this framer is the interface between the TDM bus used by the > > QMC HDLC and the E1/T1 line. > > The QMC HDLC can use this framer to get information about the E1/T1 line > > and configure the E1/T1 line. > > > > Signed-off-by: Herve Codina > > Signed-off-by: Christophe Leroy > > --- > > .../devicetree/bindings/net/fsl,qmc-hdlc.yaml | 46 +++++++++++++++++++ > > 1 file changed, 46 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > > new file mode 100644 > > index 000000000000..13f3572f0feb > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml > > @@ -0,0 +1,46 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/fsl,qmc-hdlc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Freescale/NXP QUICC Multichannel Controller (QMC) HDLC > > + > > +maintainers: > > + - Herve Codina > > + > > +description: | > > Don't need '|' Will be fixed in the next iteration. > > > + The QMC HDLC uses a QMC (QUICC Multichannel Controller) channel to transfer > > + HDLC data. > > + > > +properties: > > + compatible: > > + const: fsl,qmc-hdlc > > + > > + fsl,qmc-chan: > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > + items: > > + - items: > > + - description: phandle to QMC node > > + - description: Channel number > > + description: > > + Should be a phandle/number pair. The phandle to QMC node and the QMC > > + channel to use. > > + > > + framer: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + phandle to the framer node > > What's the framer? A framer is a component in charge of an E1/T1 line interface. Is is connected to the TDM bus and it converts TDM frames to/from E1/T1 frames. The HDLC data are sent/received to/from the TDM bus and the framer is used to get information about the E1/T1 line such as link up/down. I can update the description to: --- 8< --- phandle to the framer node. The framer is in charge of an E1/T1 line interface connected to the TDM bus. It can be used to get the E1/T1 line status such as link up/down. --- 8< --- Is that better ? > > > + > > +required: > > + - compatible > > + - fsl,qmc-chan > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + hdlc { > > + compatible = "fsl,qmc-hdlc"; > > + fsl,qmc-chan = <&qmc 16>; > > Where does this node live? > > QMC is this[1]? Why don't you just add the compatible to channel@10 in > the QMC node? Indeed, I will move the properties (compatible and framer phandle) to the QMC channel node. > > Rob > > [1] Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml Best regards, Hervé -- Hervé Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18DEAC3DA6F for ; Thu, 24 Aug 2023 16:13:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+kEbuBYoRLULl4vcGTHwCaK+gm95F2dgrpwYi+VMBb4=; b=fnqCvimmw7YeyX n46F6mjmamqQek8b1tnv5LMPiuDJuEAR0qEzMqkREkEd2PAW9v66/DhK2KcK5o9n9f2M1v7I95lQv ogL1Snc4IAx9OP/yr+CFkXPgdh7+NP5DBJ8v/rCdqYDfntnnpGScVmjNBQPBvCO60BvtDe9s5Xwro 2PhcdS++QUWVArhVBTMytQFBkD9OoN8qblrk45RIAoUVkB3XtvkVtI1yKKZ9TqWPOJs8MCr0QQaew znXW3iZue86qWyCeqMTssh4aFXZTrlzfoS6BVjiH/gkpHX7FpCR3BXHhZLDhIvI4lCC+pirZaPLEq fT1K7+H1jIL/RnvhE9iA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qZCx9-003QyE-07; Thu, 24 Aug 2023 16:12:59 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qZCx5-003Qwd-1x for linux-arm-kernel@lists.infradead.org; Thu, 24 Aug 2023 16:12:58 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id F04C5E0005; Thu, 24 Aug 2023 16:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1692893566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FWHYcTT1R00OlgvYpsdbga3jUacdQWbdaLMRIeCkuOk=; b=o3QwsmK2FkbSQQGVgH0r4CH2l+KHT1naLRa+8O4jnppkxUjmSV9BBELqg+inpHy5Cet2rp qBDmniV7E0RwlKex4e4GRe5r+saUTse2nqNsGVNNzmqV+TeTp5wwbwsF6Kp9pftidD/etL tOVcLgqL0xCEf//PmXkfER5jBDomV3tlg352m8cwcpRieChJYez7b4IaKHFwFmTrPgHWzw hw3uA6S865nzlYdgJ+PrHS4sb6Ybrs7aFOmsdGwyTMlPts0FYdj5CV5fOjnoWasNCGK0y6 mRZuRCE3D9IJ4+PvTk1tiWYomxkq7J/NS8xSq18siGc9VMHe5mGR4m5TP8YzIg== Date: Thu, 24 Aug 2023 18:12:40 +0200 From: Herve Codina To: Rob Herring Cc: Christophe Leroy , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v4 06/28] dt-bindings: net: Add support for QMC HDLC Message-ID: <20230824181240.13d14f69@bootlin.com> In-Reply-To: <20230821204258.GA2253571-robh@kernel.org> References: <817d1418fa1e9e689375177bee4bdc68ceeab7be.1692376361.git.christophe.leroy@csgroup.eu> <20230821204258.GA2253571-robh@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230824_091255_937866_B587E077 X-CRM114-Status: GOOD ( 28.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyMSBBdWcgMjAyMyAxNTo0Mjo1OCAtMDUwMApSb2IgSGVycmluZyA8cm9iaEBrZXJu ZWwub3JnPiB3cm90ZToKCj4gT24gRnJpLCBBdWcgMTgsIDIwMjMgYXQgMDY6Mzk6MDBQTSArMDIw MCwgQ2hyaXN0b3BoZSBMZXJveSB3cm90ZToKPiA+IEZyb206IEhlcnZlIENvZGluYSA8aGVydmUu Y29kaW5hQGJvb3RsaW4uY29tPgo+ID4gCj4gPiBUaGUgUU1DIChRVUlDQyBtdXRpY2hhbm5lbCBj b250cm9sbGVyKSBpcyBhIGNvbnRyb2xsZXIgcHJlc2VudCBpbiBzb21lCj4gPiBQb3dlclFVSUND IFNvQyBzdWNoIGFzIE1QQzg4NS4KPiA+IFRoZSBRTUMgSERMQyB1c2VzIHRoZSBRTUMgY29udHJv bGxlciB0byB0cmFuc2ZlciBIRExDIGRhdGEuCj4gPiAKPiA+IEFkZGl0aW9uYWxseSwgYSBmcmFt ZXIgY2FuIGJlIGNvbm5lY3RlZCB0byB0aGUgUU1DIEhETEMuCj4gPiBJZiBwcmVzZW50LCB0aGlz IGZyYW1lciBpcyB0aGUgaW50ZXJmYWNlIGJldHdlZW4gdGhlIFRETSBidXMgdXNlZCBieSB0aGUK PiA+IFFNQyBIRExDIGFuZCB0aGUgRTEvVDEgbGluZS4KPiA+IFRoZSBRTUMgSERMQyBjYW4gdXNl IHRoaXMgZnJhbWVyIHRvIGdldCBpbmZvcm1hdGlvbiBhYm91dCB0aGUgRTEvVDEgbGluZQo+ID4g YW5kIGNvbmZpZ3VyZSB0aGUgRTEvVDEgbGluZS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogSGVy dmUgQ29kaW5hIDxoZXJ2ZS5jb2RpbmFAYm9vdGxpbi5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBD aHJpc3RvcGhlIExlcm95IDxjaHJpc3RvcGhlLmxlcm95QGNzZ3JvdXAuZXU+Cj4gPiAtLS0KPiA+ ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9uZXQvZnNsLHFtYy1oZGxjLnlhbWwgfCA0NiArKysr KysrKysrKysrKysrKysrCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDQ2IGluc2VydGlvbnMoKykKPiA+ ICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL25l dC9mc2wscW1jLWhkbGMueWFtbAo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL25ldC9mc2wscW1jLWhkbGMueWFtbCBiL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9uZXQvZnNsLHFtYy1oZGxjLnlhbWwKPiA+IG5ldyBmaWxlIG1v ZGUgMTAwNjQ0Cj4gPiBpbmRleCAwMDAwMDAwMDAwMDAuLjEzZjM1NzJmMGZlYgo+ID4gLS0tIC9k ZXYvbnVsbAo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL25ldC9m c2wscW1jLWhkbGMueWFtbAo+ID4gQEAgLTAsMCArMSw0NiBAQAo+ID4gKyMgU1BEWC1MaWNlbnNl LUlkZW50aWZpZXI6IChHUEwtMi4wLW9ubHkgT1IgQlNELTItQ2xhdXNlKQo+ID4gKyVZQU1MIDEu Mgo+ID4gKy0tLQo+ID4gKyRpZDogaHR0cDovL2RldmljZXRyZWUub3JnL3NjaGVtYXMvbmV0L2Zz bCxxbWMtaGRsYy55YW1sIwo+ID4gKyRzY2hlbWE6IGh0dHA6Ly9kZXZpY2V0cmVlLm9yZy9tZXRh LXNjaGVtYXMvY29yZS55YW1sIwo+ID4gKwo+ID4gK3RpdGxlOiBGcmVlc2NhbGUvTlhQIFFVSUND IE11bHRpY2hhbm5lbCBDb250cm9sbGVyIChRTUMpIEhETEMKPiA+ICsKPiA+ICttYWludGFpbmVy czoKPiA+ICsgIC0gSGVydmUgQ29kaW5hIDxoZXJ2ZS5jb2RpbmFAYm9vdGxpbi5jb20+Cj4gPiAr Cj4gPiArZGVzY3JpcHRpb246IHwgIAo+IAo+IERvbid0IG5lZWQgJ3wnCgpXaWxsIGJlIGZpeGVk IGluIHRoZSBuZXh0IGl0ZXJhdGlvbi4KCj4gCj4gPiArICBUaGUgUU1DIEhETEMgdXNlcyBhIFFN QyAoUVVJQ0MgTXVsdGljaGFubmVsIENvbnRyb2xsZXIpIGNoYW5uZWwgdG8gdHJhbnNmZXIKPiA+ ICsgIEhETEMgZGF0YS4KPiA+ICsKPiA+ICtwcm9wZXJ0aWVzOgo+ID4gKyAgY29tcGF0aWJsZToK PiA+ICsgICAgY29uc3Q6IGZzbCxxbWMtaGRsYwo+ID4gKwo+ID4gKyAgZnNsLHFtYy1jaGFuOgo+ ID4gKyAgICAkcmVmOiAvc2NoZW1hcy90eXBlcy55YW1sIy9kZWZpbml0aW9ucy9waGFuZGxlLWFy cmF5Cj4gPiArICAgIGl0ZW1zOgo+ID4gKyAgICAgIC0gaXRlbXM6Cj4gPiArICAgICAgICAgIC0g ZGVzY3JpcHRpb246IHBoYW5kbGUgdG8gUU1DIG5vZGUKPiA+ICsgICAgICAgICAgLSBkZXNjcmlw dGlvbjogQ2hhbm5lbCBudW1iZXIKPiA+ICsgICAgZGVzY3JpcHRpb246Cj4gPiArICAgICAgU2hv dWxkIGJlIGEgcGhhbmRsZS9udW1iZXIgcGFpci4gVGhlIHBoYW5kbGUgdG8gUU1DIG5vZGUgYW5k IHRoZSBRTUMKPiA+ICsgICAgICBjaGFubmVsIHRvIHVzZS4KPiA+ICsKPiA+ICsgIGZyYW1lcjoK PiA+ICsgICAgJHJlZjogL3NjaGVtYXMvdHlwZXMueWFtbCMvZGVmaW5pdGlvbnMvcGhhbmRsZQo+ ID4gKyAgICBkZXNjcmlwdGlvbjoKPiA+ICsgICAgICBwaGFuZGxlIHRvIHRoZSBmcmFtZXIgbm9k ZSAgCj4gCj4gV2hhdCdzIHRoZSBmcmFtZXI/IAoKQSBmcmFtZXIgaXMgYSBjb21wb25lbnQgaW4g Y2hhcmdlIG9mIGFuIEUxL1QxIGxpbmUgaW50ZXJmYWNlLgpJcyBpcyBjb25uZWN0ZWQgdG8gdGhl IFRETSBidXMgYW5kIGl0IGNvbnZlcnRzIFRETSBmcmFtZXMgdG8vZnJvbSBFMS9UMQpmcmFtZXMu ClRoZSBIRExDIGRhdGEgYXJlIHNlbnQvcmVjZWl2ZWQgdG8vZnJvbSB0aGUgVERNIGJ1cyBhbmQg dGhlIGZyYW1lciBpcyB1c2VkIHRvCmdldCBpbmZvcm1hdGlvbiBhYm91dCB0aGUgRTEvVDEgbGlu ZSBzdWNoIGFzIGxpbmsgdXAvZG93bi4KCkkgY2FuIHVwZGF0ZSB0aGUgZGVzY3JpcHRpb24gdG86 Ci0tLSA4PCAtLS0KcGhhbmRsZSB0byB0aGUgZnJhbWVyIG5vZGUuIFRoZSBmcmFtZXIgaXMgaW4g Y2hhcmdlIG9mIGFuIEUxL1QxIGxpbmUKaW50ZXJmYWNlIGNvbm5lY3RlZCB0byB0aGUgVERNIGJ1 cy4gSXQgY2FuIGJlIHVzZWQgdG8gZ2V0IHRoZSBFMS9UMSBsaW5lCnN0YXR1cyBzdWNoIGFzIGxp bmsgdXAvZG93bi4KLS0tIDg8IC0tLQoKSXMgdGhhdCBiZXR0ZXIgPwoKPiAKPiA+ICsKPiA+ICty ZXF1aXJlZDoKPiA+ICsgIC0gY29tcGF0aWJsZQo+ID4gKyAgLSBmc2wscW1jLWNoYW4KPiA+ICsK PiA+ICthZGRpdGlvbmFsUHJvcGVydGllczogZmFsc2UKPiA+ICsKPiA+ICtleGFtcGxlczoKPiA+ ICsgIC0gfAo+ID4gKyAgICBoZGxjIHsKPiA+ICsgICAgICAgIGNvbXBhdGlibGUgPSAiZnNsLHFt Yy1oZGxjIjsKPiA+ICsgICAgICAgIGZzbCxxbWMtY2hhbiA9IDwmcW1jIDE2PjsgIAo+IAo+IFdo ZXJlIGRvZXMgdGhpcyBub2RlIGxpdmU/Cj4gCj4gUU1DIGlzIHRoaXNbMV0/IFdoeSBkb24ndCB5 b3UganVzdCBhZGQgdGhlIGNvbXBhdGlibGUgdG8gY2hhbm5lbEAxMCBpbiAKPiB0aGUgUU1DIG5v ZGU/CgpJbmRlZWQsIEkgd2lsbCBtb3ZlIHRoZSBwcm9wZXJ0aWVzIChjb21wYXRpYmxlIGFuZCBm cmFtZXIgcGhhbmRsZSkgdG8gdGhlClFNQyBjaGFubmVsIG5vZGUuCgo+IAo+IFJvYgo+IAo+IFsx XSBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc29jL2ZzbC9jcG1fcWUvZnNsLGNw bTEtc2NjLXFtYy55YW1sCgpCZXN0IHJlZ2FyZHMsCkhlcnbDqQoKLS0gCkhlcnbDqSBDb2RpbmEs IEJvb3RsaW4KRW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwpodHRwczovL2Jv b3RsaW4uY29tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==