From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Zoltan Gyarmati <zgyarmati@zgyarmati.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1 2/2] package/quazip: also enable for qt6
Date: Thu, 24 Aug 2023 23:19:41 +0200 [thread overview]
Message-ID: <20230824231941.6b365ab1@windsurf> (raw)
In-Reply-To: <20230809171501.1329182-3-zgyarmati@zgyarmati.de>
On Wed, 9 Aug 2023 19:15:01 +0200
Zoltan Gyarmati <zgyarmati@zgyarmati.de> wrote:
> source "package/simple-mail/Config.in"
> endif
> source "package/qt6/Config.in"
> +if BR2_PACKAGE_QT6
> +comment "QT6 libraries and helper libraries"
> + source "package/quazip/Config.in"
> +endif
I didn't really like this double inclusion of package/quazip/Config.in,
so instead, I committed the following preparation change:
https://gitlab.com/buildroot.org/buildroot/-/commit/46f1cd6fe3b6a0f066e6217dec19ea8eb96d3923
And then applied your commit to the next branch, without your
package/Config.in change, which was no longer needed.
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-08-24 21:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 17:14 [Buildroot] [PATCH v1 0/2] RFC Building packages both qt5/6 Zoltan Gyarmati
2023-08-09 17:15 ` [Buildroot] [PATCH v1 1/2] package/qt6/qt6core5compat: add new package Zoltan Gyarmati
2023-08-24 21:18 ` Thomas Petazzoni via buildroot
2023-08-09 17:15 ` [Buildroot] [PATCH v1 2/2] package/quazip: also enable for qt6 Zoltan Gyarmati
2023-08-24 21:19 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824231941.6b365ab1@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=zgyarmati@zgyarmati.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.