From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57925C3DA66 for ; Fri, 25 Aug 2023 11:22:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235081AbjHYLVc (ORCPT ); Fri, 25 Aug 2023 07:21:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243324AbjHYLV0 (ORCPT ); Fri, 25 Aug 2023 07:21:26 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C27E1FEC for ; Fri, 25 Aug 2023 04:20:57 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40061928e5aso7186555e9.3 for ; Fri, 25 Aug 2023 04:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692962456; x=1693567256; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LyVYlwAqgLBhb9pjXnI3VdwK+OmQBeJAxGPkhMUt9do=; b=xAzctQaaqWDUp/VW4HIk1k0poq1PDBIxGK49RQY+IOkgmWhyxP/3Fpv6X4Ed8tn0C3 t3+z5TVE9tiAQrQizBbkKgl5VOqge1qy4fJoeNG5wgqLaqxnRw3HxTDjDdOm3BaAbQ7L AdjTRBhbhStpyO5ZGkItbyeYzTQDWtJRkKATLP7jpieaNTREt87LSCHGaJ8PB3k90KSX RKUPzY7pYeVDIBTVoMIOAiak5S1uTsPGZc9yh6GhzW/F2ied97mVGIRP36cpImKhHrvz AwC/uVS3HSCnl8TJIx2vz+yZYvhmYXTPL8yUT7P4/JO28ixTpWtg0j8LgjG07QsFDid5 JmsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692962456; x=1693567256; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LyVYlwAqgLBhb9pjXnI3VdwK+OmQBeJAxGPkhMUt9do=; b=dEPf+o9Ve6oL7RIRxqcWfnQwncdGUYETlqkzQ6jE3N4qBVGTz8cVadF6OuzX9GEhjk EswEsKLmcGCL5vtD2hjdW92ksCk6DpZUcb4RBpvmgGPno73TOzDmH8zzMRyeoSZTgH2B Ss8YNRFaYS2s5ozTqwICP84iwd8E2/BMwIYNHWRg2YGuZiQbMq8eePveO2Ltt5A8J4Fz +CIvJqTogEoEyUi+T0DbdYIlKjLDTHr6HtYcpHHWBGESeFE48Ez3XUakq0iU17hO0Ygj z80HCdlprOgPhyq2rdtn1QQvXSMDrC366YyfH+bvJx+NopxJSnUz/513gd1niLkRBxAy OmhA== X-Gm-Message-State: AOJu0YwrRJHtWPOGT+jDZZzpwyIzJ5bsuRXITvmfrLJ+ZvqNCiFUUjsJ BraLaqCa42kg11P0uueysPkbUQ== X-Google-Smtp-Source: AGHT+IF4F+IhpNhFa0LEait9G/lVg93DLllxE8WUtCFepSGG51mVVPFuUrfL9VTKvfSysAM94nTvWw== X-Received: by 2002:adf:fd4e:0:b0:313:ef08:c83b with SMTP id h14-20020adffd4e000000b00313ef08c83bmr12573907wrs.56.1692962455985; Fri, 25 Aug 2023 04:20:55 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id n12-20020a5d67cc000000b00317afc7949csm1950082wrw.50.2023.08.25.04.20.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 04:20:55 -0700 (PDT) Date: Fri, 25 Aug 2023 12:20:53 +0100 From: Daniel Thompson To: Douglas Anderson Cc: Mark Rutland , Catalin Marinas , Will Deacon , Sumit Garg , Marc Zyngier , "Rafael J . Wysocki" , Ard Biesheuvel , Thomas Gleixner , kgdb-bugreport@lists.sourceforge.net, Lecopzer Chen , linux-perf-users@vger.kernel.org, Masayoshi Mizuma , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, ito-yuichi@fujitsu.com, Stephen Boyd , Peter Zijlstra , D Scott Phillips , Josh Poimboeuf , Valentin Schneider , linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 6/6] arm64: kgdb: Implement kgdb_roundup_cpus() to enable pseudo-NMI roundup Message-ID: <20230825112053.GE270740@aspen.lan> References: <20230824153233.1006420-1-dianders@chromium.org> <20230824083012.v11.6.I2ef26d1b3bfbed2d10a281942b0da7d9854de05e@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230824083012.v11.6.I2ef26d1b3bfbed2d10a281942b0da7d9854de05e@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Thu, Aug 24, 2023 at 08:30:32AM -0700, Douglas Anderson wrote: > Up until now we've been using the generic (weak) implementation for > kgdb_roundup_cpus() when using kgdb on arm64. Let's move to a custom > one. The advantage here is that, when pseudo-NMI is enabled on a > device, we'll be able to round up CPUs using pseudo-NMI. This allows > us to debug CPUs that are stuck with interrupts disabled. If > pseudo-NMIs are not enabled then we'll fallback to just using an IPI, > which is still slightly better than the generic implementation since > it avoids the potential situation described in the generic > kgdb_call_nmi_hook(). > > Co-developed-by: Sumit Garg > Signed-off-by: Sumit Garg > Signed-off-by: Douglas Anderson >From a kgdb point of view: Reviewed-by: Daniel Thompson Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C418C3DA66 for ; Fri, 25 Aug 2023 11:21:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GWF2Iixv7DmIgaW7Hp5z962kUWwcZt2au1tifQkH2B0=; b=bbJb4Lx+HlcaZN fEjvIRqf+ocCeHopzcDcPfrjeMOXx5F6yDBGFPVZ26ZDJfW7EjHIp1KIKsZUJgU+56qNANvNhS+iA YJOkWVSKqvU3BM9B7aO+UnOCNsj74r1aTCk2WlxIe/6S1umIwDhiPj1i56pjKHhY7MggBAeAk1djw ca8aX4oBQG++vePgCNGCAhXiGG7rN/8XRVtt5PA7uUevrBGa5CD/2DXcT33xBYcMyqwoelH3aae3x zysMjFx81Q7aKPKTYHUwV+H4iKBig8ZGTjfEz9B9CWANtDJLPBdVIbULR3gmkhbUbSrIYiUD+M37j uUspNdlno78+pyC1Entw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qZUs9-0059UY-2t; Fri, 25 Aug 2023 11:21:01 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qZUs6-0059R8-2s for linux-arm-kernel@lists.infradead.org; Fri, 25 Aug 2023 11:21:00 +0000 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-31c5cac3ae2so619511f8f.3 for ; Fri, 25 Aug 2023 04:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692962456; x=1693567256; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LyVYlwAqgLBhb9pjXnI3VdwK+OmQBeJAxGPkhMUt9do=; b=xAzctQaaqWDUp/VW4HIk1k0poq1PDBIxGK49RQY+IOkgmWhyxP/3Fpv6X4Ed8tn0C3 t3+z5TVE9tiAQrQizBbkKgl5VOqge1qy4fJoeNG5wgqLaqxnRw3HxTDjDdOm3BaAbQ7L AdjTRBhbhStpyO5ZGkItbyeYzTQDWtJRkKATLP7jpieaNTREt87LSCHGaJ8PB3k90KSX RKUPzY7pYeVDIBTVoMIOAiak5S1uTsPGZc9yh6GhzW/F2ied97mVGIRP36cpImKhHrvz AwC/uVS3HSCnl8TJIx2vz+yZYvhmYXTPL8yUT7P4/JO28ixTpWtg0j8LgjG07QsFDid5 JmsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692962456; x=1693567256; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LyVYlwAqgLBhb9pjXnI3VdwK+OmQBeJAxGPkhMUt9do=; b=EZkfci2Ys00WrdlPcDtEIeAwH0Zzs2gs3dI8xbSf//gHFlE1Iqpjs/8sJ6vVVSYZTv erEpkRMRdqN9gd6zPYpHx4zHm6J5dzjkvIx8mY7P9wk68tG5OeCZ8qtw1FQlLoVPqTz+ PumZl5yxg/egFWk+0mplAzQdWGK5Tnh/iR45EfieUvquJR0EUNQhmjeq+kumn15Jwx9g UZcDprxMGFP54HYJduyzhuNe+V55y98dxbraaASOZyVw+1YwP98GZgAZAAhR+4BU4R7w hx+UdF+IFrNA0vXIuYD6oq3JPVOvyZ4kbkIvVqqFJKzi6Afaf4INguXMLO1G5jz3JzrW CIXA== X-Gm-Message-State: AOJu0YzuIj5gCQS2ALP8smsO1tk0hDFAmCVNXTN0Za3Vm976MRKrQ23Z bfKi7RyonxOqj7Wg+pKeJI0viw== X-Google-Smtp-Source: AGHT+IF4F+IhpNhFa0LEait9G/lVg93DLllxE8WUtCFepSGG51mVVPFuUrfL9VTKvfSysAM94nTvWw== X-Received: by 2002:adf:fd4e:0:b0:313:ef08:c83b with SMTP id h14-20020adffd4e000000b00313ef08c83bmr12573907wrs.56.1692962455985; Fri, 25 Aug 2023 04:20:55 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id n12-20020a5d67cc000000b00317afc7949csm1950082wrw.50.2023.08.25.04.20.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 04:20:55 -0700 (PDT) Date: Fri, 25 Aug 2023 12:20:53 +0100 From: Daniel Thompson To: Douglas Anderson Cc: Mark Rutland , Catalin Marinas , Will Deacon , Sumit Garg , Marc Zyngier , "Rafael J . Wysocki" , Ard Biesheuvel , Thomas Gleixner , kgdb-bugreport@lists.sourceforge.net, Lecopzer Chen , linux-perf-users@vger.kernel.org, Masayoshi Mizuma , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, ito-yuichi@fujitsu.com, Stephen Boyd , Peter Zijlstra , D Scott Phillips , Josh Poimboeuf , Valentin Schneider , linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 6/6] arm64: kgdb: Implement kgdb_roundup_cpus() to enable pseudo-NMI roundup Message-ID: <20230825112053.GE270740@aspen.lan> References: <20230824153233.1006420-1-dianders@chromium.org> <20230824083012.v11.6.I2ef26d1b3bfbed2d10a281942b0da7d9854de05e@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230824083012.v11.6.I2ef26d1b3bfbed2d10a281942b0da7d9854de05e@changeid> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230825_042058_952412_B3080D01 X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 24, 2023 at 08:30:32AM -0700, Douglas Anderson wrote: > Up until now we've been using the generic (weak) implementation for > kgdb_roundup_cpus() when using kgdb on arm64. Let's move to a custom > one. The advantage here is that, when pseudo-NMI is enabled on a > device, we'll be able to round up CPUs using pseudo-NMI. This allows > us to debug CPUs that are stuck with interrupts disabled. If > pseudo-NMIs are not enabled then we'll fallback to just using an IPI, > which is still slightly better than the generic implementation since > it avoids the potential situation described in the generic > kgdb_call_nmi_hook(). > > Co-developed-by: Sumit Garg > Signed-off-by: Sumit Garg > Signed-off-by: Douglas Anderson >From a kgdb point of view: Reviewed-by: Daniel Thompson Daniel. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel