From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Yicong Yang <yangyicong@huawei.com>
Cc: <suzuki.poulose@arm.com>, <mathieu.poirier@linaro.org>,
<linux-kernel@vger.kernel.org>,
<alexander.shishkin@linux.intel.com>, <helgaas@kernel.org>,
<linux-pci@vger.kernel.org>, <prime.zeng@hisilicon.com>,
<linuxarm@huawei.com>, <yangyicong@hisilicon.com>,
<hejunhao3@huawei.com>
Subject: Re: [PATCH 4/5] hwtracing: hisi_ptt: Don't try to attach a task
Date: Fri, 25 Aug 2023 12:25:16 +0100 [thread overview]
Message-ID: <20230825122516.000053d8@Huawei.com> (raw)
In-Reply-To: <20230809081825.11518-5-yangyicong@huawei.com>
On Wed, 9 Aug 2023 16:18:24 +0800
Yicong Yang <yangyicong@huawei.com> wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
>
> PTT is an uncore PMU and shouldn't be attached to any task. Block
> the usage in pmu::event_init().
>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/hwtracing/ptt/hisi_ptt.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c
> index 3aba7bb6e548..916686c6a9c8 100644
> --- a/drivers/hwtracing/ptt/hisi_ptt.c
> +++ b/drivers/hwtracing/ptt/hisi_ptt.c
> @@ -1003,6 +1003,9 @@ static int hisi_ptt_pmu_event_init(struct perf_event *event)
> return -EOPNOTSUPP;
> }
>
> + if (event->attach_state & PERF_ATTACH_TASK)
> + return -EOPNOTSUPP;
> +
> if (event->attr.type != hisi_ptt->hisi_ptt_pmu.type)
> return -ENOENT;
>
next prev parent reply other threads:[~2023-08-25 11:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 8:18 [PATCH 0/5] Several updates for PTT driver Yicong Yang
2023-08-09 8:18 ` [PATCH 1/5] hwtracing: hisi_ptt: Disable interrupt after trace end Yicong Yang
2023-08-25 11:23 ` Jonathan Cameron
2023-08-09 8:18 ` [PATCH 2/5] hwtracing: hisi_ptt: Handle the interrupt in hardirq context Yicong Yang
2023-08-25 11:24 ` Jonathan Cameron
2023-08-09 8:18 ` [PATCH 3/5] hwtracing: hisi_ptt: Optimize the trace data committing Yicong Yang
2023-08-25 11:24 ` Jonathan Cameron
2023-08-09 8:18 ` [PATCH 4/5] hwtracing: hisi_ptt: Don't try to attach a task Yicong Yang
2023-08-25 11:25 ` Jonathan Cameron [this message]
2023-08-09 8:18 ` [PATCH 5/5] hwtracing: hisi_ptt: Add dummy callback pmu::read() Yicong Yang
2023-08-25 11:25 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825122516.000053d8@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=hejunhao3@huawei.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mathieu.poirier@linaro.org \
--cc=prime.zeng@hisilicon.com \
--cc=suzuki.poulose@arm.com \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.