From: Oleg Nesterov <oleg@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Yonghong Song <yhs@fb.com>, Kui-Feng Lee <kuifeng@fb.com>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@kernel.org>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bpf: task_group_seq_get_next: cleanup the usage of next_thread()
Date: Fri, 25 Aug 2023 15:50:42 +0200 [thread overview]
Message-ID: <20230825135041.GB29260@redhat.com> (raw)
In-Reply-To: <87fs47qm5u.fsf@email.froward.int.ebiederm.org>
On 08/25, Eric W. Biederman wrote:
>
> For the record I find this code confusing, and wrong.
Oh, yes...
> and has
> a built in race condition which means it could wind up iterating through
> a different process.
Yes, common->pid and/or common->pid_visiting can be reused
but I am not going to try to fix this ;)
> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Thanks!
Oleg.
prev parent reply other threads:[~2023-08-25 13:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 15:09 [PATCH] bpf: task_group_seq_get_next: cleanup the usage of next_thread() Oleg Nesterov
2023-08-21 17:55 ` Kui-Feng Lee
2023-08-21 18:34 ` Oleg Nesterov
2023-08-21 19:54 ` Oleg Nesterov
2023-08-21 20:24 ` Kui-Feng Lee
2023-08-21 20:03 ` [PATCH] bpf: task_group_seq_get_next: cleanup the usage of get/put_task_struct Oleg Nesterov
2023-08-21 20:32 ` Kui-Feng Lee
2023-08-21 20:38 ` Kui-Feng Lee
2023-08-22 1:06 ` Yonghong Song
2023-08-22 12:05 ` Oleg Nesterov
2023-08-22 12:05 ` [PATCH V2] " Oleg Nesterov
2023-08-25 14:28 ` Daniel Borkmann
2023-08-25 16:26 ` Oleg Nesterov
2023-08-25 12:41 ` [PATCH] bpf: task_group_seq_get_next: cleanup the usage of next_thread() Oleg Nesterov
2023-08-25 13:36 ` Eric W. Biederman
2023-08-25 13:50 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825135041.GB29260@redhat.com \
--to=oleg@redhat.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=ebiederm@xmission.com \
--cc=kuifeng@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.