From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
Kajol Jain <kjain@linux.ibm.com>,
John Garry <john.g.garry@oracle.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v5 0/2] perf list: Remove duplicate PMUs
Date: Fri, 25 Aug 2023 06:52:35 -0700 [thread overview]
Message-ID: <20230825135237.921058-1-irogers@google.com> (raw)
When there are multiple PMUs, differing by ordered suffixes, by
default only display one. This avoids repeated listing of events, in
particular when there are 10s of uncore PMUs. If "-v" is passed to
"perf list" then still list all PMUs.
Listing fewer PMU/event combinations helps speed the all PMU event
tests.
Before:
```
$ perf list
...
uncore_imc_free_running_0/data_read/ [Kernel PMU event]
uncore_imc_free_running_0/data_total/ [Kernel PMU event]
uncore_imc_free_running_0/data_write/ [Kernel PMU event]
uncore_imc_free_running_1/data_read/ [Kernel PMU event]
uncore_imc_free_running_1/data_total/ [Kernel PMU event]
uncore_imc_free_running_1/data_write/ [Kernel PMU event]
```
After:
```
$ perf list
...
uncore_imc_free_running/data_read/ [Kernel PMU event]
uncore_imc_free_running/data_total/ [Kernel PMU event]
uncore_imc_free_running/data_write/ [Kernel PMU event]
...
$ perf list -v
...
uncore_imc_free_running_0/data_read/ [Kernel PMU event]
uncore_imc_free_running_0/data_total/ [Kernel PMU event]
uncore_imc_free_running_0/data_write/ [Kernel PMU event]
uncore_imc_free_running_1/data_read/ [Kernel PMU event]
uncore_imc_free_running_1/data_total/ [Kernel PMU event]
uncore_imc_free_running_1/data_write/ [Kernel PMU event]
...
```
The PMUs are sorted by name then suffix as a part of this change.
v5: Improved the 2nd patch's commit message and removed an unused
variable as suggested by Kan Liang <kan.liang@linux.intel.com>.
v4: Rebase on top of lazy PMU changes. Ignore numeric ordering due to
gaps, suggested by Kan Liang <kan.liang@linux.intel.com>. Fold
patches 2 & 3 as suggested by John Garry <john.g.garry@oracle.com>
(done by accident as part of rebasing).
v3: Add detail to patch 1 sorting commit message about the suffix and
why sorting is necessary.
v2: List all PMUs when "-v" is passed as suggested by John Garry
<john.g.garry@oracle.com>.
Ian Rogers (2):
perf pmus: Sort pmus by name then suffix
perf pmus: Skip duplicate PMUs and don't print list suffix by default
tools/perf/builtin-list.c | 8 +++
tools/perf/util/pmu.c | 17 ++++--
tools/perf/util/pmu.h | 3 +-
tools/perf/util/pmus.c | 99 ++++++++++++++++++++++++++++++-
tools/perf/util/pmus.h | 2 +
tools/perf/util/print-events.h | 1 +
tools/perf/util/s390-sample-raw.c | 3 +-
7 files changed, 123 insertions(+), 10 deletions(-)
--
2.42.0.rc2.253.gd59a3bf2b4-goog
next reply other threads:[~2023-08-25 13:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 13:52 Ian Rogers [this message]
2023-08-25 13:52 ` [PATCH v5 1/2] perf pmus: Sort pmus by name then suffix Ian Rogers
2023-08-25 14:48 ` Arnaldo Carvalho de Melo
2023-08-25 14:51 ` Arnaldo Carvalho de Melo
2023-08-25 15:56 ` Ian Rogers
2023-08-25 16:49 ` Arnaldo Carvalho de Melo
2023-08-25 20:23 ` Arnaldo Carvalho de Melo
2023-08-25 22:48 ` Ian Rogers
2023-08-25 13:52 ` [PATCH v5 2/2] perf pmus: Skip duplicate PMUs and don't print list suffix by default Ian Rogers
2023-08-25 14:05 ` [PATCH v5 0/2] perf list: Remove duplicate PMUs Liang, Kan
2023-08-25 14:46 ` Arnaldo Carvalho de Melo
2023-08-29 5:06 ` kajoljain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825135237.921058-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.