From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:100 isst_if_get_tpmi_instance_count() warn: potential spectre issue 'isst_common.sst_inst' [r] (local cap)
Date: Sat, 26 Aug 2023 00:09:51 +0800 [thread overview]
Message-ID: <202308260026.QIMj168R-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
CC: Hans de Goede <hdegoede@redhat.com>
CC: Zhang Rui <rui.zhang@intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4f9e7fabf8643003afefc172e62dd276686f016e
commit: d805456c712f93ba8a012430f2a93bec133b6ff4 platform/x86: ISST: Enumerate TPMI SST and create framework
date: 5 months ago
:::::: branch date: 13 hours ago
:::::: commit date: 5 months ago
config: x86_64-randconfig-r071-20230824 (https://download.01.org/0day-ci/archive/20230826/202308260026.QIMj168R-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230826/202308260026.QIMj168R-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202308260026.QIMj168R-lkp@intel.com/
smatch warnings:
drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:100 isst_if_get_tpmi_instance_count() warn: potential spectre issue 'isst_common.sst_inst' [r] (local cap)
drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:104 isst_if_get_tpmi_instance_count() warn: possible spectre second half. 'sst_inst'
vim +100 drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
d805456c712f93 Srinivas Pandruvada 2023-03-07 87
d805456c712f93 Srinivas Pandruvada 2023-03-07 88 static int isst_if_get_tpmi_instance_count(void __user *argp)
d805456c712f93 Srinivas Pandruvada 2023-03-07 89 {
d805456c712f93 Srinivas Pandruvada 2023-03-07 90 struct isst_tpmi_instance_count tpmi_inst;
d805456c712f93 Srinivas Pandruvada 2023-03-07 91 struct tpmi_sst_struct *sst_inst;
d805456c712f93 Srinivas Pandruvada 2023-03-07 92 int i;
d805456c712f93 Srinivas Pandruvada 2023-03-07 93
d805456c712f93 Srinivas Pandruvada 2023-03-07 94 if (copy_from_user(&tpmi_inst, argp, sizeof(tpmi_inst)))
d805456c712f93 Srinivas Pandruvada 2023-03-07 95 return -EFAULT;
d805456c712f93 Srinivas Pandruvada 2023-03-07 96
d805456c712f93 Srinivas Pandruvada 2023-03-07 97 if (tpmi_inst.socket_id >= topology_max_packages())
d805456c712f93 Srinivas Pandruvada 2023-03-07 98 return -EINVAL;
d805456c712f93 Srinivas Pandruvada 2023-03-07 99
d805456c712f93 Srinivas Pandruvada 2023-03-07 @100 tpmi_inst.count = isst_common.sst_inst[tpmi_inst.socket_id]->number_of_power_domains;
d805456c712f93 Srinivas Pandruvada 2023-03-07 101
d805456c712f93 Srinivas Pandruvada 2023-03-07 102 sst_inst = isst_common.sst_inst[tpmi_inst.socket_id];
d805456c712f93 Srinivas Pandruvada 2023-03-07 103 tpmi_inst.valid_mask = 0;
d805456c712f93 Srinivas Pandruvada 2023-03-07 @104 for (i = 0; i < sst_inst->number_of_power_domains; ++i) {
d805456c712f93 Srinivas Pandruvada 2023-03-07 105 struct tpmi_per_power_domain_info *power_domain_info;
d805456c712f93 Srinivas Pandruvada 2023-03-07 106
d805456c712f93 Srinivas Pandruvada 2023-03-07 107 power_domain_info = &sst_inst->power_domain_info[i];
d805456c712f93 Srinivas Pandruvada 2023-03-07 108 if (power_domain_info->sst_base)
d805456c712f93 Srinivas Pandruvada 2023-03-07 109 tpmi_inst.valid_mask |= BIT(i);
d805456c712f93 Srinivas Pandruvada 2023-03-07 110 }
d805456c712f93 Srinivas Pandruvada 2023-03-07 111
d805456c712f93 Srinivas Pandruvada 2023-03-07 112 if (copy_to_user(argp, &tpmi_inst, sizeof(tpmi_inst)))
d805456c712f93 Srinivas Pandruvada 2023-03-07 113 return -EFAULT;
d805456c712f93 Srinivas Pandruvada 2023-03-07 114
d805456c712f93 Srinivas Pandruvada 2023-03-07 115 return 0;
d805456c712f93 Srinivas Pandruvada 2023-03-07 116 }
d805456c712f93 Srinivas Pandruvada 2023-03-07 117
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-08-25 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 16:09 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-18 17:01 drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:100 isst_if_get_tpmi_instance_count() warn: potential spectre issue 'isst_common.sst_inst' [r] (local cap) kernel test robot
2023-10-05 2:47 kernel test robot
2023-07-23 8:04 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308260026.QIMj168R-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.