All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Jesse Van Gavere <jesseevg@gmail.com>
Cc: Samuel Martin <s.martin49@gmail.com>,
	Jesse Van Gavere <jesse.vangavere@scioteq.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/qt6/qt6shadertools: new package
Date: Sat, 26 Aug 2023 21:49:12 +0200	[thread overview]
Message-ID: <20230826214912.7821c07c@windsurf> (raw)
In-Reply-To: <20230808172231.1114696-1-jesse.vangavere@scioteq.com>

Hello Jesse,

On Tue,  8 Aug 2023 19:22:31 +0200
Jesse Van Gavere <jesseevg@gmail.com> wrote:

> Signed-off-by: Jesse Van Gavere <jesse.vangavere@scioteq.com>
> ---
>  package/qt6/Config.in                         |  1 +
>  package/qt6/qt6shadertools/Config.in          | 11 +++++
>  .../qt6/qt6shadertools/qt6shadertools.hash    | 13 +++++
>  package/qt6/qt6shadertools/qt6shadertools.mk  | 47 +++++++++++++++++++
>  4 files changed, 72 insertions(+)
>  create mode 100644 package/qt6/qt6shadertools/Config.in
>  create mode 100644 package/qt6/qt6shadertools/qt6shadertools.hash
>  create mode 100644 package/qt6/qt6shadertools/qt6shadertools.mk

Thanks Jesse for your patch. It builds fine... but it doesn't install
anything. Indeed, it looks like qt6shadertools doesn't not
build/install anything when qt6base is not built with GUI support:

Skipping the build as the condition "TARGET Qt::Gui" is not met.

For the target package, it would be easy to fix. But for the host
qt6base package, the story is a bit different. Does qt6shadertools
really need GUI support in host-qt6base? If so, how did you test that
as nothing in Buildroot right now allows to enable GUI support in
host-qt6base?

Could you have a look into this, and send a v2?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-08-26 19:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 17:22 [Buildroot] [PATCH 1/1] package/qt6/qt6shadertools: new package Jesse Van Gavere
2023-08-26 19:49 ` Thomas Petazzoni via buildroot [this message]
2023-08-26 20:04   ` Jesse Van Gavere
2023-08-31 21:54     ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230826214912.7821c07c@windsurf \
    --to=buildroot@buildroot.org \
    --cc=jesse.vangavere@scioteq.com \
    --cc=jesseevg@gmail.com \
    --cc=s.martin49@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.