All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>
Cc: Stanislav Kinsburskii <stanislav.kinsburskii@gmail.com>,
	Derek Kiernan <derek.kiernan@amd.com>,
	Dragan Cvetic <dragan.cvetic@amd.com>,
	Arnd Bergmann <arnd@arndb.de>, Wei Liu <wei.liu@kernel.org>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Madhavan Venkataraman <madvenka@linux.microsoft.com>,
	Anthony Yznaga <anthony.yznaga@oracle.com>,
	"Mike Rapoport (IBM)" <rppt@kernel.org>,
	James Gowans <jgowans@amazon.com>,
	Anirudh Rayabharam <anrayabh@linux.microsoft.com>,
	Jinank Jain <jinankjain@linux.microsoft.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] Introduce persistent memory pool
Date: Sat, 26 Aug 2023 09:45:39 +0200	[thread overview]
Message-ID: <2023082633-magnetize-cupcake-accc@gregkh> (raw)
In-Reply-To: <64e8f6dd.050a0220.edb3c.c045SMTPIN_ADDED_BROKEN@mx.google.com>

On Tue, Aug 22, 2023 at 06:36:10PM -0700, Stanislav Kinsburskii wrote:
> > > +#include <linux/bitmap.h>
> > > +#include <linux/memblock.h>
> > > +#include <linux/spinlock.h>
> > > +#include <linux/types.h>
> > > +
> > > +#include <linux/pmpool.h>
> > > +
> > > +#define VERSION			1
> > 
> > In kernel code does not need versions.
> > 
> 
> Could you elaborate on this? Should kernel version be used as a backward
> compatitbility marker instead?

kernel versions should never be checked for in-kernel code, so I really
don't understand the question here sorry.

For code that is in the kernel tree, having "versions" on them (as many
drivers used to, and now only a few do), makes no sense, especially with
the stable/lts trees getting fixes for them over time as well.

In short, there should not be a need for a "version" anywhere.

thanks,

greg k-h


  parent reply	other threads:[~2023-08-26  7:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <64e7cbf7.050a0220.114c7.b70dSMTPIN_ADDED_BROKEN@mx.google.com>
2023-08-25  8:05 ` [RFC PATCH] Introduce persistent memory pool Greg Kroah-Hartman
2023-08-23  1:36   ` Stanislav Kinsburskii
2023-08-25 13:32   ` Gowans, James
2023-08-23  2:45     ` Stanislav Kinsburskii
2023-08-28 20:50       ` Alexander Graf
2023-08-28 20:50         ` Alexander Graf
2023-08-29 22:07         ` Stanislav Kinsburskii
2023-08-29 22:07           ` Stanislav Kinsburskii
2023-08-30  7:20           ` Alexander Graf
2023-08-30  7:20             ` Alexander Graf
2023-08-30 23:39             ` Arnd Bergmann
2023-08-30 23:39               ` Arnd Bergmann
2023-08-31  2:24               ` Stanislav Kinsburskii
2023-08-31  2:24                 ` Stanislav Kinsburskii
     [not found]   ` <64e8f6dd.050a0220.edb3c.c045SMTPIN_ADDED_BROKEN@mx.google.com>
2023-08-26  7:45     ` Greg Kroah-Hartman [this message]
2023-08-23  6:15       ` Stanislav Kinsburskii
     [not found]       ` <64ea25cd.650a0220.642cc.50e6SMTPIN_ADDED_BROKEN@mx.google.com>
2023-08-26 17:02         ` Greg Kroah-Hartman
2023-08-23  6:21           ` Stanislav Kinsburskii
     [not found]           ` <64ea3699.170a0220.13ee0.5c3aSMTPIN_ADDED_BROKEN@mx.google.com>
2023-08-26 20:04             ` Greg Kroah-Hartman
2023-08-31 14:18               ` Paolo Bonzini
2023-08-31  2:37                 ` Stanislav Kinsburskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023082633-magnetize-cupcake-accc@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=anrayabh@linux.microsoft.com \
    --cc=anthony.yznaga@oracle.com \
    --cc=arnd@arndb.de \
    --cc=derek.kiernan@amd.com \
    --cc=dragan.cvetic@amd.com \
    --cc=jgowans@amazon.com \
    --cc=jinankjain@linux.microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=madvenka@linux.microsoft.com \
    --cc=rppt@kernel.org \
    --cc=skinsburskii@linux.microsoft.com \
    --cc=stanislav.kinsburskii@gmail.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.