From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org,
syzbot+5b64180f8d9e39d3f061@syzkaller.appspotmail.com
Subject: Re: [PATCH 2/2] super: ensure valid info
Date: Mon, 28 Aug 2023 14:04:18 +0200 [thread overview]
Message-ID: <20230828120418.GB10189@lst.de> (raw)
In-Reply-To: <20230828-vfs-super-fixes-v1-2-b37a4a04a88f@kernel.org>
> For block backed filesystems notifying in pass sb->kill_sb() in
I can't parse the 'in pass' here.
> @@ -1260,6 +1270,7 @@ void kill_anon_super(struct super_block *sb)
> {
> dev_t dev = sb->s_dev;
> generic_shutdown_super(sb);
> + kill_super_notify(sb);
> free_anon_bdev(dev);
Maybe I didn't read the commit log carefully enough, but why do we
need to call kill_super_notify before free_anon_bdev and any potential
action in ->kill_sb after calling kill_anon_super here given that
we already add a call to kill_super_notify after ->kill_sb?
next prev parent reply other threads:[~2023-08-28 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 11:26 [PATCH 0/2] Small follow-up fixes for this cycle Christian Brauner
2023-08-28 11:26 ` [PATCH 1/2] super: move lockdep assert Christian Brauner
2023-08-28 11:55 ` Jan Kara
2023-08-28 12:01 ` Christoph Hellwig
2023-08-28 11:26 ` [PATCH 2/2] super: ensure valid info Christian Brauner
2023-08-28 12:04 ` Christoph Hellwig [this message]
2023-08-28 12:28 ` Christian Brauner
2023-08-28 14:03 ` Christoph Hellwig
2023-08-28 13:07 ` Jan Kara
2023-08-28 13:17 ` Christian Brauner
2023-08-29 8:15 ` [PATCH 0/2] Small follow-up fixes for this cycle Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828120418.GB10189@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=syzbot+5b64180f8d9e39d3f061@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.