From: Jakub Kicinski <kuba@kernel.org>
To: Alexandra Diupina <adiupina@astralinux.ru>
Cc: Chas Williams <3chas3@gmail.com>,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] idt77252: remove check of idt77252_init_ubr() return value
Date: Mon, 28 Aug 2023 12:40:49 -0700 [thread overview]
Message-ID: <20230828124049.6bec893f@kernel.org> (raw)
In-Reply-To: <20230828143646.8835-1-adiupina@astralinux.ru>
On Mon, 28 Aug 2023 17:36:46 +0300 Alexandra Diupina wrote:
> idt77252_init_ubr() always returns 0, so it is possible
> to remove check of its return value
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 2dde18cd1d8f ("Linux 6.5")
How is this a fix and if it was how could the release tag possibly have
caused the issue?
I think this is pointless churn, unless the error handling is buggy
in itself you should leave this code be.
--
pw-bot: reject
prev parent reply other threads:[~2023-08-28 19:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 14:36 [PATCH] idt77252: remove check of idt77252_init_ubr() return value Alexandra Diupina
2023-08-28 19:40 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828124049.6bec893f@kernel.org \
--to=kuba@kernel.org \
--cc=3chas3@gmail.com \
--cc=adiupina@astralinux.ru \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.