Re: [meta-arago][master/kirkstone][PATCH] openntpd: Update to version 6.8p1

[Denys Dmytriyenko <denis@denix.org>]

On Mon, Aug 28, 2023 at 12:19:02PM -0500, Ryan Eatmon wrote:
> 
> 
> On 8/28/2023 10:02 AM, Denys Dmytriyenko wrote:
> >On Fri, Aug 18, 2023 at 04:23:47PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
> >>The 3.9p1 version is really old, and we ran into compile issues with the
> >>latest upstream testing.  Take this opportunity to upgrade to the latest
> >>version.
> >
> >1. a proper diff would have been nice
> 
> In this case it is a remove and add.  So no diff possible as the
> receipt file name changed.  Is there a more preferred way of showing
> this kind of diff?  I think this is my first time doing a recipe
> change like this.

-M[<n>], --find-renames[=<n>]

    Detect renames. If n is specified, it is a threshold on the similarity 
index (i.e. amount of addition/deletions compared to the file's size). For 
example, -M90% means Git should consider a delete/add pair to be a rename if 
more than 90% of the file hasn't changed. Without a % sign, the number is to 
be read as a fraction, with a decimal point before it. I.e., -M5 becomes 0.5, 
and is thus the same as -M50%. Similarly, -M05 is the same as -M5%. To limit 
detection to exact renames, use -M100%. The default similarity index is 50%. 

-C[<n>], --find-copies[=<n>]

    Detect copies as well as renames. See also --find-copies-harder. If n is 
specified, it has the same meaning as for -M<n>. 

--find-copies-harder

    For performance reasons, by default, -C option finds copies only if the 
original file of the copy was modified in the same changeset. This flag makes 
the command inspect unmodified files as candidates for the source of copy. 
This is a very expensive operation for large projects, so use it with caution. 
Giving more than one -C option has the same effect.


> >2. I see LIC_FILES_CHKSUM has changed - needs a brief explanation
> 
> Since it has already been merged is an explanation in this email
> enough, or should I post another patch to explain it?
> 
> Basically, the LICENSE file disappeared from the latest tar balls of
> the source code.  So I searched through the files and found that it
> had kind of been renamed to COPYING.  Nothing nefarious about it.
> Same license, they just changed the file name.
> 
> And the tarball we were pointing at was from 2005, and the latest is
> much more recent.  Not sure I could even track down the why of the
> change.

No need for a separate patch. But the purpose of tracking license checksum in 
LIC_FILES_CHKSUM is to detect any and all changes in the license text, which 
could potentially mean legal liabilities, as the LICENSE value could no longer 
be valid or correct. Hence you want to manually check such checksum changes 
and document them in the same commit for due diligence and CYA purposes :)

And simply renaming the file won't change the checksum, so something else has 
changed in the text...


> >>Signed-off-by: Ryan Eatmon <reatmon@ti.com>
> >>---
> >>  .../openntpd/openntpd_3.9p1.bb                | 21 ---------------
> >>  .../openntpd/openntpd_6.8p1.bb                | 26 +++++++++++++++++++
> >>  2 files changed, 26 insertions(+), 21 deletions(-)
> >>  delete mode 100644 meta-arago-extras/recipes-connectivity/openntpd/openntpd_3.9p1.bb
> >>  create mode 100644 meta-arago-extras/recipes-connectivity/openntpd/openntpd_6.8p1.bb
> >>
> >>diff --git a/meta-arago-extras/recipes-connectivity/openntpd/openntpd_3.9p1.bb b/meta-arago-extras/recipes-connectivity/openntpd/openntpd_3.9p1.bb
> >>deleted file mode 100644
> >>index 008d4d33..00000000
> >>--- a/meta-arago-extras/recipes-connectivity/openntpd/openntpd_3.9p1.bb
> >>+++ /dev/null
> >>@@ -1,21 +0,0 @@
> >>-DESCRIPTION = "OpenNTPD is a FREE, easy to use implementation of the \
> >>-Network Time Protocol."
> >>-HOMEPAGE = "http://www.openntpd.org/"
> >>-SECTION = "console/network"
> >>-LICENSE = "BSD-3-Clause & ISC"
> >>-LIC_FILES_CHKSUM = "file://LICENCE;md5=4b4f5158007cc97e6b0e2325bb99854a"
> >>-
> >>-PR = "r0"
> >>-
> >>-SRC_URI = "http://mirror.ece.vt.edu/pub/OpenBSD/OpenNTPD/${P}.tar.gz"
> >>-
> >>-S = "${WORKDIR}/openntpd-${PV}"
> >>-EXTRA_OECONF = "--disable-strip"
> >>-inherit autotools
> >>-
> >>-LDFLAGS += "-lrt"
> >>-EXTRA_OECONF += "LDFLAGS="${LDFLAGS}" CFLAGS="${CFLAGS}"\
> >>-                 --with-privsep-user=root --with-privsep-path=/${prefix}"
> >>-
> >>-SRC_URI[md5sum] = "afc34175f38d08867c1403d9008600b3"
> >>-SRC_URI[sha256sum] = "83dd7c1e8ec8b4567afe49af539271b5a73562fb7a3ca51df73eccba89ec8c49"
> >>diff --git a/meta-arago-extras/recipes-connectivity/openntpd/openntpd_6.8p1.bb b/meta-arago-extras/recipes-connectivity/openntpd/openntpd_6.8p1.bb
> >>new file mode 100644
> >>index 00000000..e4aa27fc
> >>--- /dev/null
> >>+++ b/meta-arago-extras/recipes-connectivity/openntpd/openntpd_6.8p1.bb
> >>@@ -0,0 +1,26 @@
> >>+DESCRIPTION = "OpenNTPD is a FREE, easy to use implementation of the \
> >>+Network Time Protocol."
> >>+HOMEPAGE = "http://www.openntpd.org/"
> >>+SECTION = "console/network"
> >>+LICENSE = "BSD-3-Clause & ISC"
> >>+LIC_FILES_CHKSUM = "file://COPYING;md5=fe922aad2b6ad1c359cf2adfdaaab1b6"
> >>+
> >>+PR = "r0"
> >>+
> >>+SRC_URI = "https://cdn.openbsd.org/pub/OpenBSD/OpenNTPD/${P}.tar.gz"
> >>+SRC_URI[md5sum] = "7c68ce2627b2ea13f2b95db1ef4fcfc5"
> >>+SRC_URI[sha256sum] = "8582db838a399153d4a17f2a76518b638cc3020f58028575bf54127518f55a46"
> >>+
> >>+S = "${WORKDIR}/openntpd-${PV}"
> >>+inherit autotools
> >>+
> >>+LDFLAGS += "-lrt"
> >>+EXTRA_OECONF += "LDFLAGS="${LDFLAGS}" CFLAGS="${CFLAGS}"\
> >>+                 --with-privsep-user=root"
> >>+
> >>+do_install:append() {
> >>+    # don't install empty /var/run and /run to avoid conflict with base-files
> >>+    rm -rf ${D}${localstatedir}/run
> >>+    rm -rf ${D}/run
> >>+}
> >>+
> >>-- 
> >>2.17.1