From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E96DC83F14 for ; Tue, 29 Aug 2023 07:37:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230240AbjH2HhF (ORCPT ); Tue, 29 Aug 2023 03:37:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233666AbjH2Hgw (ORCPT ); Tue, 29 Aug 2023 03:36:52 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D302B5 for ; Tue, 29 Aug 2023 00:36:49 -0700 (PDT) Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9AE10814; Tue, 29 Aug 2023 09:35:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1693294525; bh=khDodRUsPVit/MS0lFs5PxPksb6sDIpGFw6T+NJF750=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d07+QGLr0n2ciFw/0Ne00qAQiQE9rslchhGj3wQollKhMeMRwZRajryDCRfyp4f1V 1lsAe7FfJpd4lA5SAItOjxIBgZZPsRiMtZqQcn/JWZz205xpuuHJelsP8tTYowQn3D gEXdqyA8g6dUCjkXu/FqACBDqiKezrFG2Lu612VI= Date: Tue, 29 Aug 2023 10:36:56 +0300 From: Laurent Pinchart To: Adam Ford Cc: Biju Das , Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter , Jonas Karlman , Jernej Skrabec , Abhinav Kumar , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Andy Shevchenko , Javier Martinez Canillas , Ahmad Fatoum , Rob Herring , Bogdan Togorean , dri-devel@lists.freedesktop.org, Geert Uytterhoeven , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 7/7] drm: adv7511: Add hpd_override_enable feature bit to struct adv7511_chip_info Message-ID: <20230829073656.GC2302@pendragon.ideasonboard.com> References: <20230813180512.307418-1-biju.das.jz@bp.renesas.com> <20230813180512.307418-8-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Fri, Aug 18, 2023 at 07:41:45AM -0500, Adam Ford wrote: > On Sun, Aug 13, 2023 at 1:06 PM Biju Das wrote: > > > > As per spec, it is allowed to pulse the HPD signal to indicate that the > > EDID information has changed. Some monitors do this when they wake up > > from standby or are enabled. When the HPD goes low the adv7511 is > > reset and the outputs are disabled which might cause the monitor to > > go to standby again. To avoid this we ignore the HPD pin for the > > first few seconds after enabling the output. On the other hand, > > adv7535 require to enable HPD Override bit for proper HPD. > > > > Add hpd_override_enable feature bit to struct adv7511_chip_info to handle > > this scenario. > > > > While at it, drop the enum adv7511_type as it is unused. > > It seems like dropping adv7511_type is unrelated to the rest of the > patch, and I think it should be split from this into its own patch Dropping the enum with its last user makes sense, but I think the series may go a bit too far by adding to the info structure bits that don't really describe logical features, but are half made up for the sole purpose of dropping the enum. I would prefer keeping the enum for the handful of places where a type check makes more sense (in my opinion). > > Signed-off-by: Biju Das > > --- > > drivers/gpu/drm/bridge/adv7511/adv7511.h | 8 +------- > > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 12 +++++------- > > 2 files changed, 6 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h > > index 627531f48f84..c523ac4c9bc8 100644 > > --- a/drivers/gpu/drm/bridge/adv7511/adv7511.h > > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h > > @@ -325,22 +325,16 @@ struct adv7511_video_config { > > struct hdmi_avi_infoframe avi_infoframe; > > }; > > > > -enum adv7511_type { > > - ADV7511, > > - ADV7533, > > - ADV7535, > > -}; > > - > > #define ADV7511_MAX_ADDRS 3 > > > > struct adv7511_chip_info { > > - enum adv7511_type type; > > unsigned long max_mode_clock; > > unsigned long max_lane_freq; > > const char * const *supply_names; > > unsigned int num_supplies; > > unsigned has_dsi:1; > > unsigned link_config:1; > > + unsigned hpd_override_enable:1; > > }; > > > > struct adv7511 { > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > > index 6974c267b1d5..7b06a0a21685 100644 > > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > > @@ -354,7 +354,7 @@ static void __adv7511_power_on(struct adv7511 *adv7511) > > * first few seconds after enabling the output. On the other hand > > * adv7535 require to enable HPD Override bit for proper HPD. > > */ > > - if (adv7511->info->type == ADV7535) > > + if (adv7511->info->hpd_override_enable) > > regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2, > > ADV7535_REG_POWER2_HPD_OVERRIDE, > > ADV7535_REG_POWER2_HPD_OVERRIDE); > > @@ -381,7 +381,7 @@ static void adv7511_power_on(struct adv7511 *adv7511) > > static void __adv7511_power_off(struct adv7511 *adv7511) > > { > > /* TODO: setup additional power down modes */ > > - if (adv7511->info->type == ADV7535) > > + if (adv7511->info->hpd_override_enable) > > regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2, > > ADV7535_REG_POWER2_HPD_OVERRIDE, 0); > > > > @@ -682,7 +682,7 @@ adv7511_detect(struct adv7511 *adv7511, struct drm_connector *connector) > > status = connector_status_disconnected; > > } else { > > /* Renable HPD sensing */ > > - if (adv7511->info->type == ADV7535) > > + if (adv7511->info->hpd_override_enable) > > regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2, > > ADV7535_REG_POWER2_HPD_OVERRIDE, > > ADV7535_REG_POWER2_HPD_OVERRIDE); > > @@ -1360,14 +1360,12 @@ static void adv7511_remove(struct i2c_client *i2c) > > } > > > > static const struct adv7511_chip_info adv7511_chip_info = { > > - .type = ADV7511, > > .supply_names = adv7511_supply_names, > > .num_supplies = ARRAY_SIZE(adv7511_supply_names), > > .link_config = 1 > > }; > > > > static const struct adv7511_chip_info adv7533_chip_info = { > > - .type = ADV7533, > > .max_mode_clock = 80000, > > .max_lane_freq = 800000, > > .supply_names = adv7533_supply_names, > > @@ -1376,12 +1374,12 @@ static const struct adv7511_chip_info adv7533_chip_info = { > > }; > > > > static const struct adv7511_chip_info adv7535_chip_info = { > > - .type = ADV7535, > > .max_mode_clock = 148500, > > .max_lane_freq = 891000, > > .supply_names = adv7533_supply_names, > > .num_supplies = ARRAY_SIZE(adv7533_supply_names), > > - .has_dsi = 1 > > + .has_dsi = 1, > > + .hpd_override_enable = 1 > > }; > > > > static const struct i2c_device_id adv7511_i2c_ids[] = { -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED8E9C83F12 for ; Tue, 29 Aug 2023 07:36:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E22310E060; Tue, 29 Aug 2023 07:36:50 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6750E10E060 for ; Tue, 29 Aug 2023 07:36:48 +0000 (UTC) Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9AE10814; Tue, 29 Aug 2023 09:35:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1693294525; bh=khDodRUsPVit/MS0lFs5PxPksb6sDIpGFw6T+NJF750=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d07+QGLr0n2ciFw/0Ne00qAQiQE9rslchhGj3wQollKhMeMRwZRajryDCRfyp4f1V 1lsAe7FfJpd4lA5SAItOjxIBgZZPsRiMtZqQcn/JWZz205xpuuHJelsP8tTYowQn3D gEXdqyA8g6dUCjkXu/FqACBDqiKezrFG2Lu612VI= Date: Tue, 29 Aug 2023 10:36:56 +0300 From: Laurent Pinchart To: Adam Ford Subject: Re: [PATCH 7/7] drm: adv7511: Add hpd_override_enable feature bit to struct adv7511_chip_info Message-ID: <20230829073656.GC2302@pendragon.ideasonboard.com> References: <20230813180512.307418-1-biju.das.jz@bp.renesas.com> <20230813180512.307418-8-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Robert Foss , Andrzej Hajda , Geert Uytterhoeven , Jonas Karlman , dri-devel@lists.freedesktop.org, Abhinav Kumar , Jernej Skrabec , Javier Martinez Canillas , linux-renesas-soc@vger.kernel.org, Andy Shevchenko , Bogdan Togorean , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Biju Das , Ahmad Fatoum Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Aug 18, 2023 at 07:41:45AM -0500, Adam Ford wrote: > On Sun, Aug 13, 2023 at 1:06 PM Biju Das wrote: > > > > As per spec, it is allowed to pulse the HPD signal to indicate that the > > EDID information has changed. Some monitors do this when they wake up > > from standby or are enabled. When the HPD goes low the adv7511 is > > reset and the outputs are disabled which might cause the monitor to > > go to standby again. To avoid this we ignore the HPD pin for the > > first few seconds after enabling the output. On the other hand, > > adv7535 require to enable HPD Override bit for proper HPD. > > > > Add hpd_override_enable feature bit to struct adv7511_chip_info to handle > > this scenario. > > > > While at it, drop the enum adv7511_type as it is unused. > > It seems like dropping adv7511_type is unrelated to the rest of the > patch, and I think it should be split from this into its own patch Dropping the enum with its last user makes sense, but I think the series may go a bit too far by adding to the info structure bits that don't really describe logical features, but are half made up for the sole purpose of dropping the enum. I would prefer keeping the enum for the handful of places where a type check makes more sense (in my opinion). > > Signed-off-by: Biju Das > > --- > > drivers/gpu/drm/bridge/adv7511/adv7511.h | 8 +------- > > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 12 +++++------- > > 2 files changed, 6 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h > > index 627531f48f84..c523ac4c9bc8 100644 > > --- a/drivers/gpu/drm/bridge/adv7511/adv7511.h > > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h > > @@ -325,22 +325,16 @@ struct adv7511_video_config { > > struct hdmi_avi_infoframe avi_infoframe; > > }; > > > > -enum adv7511_type { > > - ADV7511, > > - ADV7533, > > - ADV7535, > > -}; > > - > > #define ADV7511_MAX_ADDRS 3 > > > > struct adv7511_chip_info { > > - enum adv7511_type type; > > unsigned long max_mode_clock; > > unsigned long max_lane_freq; > > const char * const *supply_names; > > unsigned int num_supplies; > > unsigned has_dsi:1; > > unsigned link_config:1; > > + unsigned hpd_override_enable:1; > > }; > > > > struct adv7511 { > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > > index 6974c267b1d5..7b06a0a21685 100644 > > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > > @@ -354,7 +354,7 @@ static void __adv7511_power_on(struct adv7511 *adv7511) > > * first few seconds after enabling the output. On the other hand > > * adv7535 require to enable HPD Override bit for proper HPD. > > */ > > - if (adv7511->info->type == ADV7535) > > + if (adv7511->info->hpd_override_enable) > > regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2, > > ADV7535_REG_POWER2_HPD_OVERRIDE, > > ADV7535_REG_POWER2_HPD_OVERRIDE); > > @@ -381,7 +381,7 @@ static void adv7511_power_on(struct adv7511 *adv7511) > > static void __adv7511_power_off(struct adv7511 *adv7511) > > { > > /* TODO: setup additional power down modes */ > > - if (adv7511->info->type == ADV7535) > > + if (adv7511->info->hpd_override_enable) > > regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2, > > ADV7535_REG_POWER2_HPD_OVERRIDE, 0); > > > > @@ -682,7 +682,7 @@ adv7511_detect(struct adv7511 *adv7511, struct drm_connector *connector) > > status = connector_status_disconnected; > > } else { > > /* Renable HPD sensing */ > > - if (adv7511->info->type == ADV7535) > > + if (adv7511->info->hpd_override_enable) > > regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2, > > ADV7535_REG_POWER2_HPD_OVERRIDE, > > ADV7535_REG_POWER2_HPD_OVERRIDE); > > @@ -1360,14 +1360,12 @@ static void adv7511_remove(struct i2c_client *i2c) > > } > > > > static const struct adv7511_chip_info adv7511_chip_info = { > > - .type = ADV7511, > > .supply_names = adv7511_supply_names, > > .num_supplies = ARRAY_SIZE(adv7511_supply_names), > > .link_config = 1 > > }; > > > > static const struct adv7511_chip_info adv7533_chip_info = { > > - .type = ADV7533, > > .max_mode_clock = 80000, > > .max_lane_freq = 800000, > > .supply_names = adv7533_supply_names, > > @@ -1376,12 +1374,12 @@ static const struct adv7511_chip_info adv7533_chip_info = { > > }; > > > > static const struct adv7511_chip_info adv7535_chip_info = { > > - .type = ADV7535, > > .max_mode_clock = 148500, > > .max_lane_freq = 891000, > > .supply_names = adv7533_supply_names, > > .num_supplies = ARRAY_SIZE(adv7533_supply_names), > > - .has_dsi = 1 > > + .has_dsi = 1, > > + .hpd_override_enable = 1 > > }; > > > > static const struct i2c_device_id adv7511_i2c_ids[] = { -- Regards, Laurent Pinchart