All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: <Marius.Cristea@microchip.com>
Cc: <jic23@kernel.org>, <devicetree@vger.kernel.org>,
	<conor+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<lars@metafoo.de>, <linux-iio@vger.kernel.org>,
	<robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] iio: adc: adding support for MCP3564 ADC
Date: Tue, 29 Aug 2023 12:34:06 +0100	[thread overview]
Message-ID: <20230829123406.0000403f@Huawei.com> (raw)
In-Reply-To: <ae3562ee30e6d8aecae2a447cffc4ad6e8e44578.camel@microchip.com>

On Tue, 29 Aug 2023 07:29:57 +0000
<Marius.Cristea@microchip.com> wrote:

> Hi Jonathan,
> 
>    Thank you for the review.
> 
> 
> > 
> >   
> > > +
> > > +/*
> > > + * Current Source/Sink Selection Bits for Sensor Bias (source on
> > > VIN+/sink on VIN-)
> > > + */
> > > +static const int mcp3564_burnout_avail[][2] = {
> > > +     [MCP3564_CONFIG0_CS_SEL_0_0_uA] = {0, 0},
> > > +     [MCP3564_CONFIG0_CS_SEL_0_9_uA] = {0, 900},
> > > +     [MCP3564_CONFIG0_CS_SEL_3_7_uA] = {0, 3700},
> > > +     [MCP3564_CONFIG0_CS_SEL_15_uA] = {0, 15000}
	[MCP3564_CONFIG0_CS_SEL_15_uA] = { 0, 15000 }

etc

> > > +};  
> > 
> > Trivial, but I'd like brackets after the { and before the } as makes
> > things a tiny bit
> > more readable to my eye.
> > 
> >   
> 
> I'm not sure that I understood what/how to change here. Can you,
> please, give me an example?
> 
> 
> 
> Thanks,
> Marius


  reply	other threads:[~2023-08-29 11:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18 16:57 [PATCH v4 0/2] Adding support for Microchip MCP3564 ADC family marius.cristea
2023-08-18 16:57 ` [PATCH v4 1/2] dt-bindings: iio: adc: adding MCP3564 ADC marius.cristea
2023-08-19  8:25   ` Conor Dooley
2023-08-18 16:57 ` [PATCH v4 2/2] iio: adc: adding support for " marius.cristea
2023-08-28 14:16   ` Jonathan Cameron
2023-08-29  7:29     ` Marius.Cristea
2023-08-29 11:34       ` Jonathan Cameron [this message]
2023-08-29  8:22     ` Marius.Cristea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230829123406.0000403f@Huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=Marius.Cristea@microchip.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.