From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org
Subject: Re: mtd
Date: Tue, 29 Aug 2023 14:51:18 +0200 [thread overview]
Message-ID: <20230829125118.GA24767@lst.de> (raw)
In-Reply-To: <20230829-weitab-lauwarm-49c40fc85863@brauner>
On Tue, Aug 29, 2023 at 01:46:20PM +0200, Christian Brauner wrote:
> Something like the following might already be enough (IT'S A DRAFT, AND
> UNTESTED, AND PROBABLY BROKEN)?
It's probably the right thing conceptually, but it will also need
the SB_I_RETIRED from test_bdev_super_fc or even just reuse
test_bdev_super_fc after that's been renamed to be more generic.
In fact I've been wondering for a while why we even support the magic
keyed get_super - if it allocates a new super it should also have a
new dev_t. So IMHO we should stop playing stupid tricks with keys and
just declare the dev_t the key after doing all the required work for it,
that is allocating the per-instance anon dev_t in the caller.
next prev parent reply other threads:[~2023-08-29 12:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 11:46 mtd Christian Brauner
2023-08-29 12:51 ` Christoph Hellwig [this message]
2023-08-29 12:56 ` mtd Christian Brauner
2023-08-29 13:41 ` mtd Christian Brauner
2023-08-29 14:09 ` mtd Christoph Hellwig
2023-08-29 16:29 ` mtd Christian Brauner
-- strict thread matches above, loose matches on Subject: below --
2018-05-18 8:00 mtd Levente
2018-05-18 9:09 ` mtd David Oberhollenzer
2018-05-18 9:14 ` mtd Levente
2008-03-26 3:58 MTD Aneesh
2008-03-26 7:11 ` MTD Andrey Yurovsky
2005-10-12 11:02 Mtd yogesh shivabasappa
2001-10-15 12:52 mtd Amit.Lubovsky
2001-10-15 13:16 ` mtd David Woodhouse
2000-04-28 13:17 mtd Bob Canup
2000-04-29 0:32 ` mtd David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230829125118.GA24767@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.