From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/f2fs-tools: fix musl compile error
Date: Tue, 29 Aug 2023 13:03:47 +0200 [thread overview]
Message-ID: <20230829130347.2e824d96@windsurf> (raw)
In-Reply-To: <ZO2RWByvuzXKowuR@waldemar-brodkorb.de>
On Tue, 29 Aug 2023 08:34:00 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:
> musl 1.2.4 removed the lseek64 function, but kept a definition of lseek64
> when _LARGEFILE64_SOURCE is defined.
>
> Add patch from upstream to kill the usage of lseek64.
>
> There is no need to backport it to older Buildroot releases, because musl 1.2.4
> is not part of any release.
>
> Fixes:
> - http://autobuild.buildroot.net/results/17f/17f4ea7d62581cf8c574deeb98e1785220d5bd3f
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
> v1 -> v2:
> - add a patch from upstream to kill lseek64 entirely
> ---
> ...ls-convert-to-lseek-and-kill-lseek64.patch | 459 ++++++++++++++++++
> 1 file changed, 459 insertions(+)
> create mode 100644 package/f2fs-tools/0001-f2fs-tools-convert-to-lseek-and-kill-lseek64.patch
I like this much better than your previously proposed fix. Applied to
master. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-08-29 11:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 6:34 [Buildroot] [PATCH v2] package/f2fs-tools: fix musl compile error Waldemar Brodkorb
2023-08-29 11:03 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230829130347.2e824d96@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.