From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB3E0C71153 for ; Tue, 29 Aug 2023 14:47:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236182AbjH2Oqm (ORCPT ); Tue, 29 Aug 2023 10:46:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237104AbjH2Oqg (ORCPT ); Tue, 29 Aug 2023 10:46:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7950E1A3; Tue, 29 Aug 2023 07:46:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 00D9061B76; Tue, 29 Aug 2023 14:46:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 949A6C433C7; Tue, 29 Aug 2023 14:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693320385; bh=Wu0JrSkHxk64keNMxXEukarfI1FylnbMH++UFrVPUQU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pNxCY4W5J7TVKTnWEpIH6LL/ofOv7VXNzp7DRUziVaVwpCbs/wNLFZqBIpute9oUv KB+tsMzxlB6CKTI0qEH8qziTykAlmGoIhifn2fZmLALILd8k6UbVXRcEqEhfpZfMVA lnkKxJ7a5uMe1nnJDrAabr//MOvqcFTDpDVfY2/aPyeAtymh8I8H1s9TJqiEAMegGQ BKlBQ1xwFIPYVC2kUnDZ2UtUd8uKwEchume7olFB93j1dgz6xD6y0AwuCm0VlKNsy9 v2eUerAgHDzYB4hMSrlMpyC9M4KbOB9aPlOg1aGSLqQXYCQUEmlAoVyEkVVxkx8/JZ OqDOsElEYvMPQ== Date: Tue, 29 Aug 2023 20:16:06 +0530 From: Manivannan Sadhasivam To: Rob Herring Cc: Manivannan Sadhasivam , Jim Quinlan , Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Krzysztof Kozlowski , Conor Dooley , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v5 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property Message-ID: <20230829144606.GB33903@thinkpad> References: <20230508220126.16241-1-jim2101024@gmail.com> <20230508220126.16241-2-jim2101024@gmail.com> <20230823074330.GF3737@thinkpad> <20230823181650.GL3737@thinkpad> <20230825064505.GA6005@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Aug 29, 2023 at 07:22:18AM -0500, Rob Herring wrote: > On Fri, Aug 25, 2023 at 1:45 AM Manivannan Sadhasivam wrote: > > > > On Thu, Aug 24, 2023 at 10:55:02AM -0400, Jim Quinlan wrote: > > > On Wed, Aug 23, 2023 at 2:17 PM Manivannan Sadhasivam wrote: > > > > > > > > On Wed, Aug 23, 2023 at 09:09:25AM -0400, Jim Quinlan wrote: > > > > > On Wed, Aug 23, 2023 at 3:43 AM Manivannan Sadhasivam wrote: > > > > > > > > > > > > On Mon, May 08, 2023 at 06:01:21PM -0400, Jim Quinlan wrote: > > > > > > > This commit adds the boolean "brcm,enable-l1ss" property: > > > > > > > > > > > > > > The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs -- > > > > > > > requires the driver probe() to deliberately place the HW one of three > > > > > > > CLKREQ# modes: > > > > > > > > > > > > > > (a) CLKREQ# driven by the RC unconditionally > > > > > > > (b) CLKREQ# driven by the EP for ASPM L0s, L1 > > > > > > > (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS). > > > > > > > > > > > > > > The HW+driver can tell the difference between downstream devices that > > > > > > > need (a) and (b), but does not know when to configure (c). All devices > > > > > > > should work fine when the driver chooses (a) or (b), but (c) may be > > > > > > > desired to realize the extra power savings that L1SS offers. So we > > > > > > > introduce the boolean "brcm,enable-l1ss" property to inform the driver > > > > > > > that (c) is desired. Setting this property only makes sense when the > > > > > > > downstream device is L1SS-capable and the OS is configured to activate > > > > > > > this mode (e.g. policy==powersupersave). > > > > > > > > > > > > > > This property is already present in the Raspian version of Linux, but the > > > > > > > upstream driver implementation that follows adds more details and > > > > > > > discerns between (a) and (b). > > > > > > > > > > > > > > Signed-off-by: Jim Quinlan > > > > > > > Reviewed-by: Rob Herring > > > > > > > --- > > > > > > > Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++ > > > > > > > 1 file changed, 9 insertions(+) > > > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > > > > > > index 7e15aae7d69e..8b61c2179608 100644 > > > > > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > > > > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > > > > > > @@ -64,6 +64,15 @@ properties: > > > > > > > > > > > > > > aspm-no-l0s: true > > > > > > > > > > > > > > + brcm,enable-l1ss: > > > > > > > + description: Indicates that PCIe L1SS power savings > > > > > > > + are desired, the downstream device is L1SS-capable, and the > > > > > > > + OS has been configured to enable this mode. For boards > > > > > > > + using a mini-card connector, this mode may not meet the > > > > > > > + TCRLon maximum time of 400ns, as specified in 3.2.5.2.2 > > > > > > > + of the PCI Express Mini CEM 2.0 specification. > > > > > > > > > > > > As Lorenzo said, this property doesn't belong in DT. DT is supposed to specify > > > > > > the hardware capability and not system/OS behavior. > > > > > > > > > > The "brcm,enable-l1ss" does NOT configure the OS behavior. > > > > > It sets or not a mode bit to enable l1SS HW, whether or not the OS is > > > > > configured for L1SS. > > > > > It compensates for a problem in the PCIe core: the HW is not capable > > > > > of dynamically > > > > > switching between ASPM modes powersave and superpowersave. I am actively > > > > > advocating for our HW to change but that will take years. > > > > > > > > > > > > > Okay, then I would say that the property name and commit message were a bit > > > > misleading. > > > > > > > > I had briefly gone through the driver patch now. As per my understanding, you > > > > have 2 modes in hw: > > > > > > > > 1. Clock PM - Refclk will be turned off by the host if CLKREQ# is deasserted by > > > > the device (driving high) when the link is in L1. > > > > > > > > 2. L1SS - CLKREQ# will be used to decide L1SS entry and exit by the host. > > > > > > No, there are three, as enumerated in the commit message of > > > "PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device" > > > > > > > Yeah, another one is refclk always on. > > > > > > > > > > Till now the driver only supported Clock PM through mode (1) but for supporting > > > > L1SS you need to enable mode (2). And you are using this property to select mode > > > > (2) when the L1SS supported devices are connected to the slot. Also, by > > > > selecting this mode, you are loosing the benefit of mode (1) as both are not > > > > compatible. > > > > > > > > My suggestion would be to just drop mode (1) and use mode (2) in the driver as > > > > most of the recent devices should support L1SS (ofc there are exemptions). > > > The disadvantage of this, as stated by the PCIe core HW designer, was > > > that "doing so means > > > we cannot enable the Cock Power Management capability since it may run afoul of > > > the Tclron requirement." > > > > > > > Ok. > > > > > I will attempt to press him on exactly what configurations and form > > > factors would be > > > vulnerable to this -- he was so convinced that it was a danger that he > > > is against > > > making L1SS mode the default. > > > > > > > Hmm. After looking at this problem in detail, it looks to me that you can still > > use DT but not with the property you proposed. Since these are hardware modes, > > you can have a single DT property that specifies the mode that the driver can > > use to configure the hw. It is similar to "phy-mode" property we have for the > > network controllers. > > > > So you should have the property defined as below in binding: > > > > brcm,clkreq-mode: > > $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [ 0, 1, 2 ] > > Is this really Broadcom specific? > AFAIU, rest of the controllers do not have issues supporting Clock PM and L1SS in hw. Neither does the spec define any incompatibility. So to me, this looks like Broadcom specific. - Mani > Rob -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A340CC71153 for ; Tue, 29 Aug 2023 14:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rlVgGdzz00WSZX9xy7j+E4izTmVzow8ca0mbxPJR5IE=; b=mXsxI+hOxGVqv4 G3rbWD1ogPExPvzZ7rYnpssA543COhQFw7WYfVdJ7/wEosmL9+ZRCUYcQ+k9QqEwUqUYoe2jrUWaY fdH4gWHm2EG7S7TqQWYyYE0roMfUFwXA/GUL7DbKvs1bggsxirFMHA6Kk2QE7XhF9pPiFdCzso66l LJAUCaZ7RZnRoeyDRAVZozi7ZLXBfbrKXE1kQ2Umra/JF6EaMvRlOIFUJedYLp0hW9r8dDsVVRoUe VTz/8pYbngWmiCzzfDGZvkT1tjRLL/pc8Y6EVdZAUsWhzYPhVJ6ILjKrWyIpYQEAZ2CJsCtjVoaJn h8aY9NsAzzh56CnuoyzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qazzC-00Biu8-2t; Tue, 29 Aug 2023 14:46:30 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qazz9-00BitU-0v; Tue, 29 Aug 2023 14:46:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 010C361680; Tue, 29 Aug 2023 14:46:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 949A6C433C7; Tue, 29 Aug 2023 14:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693320385; bh=Wu0JrSkHxk64keNMxXEukarfI1FylnbMH++UFrVPUQU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pNxCY4W5J7TVKTnWEpIH6LL/ofOv7VXNzp7DRUziVaVwpCbs/wNLFZqBIpute9oUv KB+tsMzxlB6CKTI0qEH8qziTykAlmGoIhifn2fZmLALILd8k6UbVXRcEqEhfpZfMVA lnkKxJ7a5uMe1nnJDrAabr//MOvqcFTDpDVfY2/aPyeAtymh8I8H1s9TJqiEAMegGQ BKlBQ1xwFIPYVC2kUnDZ2UtUd8uKwEchume7olFB93j1dgz6xD6y0AwuCm0VlKNsy9 v2eUerAgHDzYB4hMSrlMpyC9M4KbOB9aPlOg1aGSLqQXYCQUEmlAoVyEkVVxkx8/JZ OqDOsElEYvMPQ== Date: Tue, 29 Aug 2023 20:16:06 +0530 From: Manivannan Sadhasivam To: Rob Herring Cc: Manivannan Sadhasivam , Jim Quinlan , Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Krzysztof Kozlowski , Conor Dooley , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v5 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property Message-ID: <20230829144606.GB33903@thinkpad> References: <20230508220126.16241-1-jim2101024@gmail.com> <20230508220126.16241-2-jim2101024@gmail.com> <20230823074330.GF3737@thinkpad> <20230823181650.GL3737@thinkpad> <20230825064505.GA6005@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230829_074627_432048_2EE6652D X-CRM114-Status: GOOD ( 55.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBdWcgMjksIDIwMjMgYXQgMDc6MjI6MThBTSAtMDUwMCwgUm9iIEhlcnJpbmcgd3Jv dGU6Cj4gT24gRnJpLCBBdWcgMjUsIDIwMjMgYXQgMTo0NeKAr0FNIE1hbml2YW5uYW4gU2FkaGFz aXZhbSA8bWFuaUBrZXJuZWwub3JnPiB3cm90ZToKPiA+Cj4gPiBPbiBUaHUsIEF1ZyAyNCwgMjAy MyBhdCAxMDo1NTowMkFNIC0wNDAwLCBKaW0gUXVpbmxhbiB3cm90ZToKPiA+ID4gT24gV2VkLCBB dWcgMjMsIDIwMjMgYXQgMjoxN+KAr1BNIE1hbml2YW5uYW4gU2FkaGFzaXZhbSA8bWFuaUBrZXJu ZWwub3JnPiB3cm90ZToKPiA+ID4gPgo+ID4gPiA+IE9uIFdlZCwgQXVnIDIzLCAyMDIzIGF0IDA5 OjA5OjI1QU0gLTA0MDAsIEppbSBRdWlubGFuIHdyb3RlOgo+ID4gPiA+ID4gT24gV2VkLCBBdWcg MjMsIDIwMjMgYXQgMzo0M+KAr0FNIE1hbml2YW5uYW4gU2FkaGFzaXZhbSA8bWFuaUBrZXJuZWwu b3JnPiB3cm90ZToKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gT24gTW9uLCBNYXkgMDgsIDIwMjMg YXQgMDY6MDE6MjFQTSAtMDQwMCwgSmltIFF1aW5sYW4gd3JvdGU6Cj4gPiA+ID4gPiA+ID4gVGhp cyBjb21taXQgYWRkcyB0aGUgYm9vbGVhbiAiYnJjbSxlbmFibGUtbDFzcyIgcHJvcGVydHk6Cj4g PiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiAgIFRoZSBCcm9hZGNvbSBTVEIvQ00gUENJZSBIVyAt LSBhIGNvcmUgdGhhdCBpcyBhbHNvIHVzZWQgYnkgUlBpIFNPQ3MgLS0KPiA+ID4gPiA+ID4gPiAg IHJlcXVpcmVzIHRoZSBkcml2ZXIgcHJvYmUoKSB0byBkZWxpYmVyYXRlbHkgcGxhY2UgdGhlIEhX IG9uZSBvZiB0aHJlZQo+ID4gPiA+ID4gPiA+ICAgQ0xLUkVRIyBtb2RlczoKPiA+ID4gPiA+ID4g Pgo+ID4gPiA+ID4gPiA+ICAgKGEpIENMS1JFUSMgZHJpdmVuIGJ5IHRoZSBSQyB1bmNvbmRpdGlv bmFsbHkKPiA+ID4gPiA+ID4gPiAgIChiKSBDTEtSRVEjIGRyaXZlbiBieSB0aGUgRVAgZm9yIEFT UE0gTDBzLCBMMQo+ID4gPiA+ID4gPiA+ICAgKGMpIEJpZGlyZWN0aW9uYWwgQ0xLUkVRIywgYXMg dXNlZCBmb3IgTDEgU3Vic3RhdGVzIChMMVNTKS4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ ICAgVGhlIEhXK2RyaXZlciBjYW4gdGVsbCB0aGUgZGlmZmVyZW5jZSBiZXR3ZWVuIGRvd25zdHJl YW0gZGV2aWNlcyB0aGF0Cj4gPiA+ID4gPiA+ID4gICBuZWVkIChhKSBhbmQgKGIpLCBidXQgZG9l cyBub3Qga25vdyB3aGVuIHRvIGNvbmZpZ3VyZSAoYykuICBBbGwgZGV2aWNlcwo+ID4gPiA+ID4g PiA+ICAgc2hvdWxkIHdvcmsgZmluZSB3aGVuIHRoZSBkcml2ZXIgY2hvb3NlcyAoYSkgb3IgKGIp LCBidXQgKGMpIG1heSBiZQo+ID4gPiA+ID4gPiA+ICAgZGVzaXJlZCB0byByZWFsaXplIHRoZSBl eHRyYSBwb3dlciBzYXZpbmdzIHRoYXQgTDFTUyBvZmZlcnMuICBTbyB3ZQo+ID4gPiA+ID4gPiA+ ICAgaW50cm9kdWNlIHRoZSBib29sZWFuICJicmNtLGVuYWJsZS1sMXNzIiBwcm9wZXJ0eSB0byBp bmZvcm0gdGhlIGRyaXZlcgo+ID4gPiA+ID4gPiA+ICAgdGhhdCAoYykgaXMgZGVzaXJlZC4gIFNl dHRpbmcgdGhpcyBwcm9wZXJ0eSBvbmx5IG1ha2VzIHNlbnNlIHdoZW4gdGhlCj4gPiA+ID4gPiA+ ID4gICBkb3duc3RyZWFtIGRldmljZSBpcyBMMVNTLWNhcGFibGUgYW5kIHRoZSBPUyBpcyBjb25m aWd1cmVkIHRvIGFjdGl2YXRlCj4gPiA+ID4gPiA+ID4gICB0aGlzIG1vZGUgKGUuZy4gcG9saWN5 PT1wb3dlcnN1cGVyc2F2ZSkuCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiAgIFRoaXMgcHJv cGVydHkgaXMgYWxyZWFkeSBwcmVzZW50IGluIHRoZSBSYXNwaWFuIHZlcnNpb24gb2YgTGludXgs IGJ1dCB0aGUKPiA+ID4gPiA+ID4gPiAgIHVwc3RyZWFtIGRyaXZlciBpbXBsZW1lbnRhdGlvbiB0 aGF0IGZvbGxvd3MgYWRkcyBtb3JlIGRldGFpbHMgYW5kCj4gPiA+ID4gPiA+ID4gICBkaXNjZXJu cyBiZXR3ZWVuIChhKSBhbmQgKGIpLgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gU2lnbmVk LW9mZi1ieTogSmltIFF1aW5sYW4gPGppbTIxMDEwMjRAZ21haWwuY29tPgo+ID4gPiA+ID4gPiA+ IFJldmlld2VkLWJ5OiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPgo+ID4gPiA+ID4gPiA+ IC0tLQo+ID4gPiA+ID4gPiA+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNp L2JyY20sc3RiLXBjaWUueWFtbCB8IDkgKysrKysrKysrCj4gPiA+ID4gPiA+ID4gIDEgZmlsZSBj aGFuZ2VkLCA5IGluc2VydGlvbnMoKykKPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IGRpZmYg LS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2JyY20sc3RiLXBj aWUueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wY2kvYnJjbSxzdGIt cGNpZS55YW1sCj4gPiA+ID4gPiA+ID4gaW5kZXggN2UxNWFhZTdkNjllLi44YjYxYzIxNzk2MDgg MTAwNjQ0Cj4gPiA+ID4gPiA+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL3BjaS9icmNtLHN0Yi1wY2llLnlhbWwKPiA+ID4gPiA+ID4gPiArKysgYi9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2JyY20sc3RiLXBjaWUueWFtbAo+ID4gPiA+ID4g PiA+IEBAIC02NCw2ICs2NCwxNSBAQCBwcm9wZXJ0aWVzOgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4g PiA+ID4gICAgYXNwbS1uby1sMHM6IHRydWUKPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ICsg IGJyY20sZW5hYmxlLWwxc3M6Cj4gPiA+ID4gPiA+ID4gKyAgICBkZXNjcmlwdGlvbjogSW5kaWNh dGVzIHRoYXQgUENJZSBMMVNTIHBvd2VyIHNhdmluZ3MKPiA+ID4gPiA+ID4gPiArICAgICAgYXJl IGRlc2lyZWQsIHRoZSBkb3duc3RyZWFtIGRldmljZSBpcyBMMVNTLWNhcGFibGUsIGFuZCB0aGUK PiA+ID4gPiA+ID4gPiArICAgICAgT1MgaGFzIGJlZW4gY29uZmlndXJlZCB0byBlbmFibGUgdGhp cyBtb2RlLiAgRm9yIGJvYXJkcwo+ID4gPiA+ID4gPiA+ICsgICAgICB1c2luZyBhIG1pbmktY2Fy ZCBjb25uZWN0b3IsIHRoaXMgbW9kZSBtYXkgbm90IG1lZXQgdGhlCj4gPiA+ID4gPiA+ID4gKyAg ICAgIFRDUkxvbiBtYXhpbXVtIHRpbWUgb2YgNDAwbnMsIGFzIHNwZWNpZmllZCBpbiAzLjIuNS4y LjIKPiA+ID4gPiA+ID4gPiArICAgICAgb2YgdGhlIFBDSSBFeHByZXNzIE1pbmkgQ0VNIDIuMCBz cGVjaWZpY2F0aW9uLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBBcyBMb3JlbnpvIHNhaWQsIHRo aXMgcHJvcGVydHkgZG9lc24ndCBiZWxvbmcgaW4gRFQuIERUIGlzIHN1cHBvc2VkIHRvIHNwZWNp ZnkKPiA+ID4gPiA+ID4gdGhlIGhhcmR3YXJlIGNhcGFiaWxpdHkgYW5kIG5vdCBzeXN0ZW0vT1Mg YmVoYXZpb3IuCj4gPiA+ID4gPgo+ID4gPiA+ID4gVGhlICJicmNtLGVuYWJsZS1sMXNzIiBkb2Vz IE5PVCBjb25maWd1cmUgdGhlIE9TIGJlaGF2aW9yLgo+ID4gPiA+ID4gSXQgc2V0cyBvciBub3Qg YSBtb2RlIGJpdCB0byBlbmFibGUgbDFTUyBIVywgd2hldGhlciBvciBub3QgdGhlIE9TIGlzCj4g PiA+ID4gPiBjb25maWd1cmVkIGZvciBMMVNTLgo+ID4gPiA+ID4gSXQgY29tcGVuc2F0ZXMgZm9y IGEgcHJvYmxlbSBpbiB0aGUgUENJZSBjb3JlOiB0aGUgSFcgaXMgbm90IGNhcGFibGUKPiA+ID4g PiA+IG9mIGR5bmFtaWNhbGx5Cj4gPiA+ID4gPiBzd2l0Y2hpbmcgYmV0d2VlbiBBU1BNIG1vZGVz IHBvd2Vyc2F2ZSBhbmQgc3VwZXJwb3dlcnNhdmUuICBJIGFtIGFjdGl2ZWx5Cj4gPiA+ID4gPiBh ZHZvY2F0aW5nIGZvciBvdXIgSFcgdG8gY2hhbmdlIGJ1dCB0aGF0IHdpbGwgdGFrZSB5ZWFycy4K PiA+ID4gPiA+Cj4gPiA+ID4KPiA+ID4gPiBPa2F5LCB0aGVuIEkgd291bGQgc2F5IHRoYXQgdGhl IHByb3BlcnR5IG5hbWUgYW5kIGNvbW1pdCBtZXNzYWdlIHdlcmUgYSBiaXQKPiA+ID4gPiBtaXNs ZWFkaW5nLgo+ID4gPiA+Cj4gPiA+ID4gSSBoYWQgYnJpZWZseSBnb25lIHRocm91Z2ggdGhlIGRy aXZlciBwYXRjaCBub3cuIEFzIHBlciBteSB1bmRlcnN0YW5kaW5nLCB5b3UKPiA+ID4gPiBoYXZl IDIgbW9kZXMgaW4gaHc6Cj4gPiA+ID4KPiA+ID4gPiAxLiBDbG9jayBQTSAtIFJlZmNsayB3aWxs IGJlIHR1cm5lZCBvZmYgYnkgdGhlIGhvc3QgaWYgQ0xLUkVRIyBpcyBkZWFzc2VydGVkIGJ5Cj4g PiA+ID4gdGhlIGRldmljZSAoZHJpdmluZyBoaWdoKSB3aGVuIHRoZSBsaW5rIGlzIGluIEwxLgo+ ID4gPiA+Cj4gPiA+ID4gMi4gTDFTUyAtIENMS1JFUSMgd2lsbCBiZSB1c2VkIHRvIGRlY2lkZSBM MVNTIGVudHJ5IGFuZCBleGl0IGJ5IHRoZSBob3N0Lgo+ID4gPgo+ID4gPiBObywgdGhlcmUgYXJl IHRocmVlLCBhcyBlbnVtZXJhdGVkIGluIHRoZSBjb21taXQgbWVzc2FnZSBvZgo+ID4gPiAiUENJ OiBicmNtc3RiOiBDb25maWd1cmUgSFcgQ0xLUkVRIyBtb2RlIGFwcHJvcHJpYXRlIGZvciBkb3du c3RyZWFtIGRldmljZSIKPiA+ID4KPiA+Cj4gPiBZZWFoLCBhbm90aGVyIG9uZSBpcyByZWZjbGsg YWx3YXlzIG9uLgo+ID4KPiA+ID4gPgo+ID4gPiA+IFRpbGwgbm93IHRoZSBkcml2ZXIgb25seSBz dXBwb3J0ZWQgQ2xvY2sgUE0gdGhyb3VnaCBtb2RlICgxKSBidXQgZm9yIHN1cHBvcnRpbmcKPiA+ ID4gPiBMMVNTIHlvdSBuZWVkIHRvIGVuYWJsZSBtb2RlICgyKS4gQW5kIHlvdSBhcmUgdXNpbmcg dGhpcyBwcm9wZXJ0eSB0byBzZWxlY3QgbW9kZQo+ID4gPiA+ICgyKSB3aGVuIHRoZSBMMVNTIHN1 cHBvcnRlZCBkZXZpY2VzIGFyZSBjb25uZWN0ZWQgdG8gdGhlIHNsb3QuIEFsc28sIGJ5Cj4gPiA+ ID4gc2VsZWN0aW5nIHRoaXMgbW9kZSwgeW91IGFyZSBsb29zaW5nIHRoZSBiZW5lZml0IG9mIG1v ZGUgKDEpIGFzIGJvdGggYXJlIG5vdAo+ID4gPiA+IGNvbXBhdGlibGUuCj4gPiA+ID4KPiA+ID4g PiBNeSBzdWdnZXN0aW9uIHdvdWxkIGJlIHRvIGp1c3QgZHJvcCBtb2RlICgxKSBhbmQgdXNlIG1v ZGUgKDIpIGluIHRoZSBkcml2ZXIgYXMKPiA+ID4gPiBtb3N0IG9mIHRoZSByZWNlbnQgZGV2aWNl cyBzaG91bGQgc3VwcG9ydCBMMVNTIChvZmMgdGhlcmUgYXJlIGV4ZW1wdGlvbnMpLgo+ID4gPiBU aGUgZGlzYWR2YW50YWdlIG9mIHRoaXMsIGFzIHN0YXRlZCBieSB0aGUgUENJZSBjb3JlIEhXIGRl c2lnbmVyLCB3YXMKPiA+ID4gdGhhdCAiZG9pbmcgc28gbWVhbnMKPiA+ID4gd2UgY2Fubm90IGVu YWJsZSB0aGUgQ29jayBQb3dlciBNYW5hZ2VtZW50IGNhcGFiaWxpdHkgc2luY2UgaXQgbWF5IHJ1 biBhZm91bCBvZgo+ID4gPiB0aGUgVGNscm9uIHJlcXVpcmVtZW50LiIKPiA+ID4KPiA+Cj4gPiBP ay4KPiA+Cj4gPiA+IEkgd2lsbCBhdHRlbXB0IHRvIHByZXNzIGhpbSBvbiBleGFjdGx5IHdoYXQg Y29uZmlndXJhdGlvbnMgYW5kIGZvcm0KPiA+ID4gZmFjdG9ycyB3b3VsZCBiZQo+ID4gPiB2dWxu ZXJhYmxlIHRvIHRoaXMgLS0gaGUgd2FzIHNvIGNvbnZpbmNlZCB0aGF0IGl0IHdhcyBhIGRhbmdl ciB0aGF0IGhlCj4gPiA+IGlzIGFnYWluc3QKPiA+ID4gbWFraW5nIEwxU1MgbW9kZSB0aGUgZGVm YXVsdC4KPiA+ID4KPiA+Cj4gPiBIbW0uIEFmdGVyIGxvb2tpbmcgYXQgdGhpcyBwcm9ibGVtIGlu IGRldGFpbCwgaXQgbG9va3MgdG8gbWUgdGhhdCB5b3UgY2FuIHN0aWxsCj4gPiB1c2UgRFQgYnV0 IG5vdCB3aXRoIHRoZSBwcm9wZXJ0eSB5b3UgcHJvcG9zZWQuIFNpbmNlIHRoZXNlIGFyZSBoYXJk d2FyZSBtb2RlcywKPiA+IHlvdSBjYW4gaGF2ZSBhIHNpbmdsZSBEVCBwcm9wZXJ0eSB0aGF0IHNw ZWNpZmllcyB0aGUgbW9kZSB0aGF0IHRoZSBkcml2ZXIgY2FuCj4gPiB1c2UgdG8gY29uZmlndXJl IHRoZSBody4gSXQgaXMgc2ltaWxhciB0byAicGh5LW1vZGUiIHByb3BlcnR5IHdlIGhhdmUgZm9y IHRoZQo+ID4gbmV0d29yayBjb250cm9sbGVycy4KPiA+Cj4gPiBTbyB5b3Ugc2hvdWxkIGhhdmUg dGhlIHByb3BlcnR5IGRlZmluZWQgYXMgYmVsb3cgaW4gYmluZGluZzoKPiA+Cj4gPiBicmNtLGNs a3JlcS1tb2RlOgo+ID4gICAkcmVmOiAvc2NoZW1hcy90eXBlcy55YW1sIy9kZWZpbml0aW9ucy91 aW50MzIKPiA+ICAgZW51bTogWyAwLCAxLCAyIF0KPiAKPiBJcyB0aGlzIHJlYWxseSBCcm9hZGNv bSBzcGVjaWZpYz8KPiAKCkFGQUlVLCByZXN0IG9mIHRoZSBjb250cm9sbGVycyBkbyBub3QgaGF2 ZSBpc3N1ZXMgc3VwcG9ydGluZyBDbG9jayBQTSBhbmQgTDFTUwppbiBody4gTmVpdGhlciBkb2Vz IHRoZSBzcGVjIGRlZmluZSBhbnkgaW5jb21wYXRpYmlsaXR5LiBTbyB0byBtZSwgdGhpcyBsb29r cwpsaWtlIEJyb2FkY29tIHNwZWNpZmljLgoKLSBNYW5pCgo+IFJvYgoKLS0gCuCuruCuo+Cuv+Cu teCuo+CvjeCuo+CuqeCvjSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK