All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC v1 1/4] nvmet-trace: avoid dereferencing pointer too early
Date: Wed, 30 Aug 2023 03:55:26 +0800	[thread overview]
Message-ID: <202308300317.0x6Otev1-lkp@intel.com> (raw)
In-Reply-To: <20230829091350.16156-2-dwagner@suse.de>

Hi Daniel,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on hch-configfs/for-next]
[also build test ERROR on linus/master v6.5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Daniel-Wagner/nvmet-trace-avoid-dereferencing-pointer-too-early/20230829-171734
base:   git://git.infradead.org/users/hch/configfs.git for-next
patch link:    https://lore.kernel.org/r/20230829091350.16156-2-dwagner%40suse.de
patch subject: [RFC v1 1/4] nvmet-trace: avoid dereferencing pointer too early
config: i386-randconfig-014-20230830 (https://download.01.org/0day-ci/archive/20230830/202308300317.0x6Otev1-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230830/202308300317.0x6Otev1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308300317.0x6Otev1-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: drivers/nvme/target/core.o: in function `trace_raw_output_nvmet_req_init':
>> drivers/nvme/target/./trace.h:63: undefined reference to `nvmet_trace_ctrl_id'
   ld: drivers/nvme/target/core.o: in function `trace_raw_output_nvmet_req_complete':
   drivers/nvme/target/./trace.h:105: undefined reference to `nvmet_trace_ctrl_id'


vim +63 drivers/nvme/target/./trace.h

a5448fdc469d67 Minwoo Im          2019-06-12   62  
a5448fdc469d67 Minwoo Im          2019-06-12  @63  TRACE_EVENT(nvmet_req_init,
a5448fdc469d67 Minwoo Im          2019-06-12   64  	TP_PROTO(struct nvmet_req *req, struct nvme_command *cmd),
a5448fdc469d67 Minwoo Im          2019-06-12   65  	TP_ARGS(req, cmd),
a5448fdc469d67 Minwoo Im          2019-06-12   66  	TP_STRUCT__entry(
a5448fdc469d67 Minwoo Im          2019-06-12   67  		__field(struct nvme_command *, cmd)
954c6dd2aaf3a8 Daniel Wagner      2023-08-29   68  		__field(u16, ctrl_id)
a5448fdc469d67 Minwoo Im          2019-06-12   69  		__array(char, disk, DISK_NAME_LEN)
a5448fdc469d67 Minwoo Im          2019-06-12   70  		__field(int, qid)
a5448fdc469d67 Minwoo Im          2019-06-12   71  		__field(u16, cid)
a5448fdc469d67 Minwoo Im          2019-06-12   72  		__field(u8, opcode)
a5448fdc469d67 Minwoo Im          2019-06-12   73  		__field(u8, fctype)
a5448fdc469d67 Minwoo Im          2019-06-12   74  		__field(u8, flags)
a5448fdc469d67 Minwoo Im          2019-06-12   75  		__field(u32, nsid)
a5448fdc469d67 Minwoo Im          2019-06-12   76  		__field(u64, metadata)
a5448fdc469d67 Minwoo Im          2019-06-12   77  		__array(u8, cdw10, 24)
a5448fdc469d67 Minwoo Im          2019-06-12   78  	),
a5448fdc469d67 Minwoo Im          2019-06-12   79  	TP_fast_assign(
a5448fdc469d67 Minwoo Im          2019-06-12   80  		__entry->cmd = cmd;
954c6dd2aaf3a8 Daniel Wagner      2023-08-29   81  		__entry->ctrl_id = nvmet_req_to_ctrl_id(req);
3c3751f2daf667 Chaitanya Kulkarni 2020-10-22   82  		__assign_req_name(__entry->disk, req);
a5448fdc469d67 Minwoo Im          2019-06-12   83  		__entry->qid = req->sq->qid;
a5448fdc469d67 Minwoo Im          2019-06-12   84  		__entry->cid = cmd->common.command_id;
a5448fdc469d67 Minwoo Im          2019-06-12   85  		__entry->opcode = cmd->common.opcode;
a5448fdc469d67 Minwoo Im          2019-06-12   86  		__entry->fctype = cmd->fabrics.fctype;
a5448fdc469d67 Minwoo Im          2019-06-12   87  		__entry->flags = cmd->common.flags;
a5448fdc469d67 Minwoo Im          2019-06-12   88  		__entry->nsid = le32_to_cpu(cmd->common.nsid);
a5448fdc469d67 Minwoo Im          2019-06-12   89  		__entry->metadata = le64_to_cpu(cmd->common.metadata);
a5448fdc469d67 Minwoo Im          2019-06-12   90  		memcpy(__entry->cdw10, &cmd->common.cdw10,
a5448fdc469d67 Minwoo Im          2019-06-12   91  			sizeof(__entry->cdw10));
a5448fdc469d67 Minwoo Im          2019-06-12   92  	),
a5448fdc469d67 Minwoo Im          2019-06-12   93  	TP_printk("nvmet%s: %sqid=%d, cmdid=%u, nsid=%u, flags=%#x, "
a5448fdc469d67 Minwoo Im          2019-06-12   94  		  "meta=%#llx, cmd=(%s, %s)",
954c6dd2aaf3a8 Daniel Wagner      2023-08-29   95  		__print_ctrl_id(__entry->ctrl_id),
a5448fdc469d67 Minwoo Im          2019-06-12   96  		__print_disk_name(__entry->disk),
a5448fdc469d67 Minwoo Im          2019-06-12   97  		__entry->qid, __entry->cid, __entry->nsid,
a5448fdc469d67 Minwoo Im          2019-06-12   98  		__entry->flags, __entry->metadata,
a5448fdc469d67 Minwoo Im          2019-06-12   99  		show_opcode_name(__entry->qid, __entry->opcode,
a5448fdc469d67 Minwoo Im          2019-06-12  100  				__entry->fctype),
a5448fdc469d67 Minwoo Im          2019-06-12  101  		parse_nvme_cmd(__entry->qid, __entry->opcode,
a5448fdc469d67 Minwoo Im          2019-06-12  102  				__entry->fctype, __entry->cdw10))
a5448fdc469d67 Minwoo Im          2019-06-12  103  );
a5448fdc469d67 Minwoo Im          2019-06-12  104  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2023-08-29 19:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29  9:13 [RFC v1 0/4] nvmet-fc blktests & autoconnect fixes Daniel Wagner
2023-08-29  9:13 ` [RFC v1 1/4] nvmet-trace: avoid dereferencing pointer too early Daniel Wagner
2023-08-29 11:21   ` kernel test robot
2023-08-29 19:55   ` kernel test robot [this message]
2023-08-29 20:37   ` kernel test robot
2023-09-05  6:48   ` Christoph Hellwig
2023-09-05  8:24     ` Daniel Wagner
2023-09-05  8:33       ` Christoph Hellwig
2023-09-06 11:00   ` Hannes Reinecke
2023-09-06 15:19   ` kernel test robot
2023-08-29  9:13 ` [RFC v1 2/4] nvmet-trace: null terminate device name string correctly Daniel Wagner
2023-09-05  6:49   ` Christoph Hellwig
2023-09-05 10:25     ` Daniel Wagner
2023-09-06 11:01   ` Hannes Reinecke
2023-08-29  9:13 ` [RFC v1 3/4] nvmet-fc: untangle cross refcounting objects Daniel Wagner
2023-09-06 11:22   ` Hannes Reinecke
2023-09-11 10:08     ` Daniel Wagner
2023-08-29  9:13 ` [RFC v1 4/4] nvmet-discovery: do not use invalid port Daniel Wagner
2023-09-05  6:50   ` Christoph Hellwig
2023-09-05 10:40     ` Daniel Wagner
2023-09-11 14:44       ` Daniel Wagner
2023-09-11 18:19         ` Daniel Wagner
2023-09-12  6:38           ` Daniel Wagner
2023-09-13 11:35             ` Christoph Hellwig
2023-09-13 11:59               ` Daniel Wagner
2023-09-06 11:23   ` Hannes Reinecke
2023-08-29  9:13 ` [RFC v1 4/4] nvmet-discovery: Do " Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202308300317.0x6Otev1-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=dwagner@suse.de \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.