From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99C48C83F29 for ; Thu, 31 Aug 2023 07:16:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231689AbjHaHQ2 (ORCPT ); Thu, 31 Aug 2023 03:16:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbjHaHQ1 (ORCPT ); Thu, 31 Aug 2023 03:16:27 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8380AE62; Thu, 31 Aug 2023 00:16:02 -0700 (PDT) Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 75645836; Thu, 31 Aug 2023 09:14:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1693466054; bh=tVpuZI+y28Ywlldd4PZ6z5BJVpXZjNaH4iaRbuAIPbI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lu2ZvOQ6sdIZ+07h4wvxA+rgmdmI7xLnvfEztbfY4wd9O0X7cNRGhrbrF4SEwlslZ VMvY9qmgXY7M6IuqD93rozTmaHdikGsVeCIu+ej4t8QF3BASPmahKkatNYrDvD+NKA b+Xm8/4rrLr2ZlgJBgLU9eaqIHn2UY1y8/lOkrs8= Date: Thu, 31 Aug 2023 10:15:47 +0300 From: Laurent Pinchart To: Christophe JAILLET Cc: Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sakari Ailus , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] media: imx-mipi-csis: Remove an incorrect fwnode_handle_put() call Message-ID: <20230831071547.GC2698@pendragon.ideasonboard.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org Hi Christophe, Thank you for the patch. On Wed, Aug 30, 2023 at 11:06:14PM +0200, Christophe JAILLET wrote: > The commit in Fixes has removed an fwnode_graph_get_endpoint_by_id() call > in mipi_csis_subdev_init(). > So the reference that was taken should not be released anymore in the > error handling path of the probe and in the remove function. > > Remove the now incorrect fwnode_handle_put() calls. > > Fixes: 1029939b3782 ("media: v4l: async: Simplify async sub-device fwnode matching") > Signed-off-by: Christophe JAILLET Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/nxp/imx-mipi-csis.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/platform/nxp/imx-mipi-csis.c > index 16f19a640130..5f93712bf485 100644 > --- a/drivers/media/platform/nxp/imx-mipi-csis.c > +++ b/drivers/media/platform/nxp/imx-mipi-csis.c > @@ -1490,7 +1490,6 @@ static int mipi_csis_probe(struct platform_device *pdev) > v4l2_async_unregister_subdev(&csis->sd); > err_disable_clock: > mipi_csis_clk_disable(csis); > - fwnode_handle_put(csis->sd.fwnode); > > return ret; > } > @@ -1510,7 +1509,6 @@ static void mipi_csis_remove(struct platform_device *pdev) > mipi_csis_clk_disable(csis); > v4l2_subdev_cleanup(&csis->sd); > media_entity_cleanup(&csis->sd.entity); > - fwnode_handle_put(csis->sd.fwnode); > pm_runtime_set_suspended(&pdev->dev); > } > -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D6ADC83F2B for ; Thu, 31 Aug 2023 07:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FM8zRMEWZCAXCFChfx+ajxFNChGRyRuisQ7/Tfy5f/k=; b=nqHzD1jfOkNkVi tdO+YhvuL+izXfOZAm//QGNr6T6mUdQHmuRLMgg9PhqoNkSmYBQBKnqX+l9DuggWxjOsjYKSAWHD0 WnErQYznYM819b0bz6Prui9p/yBMO6YLZzmK7levp68IWmxWH84iCR+tbNp8GPYOubfo0XU4PQyvP ecECatlByKGs3uXsGInB7PUGxF59X7HFpv7/sEmdY4oWJb/dr5Bii2qJjJDjomTx3hkKq5hEfNE6X O4kBhQrl9D6Qs49NxgDRqyPpg05TNhnYWpsK5WAxRDUnMzJnirMZwfhG5kVXcuVC9bdGF6QyQ8/Qe sdE0uHe53Cw9mXLYXiTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbbu6-00Eo3m-1W; Thu, 31 Aug 2023 07:15:46 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qbbu2-00Eo2o-0v for linux-arm-kernel@lists.infradead.org; Thu, 31 Aug 2023 07:15:44 +0000 Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 75645836; Thu, 31 Aug 2023 09:14:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1693466054; bh=tVpuZI+y28Ywlldd4PZ6z5BJVpXZjNaH4iaRbuAIPbI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lu2ZvOQ6sdIZ+07h4wvxA+rgmdmI7xLnvfEztbfY4wd9O0X7cNRGhrbrF4SEwlslZ VMvY9qmgXY7M6IuqD93rozTmaHdikGsVeCIu+ej4t8QF3BASPmahKkatNYrDvD+NKA b+Xm8/4rrLr2ZlgJBgLU9eaqIHn2UY1y8/lOkrs8= Date: Thu, 31 Aug 2023 10:15:47 +0300 From: Laurent Pinchart To: Christophe JAILLET Cc: Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sakari Ailus , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] media: imx-mipi-csis: Remove an incorrect fwnode_handle_put() call Message-ID: <20230831071547.GC2698@pendragon.ideasonboard.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230831_001543_388673_31F71A88 X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Christophe, Thank you for the patch. On Wed, Aug 30, 2023 at 11:06:14PM +0200, Christophe JAILLET wrote: > The commit in Fixes has removed an fwnode_graph_get_endpoint_by_id() call > in mipi_csis_subdev_init(). > So the reference that was taken should not be released anymore in the > error handling path of the probe and in the remove function. > > Remove the now incorrect fwnode_handle_put() calls. > > Fixes: 1029939b3782 ("media: v4l: async: Simplify async sub-device fwnode matching") > Signed-off-by: Christophe JAILLET Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/nxp/imx-mipi-csis.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/platform/nxp/imx-mipi-csis.c > index 16f19a640130..5f93712bf485 100644 > --- a/drivers/media/platform/nxp/imx-mipi-csis.c > +++ b/drivers/media/platform/nxp/imx-mipi-csis.c > @@ -1490,7 +1490,6 @@ static int mipi_csis_probe(struct platform_device *pdev) > v4l2_async_unregister_subdev(&csis->sd); > err_disable_clock: > mipi_csis_clk_disable(csis); > - fwnode_handle_put(csis->sd.fwnode); > > return ret; > } > @@ -1510,7 +1509,6 @@ static void mipi_csis_remove(struct platform_device *pdev) > mipi_csis_clk_disable(csis); > v4l2_subdev_cleanup(&csis->sd); > media_entity_cleanup(&csis->sd.entity); > - fwnode_handle_put(csis->sd.fwnode); > pm_runtime_set_suspended(&pdev->dev); > } > -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel