From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27946C83F10 for ; Thu, 31 Aug 2023 09:29:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 779BA10E5C9; Thu, 31 Aug 2023 09:29:44 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F71010E5C9 for ; Thu, 31 Aug 2023 09:29:41 +0000 (UTC) Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 91366223; Thu, 31 Aug 2023 11:28:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1693474096; bh=mmnCc3usX68hnUMuwcOIGkPfRe9piFESiry8XIREDig=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OAeOv++2BFnN1qI03k2/aReiZ72KzGhxZOBWTvm+75qqO7s8OoW2knicCyGZGxbt/ srvFt9qge3PU4SyuwNbmakWpKZcUA0QLksetsWEjDoj8PO3lM2q+sY5zKKalio7tlL boyzq/4E6XpWjJlcPvkEbZrFZd+p1gc6VBfN1pOA= Date: Thu, 31 Aug 2023 12:29:49 +0300 From: Laurent Pinchart To: Biju Das Subject: Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers Message-ID: <20230831092949.GE2698@pendragon.ideasonboard.com> References: <20230831080938.47454-1-biju.das.jz@bp.renesas.com> <20230831080938.47454-4-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230831080938.47454-4-biju.das.jz@bp.renesas.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Zhu Wang , Andy Shevchenko , Robert Foss , Andrzej Hajda , Sam Ravnborg , Jonas Karlman , Sandor Yu , dri-devel@lists.freedesktop.org, =?utf-8?Q?Adri=C3=A1n?= Larumbe , Douglas Anderson , Jernej Skrabec , linux-kernel@vger.kernel.org, Ondrej Jirman , Guillaume BRUN , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Thierry Reding Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Biju, Thank you for the patch. On Thu, Aug 31, 2023 at 09:09:37AM +0100, Biju Das wrote: > Having conditional around the of_node pointers turns out to make driver > code use ugly #ifdef and #if blocks. So drop the conditionals. > > Suggested-by: Douglas Anderson > Signed-off-by: Biju Das > Reviewed-by: Douglas Anderson Reviewed-by: Laurent Pinchart > --- > v5->v6: > * Added Rb tag from Douglas Anderson. > * Dropped conditionals from remaining drm/bridge drivers. > v5: > * Split from patch#2 > --- > drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 -- > drivers/gpu/drm/bridge/panel.c | 2 -- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 -- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 -- > 4 files changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > index 6169db73d2fe..ad8241758896 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > @@ -1231,9 +1231,7 @@ static int anx78xx_i2c_probe(struct i2c_client *client) > > mutex_init(&anx78xx->lock); > > -#if IS_ENABLED(CONFIG_OF) > anx78xx->bridge.of_node = client->dev.of_node; > -#endif > > anx78xx->client = client; > i2c_set_clientdata(client, anx78xx); > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > index 9316384b4474..7f41525f7a6e 100644 > --- a/drivers/gpu/drm/bridge/panel.c > +++ b/drivers/gpu/drm/bridge/panel.c > @@ -302,9 +302,7 @@ struct drm_bridge *drm_panel_bridge_add_typed(struct drm_panel *panel, > panel_bridge->panel = panel; > > panel_bridge->bridge.funcs = &panel_bridge_bridge_funcs; > -#ifdef CONFIG_OF > panel_bridge->bridge.of_node = panel->dev->of_node; > -#endif > panel_bridge->bridge.ops = DRM_BRIDGE_OP_MODES; > panel_bridge->bridge.type = connector_type; > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 6c1d79474505..52d91a0df85e 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -3541,9 +3541,7 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev, > | DRM_BRIDGE_OP_HPD; > hdmi->bridge.interlace_allowed = true; > hdmi->bridge.ddc = hdmi->ddc; > -#ifdef CONFIG_OF > hdmi->bridge.of_node = pdev->dev.of_node; > -#endif > > memset(&pdevinfo, 0, sizeof(pdevinfo)); > pdevinfo.parent = dev; > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > index 04d4a1a10698..a8dd2a2e7c7b 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > @@ -1182,9 +1182,7 @@ __dw_mipi_dsi_probe(struct platform_device *pdev, > > dsi->bridge.driver_private = dsi; > dsi->bridge.funcs = &dw_mipi_dsi_bridge_funcs; > -#ifdef CONFIG_OF > dsi->bridge.of_node = pdev->dev.of_node; > -#endif > > return dsi; > } -- Regards, Laurent Pinchart