[freescale-fslc:pr/639 6233/24603] drivers/base/power/domain.c:255:6: warning: no previous prototype for function 'pm_genpd_disable_clks'

[kernel test robot <lkp@intel.com>]

Hi Dong,

FYI, the error/warning still remains.

tree:   https://github.com/Freescale/linux-fslc pr/639
head:   857fbf7cebaba3b1ffccc558deee1d13ac0e11d7
commit: c85126180a10439a8c7db1800529b4857d91c609 [6233/24603] LF-4713-1 PM: domains: add pm domain clocks support
config: arm64-randconfig-r013-20230831 (https://download.01.org/0day-ci/archive/20230831/202308311206.F3mCDgWt-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230831/202308311206.F3mCDgWt-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308311206.F3mCDgWt-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/base/power/domain.c:255:6: warning: no previous prototype for function 'pm_genpd_disable_clks' [-Wmissing-prototypes]
     255 | void pm_genpd_disable_clks(struct generic_pm_domain *genpd)
         |      ^
   drivers/base/power/domain.c:255:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     255 | void pm_genpd_disable_clks(struct generic_pm_domain *genpd)
         | ^
         | static 
>> drivers/base/power/domain.c:261:5: warning: no previous prototype for function 'pm_genpd_enable_clks' [-Wmissing-prototypes]
     261 | int pm_genpd_enable_clks(struct generic_pm_domain *genpd)
         |     ^
   drivers/base/power/domain.c:261:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     261 | int pm_genpd_enable_clks(struct generic_pm_domain *genpd)
         | ^
         | static 
   2 warnings generated.


vim +/pm_genpd_disable_clks +255 drivers/base/power/domain.c

   254	
 > 255	void pm_genpd_disable_clks(struct generic_pm_domain *genpd)
   256	{
   257		if (genpd->flags & GENPD_FLAG_PM_PD_CLK && genpd->num_clks > 0)
   258			clk_bulk_disable_unprepare(genpd->num_clks, genpd->clks);
   259	}
   260	
 > 261	int pm_genpd_enable_clks(struct generic_pm_domain *genpd)
   262	{
   263		int ret;
   264	
   265		if (genpd->flags & GENPD_FLAG_PM_PD_CLK && genpd->num_clks > 0) {
   266			ret = clk_bulk_prepare_enable(genpd->num_clks, genpd->clks);
   267			if (ret) {
   268				dev_err(&genpd->dev, "failed to enable clocks\n");
   269				return ret;
   270			}
   271		}
   272	
   273		return 0;
   274	}
   275	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki