From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Paul Moore <paul@paul-moore.com>,
Stephen Smalley <stephen.smalley.work@gmail.com>,
Eric Paris <eparis@parisplace.org>,
linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org,
selinux@vger.kernel.org
Subject: Re: sb->s_fs_info freeing fixes
Date: Thu, 31 Aug 2023 14:36:19 +0200 [thread overview]
Message-ID: <20230831123619.GB11156@lst.de> (raw)
In-Reply-To: <20230831-tiefbau-freuden-3e8225acc81d@brauner>
On Thu, Aug 31, 2023 at 12:29:11PM +0200, Christian Brauner wrote:
> "Since ramfs/devpts uses get_tree_nodev() it doesn't rely on
> sb->s_fs_info. So there's no use after free risk as with other
> filesystems.
>
> But there's no need to deviate from the standard cleanup logic and cause
> reviewers to verify whether that is safe or not."
>
> and similar for the other two:
>
> "Since hypfs/selinuxfs uses get_tree_single() it doesn't rely on
> sb->s_fs_info. So there's no use after free risk as with other
> filesystems.
>
> But there's no need to deviate from the standard cleanup logic and cause
> reviewers to verify whether that is safe or not."
>
> If that is good enough for people then I can grab it.
Fine with me. And yes, I'd rather not have private data freed before
SB_ACTIVE is cleared even if it is fine right now. It's just a bug
waiting to happen.
next prev parent reply other threads:[~2023-08-31 12:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 5:31 sb->s_fs_info freeing fixes Christoph Hellwig
2023-08-31 5:31 ` [PATCH 1/4] ramfs: free sb->s_fs_info after shutting down the super block Christoph Hellwig
2023-08-31 6:25 ` Al Viro
2023-08-31 5:31 ` [PATCH 2/4] devpts: " Christoph Hellwig
2023-08-31 6:31 ` Al Viro
2023-08-31 5:31 ` [PATCH 3/4] selinuxfs: " Christoph Hellwig
2023-08-31 6:33 ` Al Viro
2023-08-31 5:31 ` [PATCH 4/4] hypfs: " Christoph Hellwig
2023-08-31 6:37 ` Al Viro
2023-08-31 10:20 ` sb->s_fs_info freeing fixes Christian Brauner
2023-08-31 10:29 ` Christian Brauner
2023-08-31 12:36 ` Christoph Hellwig [this message]
2023-08-31 13:11 ` Christian Brauner
2023-08-31 14:38 ` Paul Moore
2023-08-31 14:39 ` Christoph Hellwig
2023-08-31 14:49 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230831123619.GB11156@lst.de \
--to=hch@lst.de \
--cc=agordeev@linux.ibm.com \
--cc=brauner@kernel.org \
--cc=eparis@parisplace.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.