From: Rob Herring <robh@kernel.org>
To: Javier Carrasco <javier.carrasco@wolfvision.net>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>,
Bastian Hecht <hechtb@gmail.com>,
Michael Riesch <michael.riesch@wolfvision.net>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 4/4] dt-bindings: input: touchscreen: st1232: add example with touch-overlay
Date: Thu, 31 Aug 2023 11:22:01 -0500 [thread overview]
Message-ID: <20230831162201.GA2381101-robh@kernel.org> (raw)
In-Reply-To: <20230510-feature-ts_virtobj_patch-v4-4-5c6c0fc1eed6@wolfvision.net>
On Thu, Aug 24, 2023 at 03:17:12PM +0200, Javier Carrasco wrote:
> The st1232 driver supports the overlay-touchscreen and overlay-buttons
> objects defined in the generic touchscreen bindings and implemented in
> the touch-overlay module. Add an example where nodes for an overlay
> touchscreen and overlay buttons are defined.
>
> Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
> ---
> .../input/touchscreen/sitronix,st1232.yaml | 40 ++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.yaml b/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.yaml
> index 1d8ca19fd37a..857b611f84c2 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.yaml
> @@ -48,3 +48,43 @@ examples:
> gpios = <&gpio1 166 0>;
> };
> };
> + - |
> + #include <dt-bindings/input/linux-event-codes.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + touchscreen@55 {
> + compatible = "sitronix,st1232";
> + reg = <0x55>;
> + interrupts = <2 0>;
> + gpios = <&gpio1 166 0>;
Just add this to the existing example. No value in 2 examples.
> +
> + overlay-touchscreen {
> + x-origin = <0>;
> + x-size = <240>;
> + y-origin = <40>;
> + y-size = <280>;
> + };
> +
> + overlay-buttons {
> + button-light {
> + label = "Camera light";
> + linux,code = <KEY_LIGHTS_TOGGLE>;
> + x-origin = <40>;
> + x-size = <40>;
> + y-origin = <0>;
> + y-size = <40>;
> + };
> +
> + button-power {
> + label = "Power";
> + linux,code = <KEY_POWER>;
> + x-origin = <160>;
> + x-size = <40>;
> + y-origin = <0>;
> + y-size = <40>;
> + };
> + };
> + };
> + };
>
> --
> 2.39.2
>
prev parent reply other threads:[~2023-08-31 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 13:17 [PATCH v4 0/4] Input: support overlay objects on touchscreens Javier Carrasco
2023-08-24 13:17 ` [PATCH v4 1/4] Input: touch-overlay - Add touchscreen overlay object handling Javier Carrasco
2023-08-24 13:17 ` [PATCH v4 2/4] dt-bindings: touchscreen: add overlay-touchscreen and overlay-buttons properties Javier Carrasco
2023-08-31 11:48 ` Rob Herring
2023-10-13 9:54 ` Javier Carrasco
2023-08-24 13:17 ` [PATCH v4 3/4] Input: st1232 - add touch overlays handling Javier Carrasco
2023-08-24 13:17 ` [PATCH v4 4/4] dt-bindings: input: touchscreen: st1232: add example with touch-overlay Javier Carrasco
2023-08-31 16:22 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230831162201.GA2381101-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hechtb@gmail.com \
--cc=javier.carrasco@wolfvision.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.riesch@wolfvision.net \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.