From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EB8D168B0 for ; Thu, 31 Aug 2023 08:30:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693470656; x=1725006656; h=date:from:to:cc:subject:message-id:mime-version; bh=JvNi8oInc6LdhZUUwqdn1xDNqcC1UNJ1L7OusUq3qmk=; b=TVvC54Dl0dbX1Fpd4OWApgfjGt4ExH4FNxv7GKL/Sir/38anmv9Vo21U nTf0CklAe1FrzlqqdC4JKv0SEndFqHfkRXfkSkp7FG5XyMk/FtCohonDP aZ18/hz9x+Jwv0KyMUa54VZENIPvkC5oWV1DEwMH2dmzAYdtTH8vi9oPI 4XgXGDnzTCFZxlOWPo9Q63+tga4lT4pXHV6/sBxsx9AxFRfVG6asKY1k6 zo3VPxBsHb65h8ybE0cjaSFZBQ5mrWIDlmLh8b8clZrUlTuIJiEMotEBC 8GxXEVLGZ+1fIoXLUZGAd5ptXHRFXLkEbK/JO5cVM2r72AZLi0U7ZuZSb Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10818"; a="360852385" X-IronPort-AV: E=Sophos;i="6.02,216,1688454000"; d="scan'208";a="360852385" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2023 01:30:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10818"; a="986122754" X-IronPort-AV: E=Sophos;i="6.02,216,1688454000"; d="scan'208";a="986122754" Received: from lkp-server02.sh.intel.com (HELO daf8bb0a381d) ([10.239.97.151]) by fmsmga006.fm.intel.com with ESMTP; 31 Aug 2023 01:30:53 -0700 Received: from kbuild by daf8bb0a381d with local (Exim 4.96) (envelope-from ) id 1qbd4h-000B7i-0P; Thu, 31 Aug 2023 08:30:48 +0000 Date: Thu, 31 Aug 2023 16:30:12 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com Subject: Re: [PATCH] init: fix -Wmissing-variable-declarations clang warning Message-ID: <202308311652.8dtXginO-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline :::::: :::::: Manual check reason: "git am base is a link in commit message" :::::: BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev In-Reply-To: <20230830-missingvardecl2-init-main-c-v1-1-59007a637259@google.com> References: <20230830-missingvardecl2-init-main-c-v1-1-59007a637259@google.com> TO: Justin Stitt TO: Nathan Chancellor TO: Nick Desaulniers TO: Tom Rix CC: Jens Axboe CC: Peter Zijlstra CC: "Rafael J. Wysocki" CC: linux-kernel@vger.kernel.org CC: llvm@lists.linux.dev CC: Justin Stitt Hi Justin, kernel test robot noticed the following build errors: [auto build test ERROR on 706a741595047797872e669b3101429ab8d378ef] url: https://github.com/intel-lab-lkp/linux/commits/Justin-Stitt/init-fix-Wmissing-variable-declarations-clang-warning/20230831-042021 base: 706a741595047797872e669b3101429ab8d378ef patch link: https://lore.kernel.org/r/20230830-missingvardecl2-init-main-c-v1-1-59007a637259%40google.com patch subject: [PATCH] init: fix -Wmissing-variable-declarations clang warning :::::: branch date: 12 hours ago :::::: commit date: 12 hours ago config: csky-randconfig-r011-20230831 (https://download.01.org/0day-ci/archive/20230831/202308311652.8dtXginO-lkp@intel.com/config) compiler: csky-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230831/202308311652.8dtXginO-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/r/202308311652.8dtXginO-lkp@intel.com/ All errors (new ones prefixed by >>): init/do_mounts_initrd.c: In function 'handle_initrd': >> init/do_mounts_initrd.c:102:60: error: passing argument 3 of 'call_usermodehelper_setup' from incompatible pointer type [-Werror=incompatible-pointer-types] 102 | info = call_usermodehelper_setup("/linuxrc", argv, envp_init, | ^~~~~~~~~ | | | const char ** In file included from include/linux/kmod.h:9, from init/do_mounts_initrd.c:10: include/linux/umh.h:37:65: note: expected 'char **' but argument is of type 'const char **' 37 | call_usermodehelper_setup(const char *path, char **argv, char **envp, | ~~~~~~~^~~~ cc1: some warnings being treated as errors -- >> init/main.c:189:20: error: static declaration of 'envp_init' follows non-static declaration 189 | static const char *envp_init[MAX_INIT_ENVS+2] = { "HOME=/", "TERM=linux", NULL, }; | ^~~~~~~~~ In file included from init/main.c:28: include/linux/initrd.h:37:20: note: previous declaration of 'envp_init' with type 'const char *[]' 37 | extern const char *envp_init[]; | ^~~~~~~~~ vim +/call_usermodehelper_setup +102 init/do_mounts_initrd.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 85 c8643c72bc4278 Christoph Hellwig 2023-05-31 86 static void __init handle_initrd(char *root_device_name) ^1da177e4c3f41 Linus Torvalds 2005-04-16 87 { 907ed1328d2a74 Lucas De Marchi 2013-04-30 88 struct subprocess_info *info; ba4df2808a86f8 Al Viro 2012-10-02 89 static char *argv[] = { "linuxrc", NULL, }; ^1da177e4c3f41 Linus Torvalds 2005-04-16 90 int error; ^1da177e4c3f41 Linus Torvalds 2005-04-16 91 9acc17baf1fd63 Christoph Hellwig 2020-07-08 92 pr_warn("using deprecated initrd support, will be removed in 2021.\n"); 9acc17baf1fd63 Christoph Hellwig 2020-07-08 93 ^1da177e4c3f41 Linus Torvalds 2005-04-16 94 real_root_dev = new_encode_dev(ROOT_DEV); bdaf8529385d51 Greg Kroah-Hartman 2005-06-20 95 create_dev("/dev/root.old", Root_RAM0); ^1da177e4c3f41 Linus Torvalds 2005-04-16 96 /* mount initrd on rootfs' /root */ c8643c72bc4278 Christoph Hellwig 2023-05-31 97 mount_root_generic("/dev/root.old", root_device_name, c8643c72bc4278 Christoph Hellwig 2023-05-31 98 root_mountflags & ~MS_RDONLY); 83ff98c3e9cd2b Christoph Hellwig 2020-07-22 99 init_mkdir("/old", 0700); db63f1e3153845 Christoph Hellwig 2020-07-22 100 init_chdir("/old"); ^1da177e4c3f41 Linus Torvalds 2005-04-16 101 907ed1328d2a74 Lucas De Marchi 2013-04-30 @102 info = call_usermodehelper_setup("/linuxrc", argv, envp_init, 907ed1328d2a74 Lucas De Marchi 2013-04-30 103 GFP_KERNEL, init_linuxrc, NULL, NULL); 907ed1328d2a74 Lucas De Marchi 2013-04-30 104 if (!info) 907ed1328d2a74 Lucas De Marchi 2013-04-30 105 return; 1fbcaa923ce2d7 Peter Zijlstra 2022-08-22 106 call_usermodehelper_exec(info, UMH_WAIT_PROC|UMH_FREEZABLE); ^1da177e4c3f41 Linus Torvalds 2005-04-16 107 ^1da177e4c3f41 Linus Torvalds 2005-04-16 108 /* move initrd to rootfs' /old */ c60166f04283ff Christoph Hellwig 2020-07-21 109 init_mount("..", ".", NULL, MS_MOVE, NULL); ^1da177e4c3f41 Linus Torvalds 2005-04-16 110 /* switch root and cwd back to / of rootfs */ 4b7ca5014cbef5 Christoph Hellwig 2020-07-22 111 init_chroot(".."); ^1da177e4c3f41 Linus Torvalds 2005-04-16 112 ^1da177e4c3f41 Linus Torvalds 2005-04-16 113 if (new_decode_dev(real_root_dev) == Root_RAM0) { db63f1e3153845 Christoph Hellwig 2020-07-22 114 init_chdir("/old"); ^1da177e4c3f41 Linus Torvalds 2005-04-16 115 return; ^1da177e4c3f41 Linus Torvalds 2005-04-16 116 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 117 db63f1e3153845 Christoph Hellwig 2020-07-22 118 init_chdir("/"); ^1da177e4c3f41 Linus Torvalds 2005-04-16 119 ROOT_DEV = new_decode_dev(real_root_dev); c8643c72bc4278 Christoph Hellwig 2023-05-31 120 mount_root(root_device_name); ^1da177e4c3f41 Linus Torvalds 2005-04-16 121 ^1da177e4c3f41 Linus Torvalds 2005-04-16 122 printk(KERN_NOTICE "Trying to move old root to /initrd ... "); c60166f04283ff Christoph Hellwig 2020-07-21 123 error = init_mount("/old", "/root/initrd", NULL, MS_MOVE, NULL); ^1da177e4c3f41 Linus Torvalds 2005-04-16 124 if (!error) ^1da177e4c3f41 Linus Torvalds 2005-04-16 125 printk("okay\n"); ^1da177e4c3f41 Linus Torvalds 2005-04-16 126 else { f220ab2a5162c3 Jay Lan 2005-06-30 127 if (error == -ENOENT) f220ab2a5162c3 Jay Lan 2005-06-30 128 printk("/initrd does not exist. Ignored.\n"); f220ab2a5162c3 Jay Lan 2005-06-30 129 else ^1da177e4c3f41 Linus Torvalds 2005-04-16 130 printk("failed\n"); ^1da177e4c3f41 Linus Torvalds 2005-04-16 131 printk(KERN_NOTICE "Unmounting old root\n"); 09267defa36aaf Christoph Hellwig 2020-07-23 132 init_umount("/old", MNT_DETACH); ^1da177e4c3f41 Linus Torvalds 2005-04-16 133 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 134 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 135 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki